Bug#569790: Remove selected tracks option (with patch)
tag 569790 fixed-upstream thanks + Lucas van staden (Sun, 14 Feb 2010 22:00:31 +0800): Hi, One of the 'frontends' to our music system does not have a keyboard. Fair enough. I've committed a patch similar to yours, I'll prepare a release some time soon. Cheers, -- - Are you sure we're good? - Always. -- Rory and Lorelai -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#569790: Remove selected tracks option (with patch)
Package: minirok
Version: 2.1
Severity: wishlist
Hi,
Firstly, thank you very much for this player.
Simplistic, easy to use, not resource intensive, and uses the file
system (no library) - everything I wanted
well it seems nearly.
The first thing my biggest user (ie my wife) requested was the ability
to be able to remove selected tracks from the playlist.
The crop feature does do that, but you have to select all the tracks
you want to keep (so it works inverse to a simple 'remove this track'
option)
I thus added a new menu option, which removes the selected track(s)
Regards
Lucas van Staden
www.dedmeet.com (linux)
www.proxiblue.com.au (consumer electronics)
Below is the patch:
u...@pygmy:/usr/share/minirok/minirok$ diff -c playlist.py_ori playlist.py
*** playlist.py_ori 2010-02-14 18:03:35.128477864 +0800
--- playlist.py 2010-02-14 18:11:14.214724875 +0800
***
*** 1116,1126
--- 1116,1128
if len(selected_indexes) == 1:
enqueue_action = menu.addAction('Enqueue track')
+ remove_action = menu.addAction('Remove track')
if index.data(Playlist.RoleQueuePosition).toInt()[0] 0:
enqueue_action.setCheckable(True)
enqueue_action.setChecked(True)
else:
enqueue_action = menu.addAction('Enqueue/Dequeue tracks')
+ remove_action = menu.addAction('Remove selected tracks')
stop_after_action = menu.addAction('Stop playing after
this track')
***
*** 1140,1145
--- 1142,1150
self.model().toggle_stop_after(index)
elif selected_action == crop_action:
self.model().removeItemsCmd(self.unselectedIndexes())
+ elif selected_action == remove_action:
+ self.model().removeItemsCmd(selected_indexes)
+
else:
return QtGui.QTreeView.mousePressEvent(self, event)
Bug#569790: Remove selected tracks option (with patch)
Hello Lucas, you can delete tracks by selecting them and pressing
Delete, just as you'd delete some text. I didn't put an option in the
menu because I didn't want to clutter it. Perhaps it should be there,
hm.
+ Lucas van staden (Sun, 14 Feb 2010 18:27:37 +0800):
Package: minirok
Version: 2.1
Severity: wishlist
Hi,
Firstly, thank you very much for this player.
Simplistic, easy to use, not resource intensive, and uses the file
system (no library) - everything I wanted
well it seems nearly.
The first thing my biggest user (ie my wife) requested was the ability
to be able to remove selected tracks from the playlist.
The crop feature does do that, but you have to select all the tracks
you want to keep (so it works inverse to a simple 'remove this track'
option)
I thus added a new menu option, which removes the selected track(s)
Regards
Lucas van Staden
www.dedmeet.com (linux)
www.proxiblue.com.au (consumer electronics)
Below is the patch:
u...@pygmy:/usr/share/minirok/minirok$ diff -c playlist.py_ori playlist.py
*** playlist.py_ori 2010-02-14 18:03:35.128477864 +0800
--- playlist.py 2010-02-14 18:11:14.214724875 +0800
***
*** 1116,1126
--- 1116,1128
if len(selected_indexes) == 1:
enqueue_action = menu.addAction('Enqueue track')
+ remove_action = menu.addAction('Remove track')
if index.data(Playlist.RoleQueuePosition).toInt()[0] 0:
enqueue_action.setCheckable(True)
enqueue_action.setChecked(True)
else:
enqueue_action = menu.addAction('Enqueue/Dequeue tracks')
+ remove_action = menu.addAction('Remove selected tracks')
stop_after_action = menu.addAction('Stop playing after
this track')
***
*** 1140,1145
--- 1142,1150
self.model().toggle_stop_after(index)
elif selected_action == crop_action:
self.model().removeItemsCmd(self.unselectedIndexes())
+ elif selected_action == remove_action:
+ self.model().removeItemsCmd(selected_indexes)
+
else:
return QtGui.QTreeView.mousePressEvent(self, event)
--
- Are you sure we're good?
- Always.
-- Rory and Lorelai
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20100214134249.ga13...@chistera.yi.org
Bug#569790: Remove selected tracks option (with patch)
Hi,
One of the 'frontends' to our music system does not have a keyboard.
-Lucas
On Sun, Feb 14, 2010 at 9:42 PM, Adeodato Simó adeod...@debian.org wrote:
Hello Lucas, you can delete tracks by selecting them and pressing
Delete, just as you'd delete some text. I didn't put an option in the
menu because I didn't want to clutter it. Perhaps it should be there,
hm.
+ Lucas van staden (Sun, 14 Feb 2010 18:27:37 +0800):
Package: minirok
Version: 2.1
Severity: wishlist
Hi,
Firstly, thank you very much for this player.
Simplistic, easy to use, not resource intensive, and uses the file
system (no library) - everything I wanted
well it seems nearly.
The first thing my biggest user (ie my wife) requested was the ability
to be able to remove selected tracks from the playlist.
The crop feature does do that, but you have to select all the tracks
you want to keep (so it works inverse to a simple 'remove this track'
option)
I thus added a new menu option, which removes the selected track(s)
Regards
Lucas van Staden
www.dedmeet.com (linux)
www.proxiblue.com.au (consumer electronics)
Below is the patch:
u...@pygmy:/usr/share/minirok/minirok$ diff -c playlist.py_ori
playlist.py
*** playlist.py_ori 2010-02-14 18:03:35.128477864 +0800
--- playlist.py 2010-02-14 18:11:14.214724875 +0800
***
*** 1116,1126
--- 1116,1128
if len(selected_indexes) == 1:
enqueue_action = menu.addAction('Enqueue track')
+ remove_action = menu.addAction('Remove track')
if index.data(Playlist.RoleQueuePosition).toInt()[0]
0:
enqueue_action.setCheckable(True)
enqueue_action.setChecked(True)
else:
enqueue_action = menu.addAction('Enqueue/Dequeue
tracks')
+ remove_action = menu.addAction('Remove selected
tracks')
stop_after_action = menu.addAction('Stop playing after
this track')
***
*** 1140,1145
--- 1142,1150
self.model().toggle_stop_after(index)
elif selected_action == crop_action:
self.model().removeItemsCmd(self.unselectedIndexes())
+ elif selected_action == remove_action:
+ self.model().removeItemsCmd(selected_indexes)
+
else:
return QtGui.QTreeView.mousePressEvent(self, event)
--
- Are you sure we're good?
- Always.
-- Rory and Lorelai
