Bug#570263: yarssr: Unread items get marked read upon update - patch included
Hi, Am Mittwoch, den 13.07.2011, 21:00 +0200 schrieb Pavel Reznicek: I do not really intend to maintain the yarssr upstream source code, I just tried to fix bugs/features that were stopping me from using it. But I understand your point if you don't use yarssr anymore. I can try to take over the debian-package maintainance, but I never did it before and have also pretty limited time (especially now, most probably won't be able to touch it before mid-autumn). If you would not mind maitaining it for several more months it would be great (I promise I won't sent any more patches :)). if you are interested in taking over the Debian package, that would be fine as well. And of course you can still send patches! Greetings, Joachim -- Joachim nomeata Breitner Debian Developer nome...@debian.org | ICQ# 74513189 | GPG-Keyid: 4743206C JID: nome...@joachim-breitner.de | http://people.debian.org/~nomeata signature.asc Description: This is a digitally signed message part
Bug#570263: yarssr: Unread items get marked read upon update - patch included
Dear Joachim, I do not really intend to maintain the yarssr upstream source code, I just tried to fix bugs/features that were stopping me from using it. But I understand your point if you don't use yarssr anymore. I can try to take over the debian-package maintainance, but I never did it before and have also pretty limited time (especially now, most probably won't be able to touch it before mid-autumn). If you would not mind maitaining it for several more months it would be great (I promise I won't sent any more patches :)). Best regards, Pavel On Tue, 12 Jul 2011, Joachim Breitner wrote: Dear Pavel, thanks for the patch. I’ll review it later. But given that upstream has stopped working on yarssr and stopped answering mails, are you interested in taking over maintenance of yarssr completely? This would involve sending a message to the original maintainer, moving the code to some location that you can access (github, sourceforge, alioth or the likes) and creating release tarballs. As I don’t use yarssr myself any more, I don’t feel like the right person to be the patch submission gateway. Greetings, Joachim
Bug#570263: yarssr: Unread items get marked read upon update - patch included
Package: yarssr
Version: 0.2.2-7
Followup-For: Bug #570263
Hello,
included patch fixes the feature by not unmarking the new items when feeds
are updated - in both cases of automatical and manual update. So the only way
to get rid of new messages would now be by explicitelly clicking on the
Unmark new menuitem. To make this a bit more flexible, I also added the
Umark new menuitem to each feed.
I was also having problems with some RSS not updating (or not picking up all
their items) as mentioned in bug #336667. This turns out to be another feature
of yarssr when each item in a feed was supposed to be uniquely identified by
its link, which is not the case in some RSS feeds (see e.g. the kernel RSS:
http://www.kernel.org/kdist/rss.xml where all items are pointing to the base
http://www.kernel.org link). So the yarssr code was modified to identify each
feed-item by its link and title. See again the attached patch.
Best regards,
Pavel
-- System Information:
Debian Release: wheezy/sid
APT prefers squeeze
APT policy: (950, 'squeeze'), (950, 'sid'), (840,
'testing-proposed-updates'), (840, 'testing'), (740, 'unstable'), (738,
'experimental'), (540, 'proposed-updates'), (540, 'stable')
Architecture: amd64 (x86_64)
Kernel: Linux 2.6.39-2-amd64-ipnp-n22a-4 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=cs_CZ.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Versions of packages yarssr depends on:
ii libgnome2-perl 1.042-2+b1 Perl interface to the GNOME librar
ii libgnome2-vfs-perl 1.081-2 Perl interface to the 2.x series o
ii libgnomevfs2-extra 1:2.24.4-1 GNOME Virtual File System (extra m
ii libgtk2-gladexml-perl 1.007-1+b1 Perl interface to use user interfa
ii libgtk2-perl2:1.223-1+b1 Perl interface to the 2.x series o
ii libgtk2-trayicon-perl 0.06-1+b1Perl interface to fill the system
ii libxml-rss-perl 1.49-1 Perl module for managing RSS (RDF
ii perl5.12.3-7+b1 Larry Wall's Practical Extraction
yarssr recommends no packages.
yarssr suggests no packages.
-- no debconf information
--- yarssr-0.2.2.orig/lib/Yarssr/Parser.pm 2005-03-19 03:52:35.0
+0100
+++ yarssr-0.2.2.new/lib/Yarssr/Parser.pm 2011-07-12 10:10:47.0
+0200
@@ -54,6 +54,7 @@
my $article = Yarssr::Item-new(
url = $link,
title = $item-{'title'},
+ id = $link.___.$item-{'title'},
);
push @items, $article;
}
@@ -82,6 +83,7 @@
my $article = Yarssr::Item-new(
title = $title,
url = $link,
+ id = $link.___.$item-{'title'},
);
push @items,$article;
}
--- yarssr-0.2.2.orig/lib/Yarssr/Item.pm2005-03-19 03:52:35.0
+0100
+++ yarssr-0.2.2.new/lib/Yarssr/Item.pm 2011-07-12 10:08:50.0 +0200
@@ -18,7 +18,7 @@
bless $self,$class;
}
-foreach my $field (qw(title url status parent)) {
+foreach my $field (qw(title url status parent id)) {
*{get_$field} = sub {
my $self = shift;
return $self-{$field};
--- yarssr-0.2.2.orig/lib/Yarssr/Config.pm 2005-03-19 03:52:35.0
+0100
+++ yarssr-0.2.2.new/lib/Yarssr/Config.pm 2011-07-12 10:08:28.0
+0200
@@ -186,6 +186,7 @@
my $item = Yarssr::Item-new(
title = $_-{'title'},
url = $_-{'link'},
+ id = $_-{'link'}.___.$_-{'title'},
parent = $feed,
);
$item-set_status($read);
--- yarssr-0.2.2.orig/lib/Yarssr/Feed.pm2005-03-19 03:52:35.0
+0100
+++ yarssr-0.2.2.new/lib/Yarssr/Feed.pm 2011-07-12 10:14:19.0 +0200
@@ -137,11 +137,11 @@
my @items;
# Set new items as unread
- for ($self-get_items_array) {
- $_-set_status(2) if $_-get_status 2;
- }
+ #for ($self-get_items_array) {
+ #$_-set_status(2) if $_-get_status 2;
+ #}
- $self-reset_newitems();
+ #$self-reset_newitems();
$self-enable if ($self-get_enabled == 3);
my $content = Yarssr::Fetcher-fetch_feed($self);
@@ -155,7 +155,7 @@
for my $item (reverse @items) {
Yarssr::GUI-gui_update;
- unless ($self-get_item_by_url($item-get_url)) {
+ unless ($self-get_item_by_id($item-get_id)) {
$self-unshift_item($item);
$item-set_parent($self);
}
@@ -173,11 +173,11 @@
return
Bug#570263: yarssr: Unread items get marked read upon update - patch included
Dear Pavel, thanks for the patch. I’ll review it later. But given that upstream has stopped working on yarssr and stopped answering mails, are you interested in taking over maintenance of yarssr completely? This would involve sending a message to the original maintainer, moving the code to some location that you can access (github, sourceforge, alioth or the likes) and creating release tarballs. As I don’t use yarssr myself any more, I don’t feel like the right person to be the patch submission gateway. Greetings, Joachim Am Dienstag, den 12.07.2011, 11:47 +0200 schrieb Pavel Reznicek: Package: yarssr Version: 0.2.2-7 Followup-For: Bug #570263 Hello, included patch fixes the feature by not unmarking the new items when feeds are updated - in both cases of automatical and manual update. So the only way to get rid of new messages would now be by explicitelly clicking on the Unmark new menuitem. To make this a bit more flexible, I also added the Umark new menuitem to each feed. I was also having problems with some RSS not updating (or not picking up all their items) as mentioned in bug #336667. This turns out to be another feature of yarssr when each item in a feed was supposed to be uniquely identified by its link, which is not the case in some RSS feeds (see e.g. the kernel RSS: http://www.kernel.org/kdist/rss.xml where all items are pointing to the base http://www.kernel.org link). So the yarssr code was modified to identify each feed-item by its link and title. See again the attached patch. Best regards, Pavel -- System Information: Debian Release: wheezy/sid APT prefers squeeze APT policy: (950, 'squeeze'), (950, 'sid'), (840, 'testing-proposed-updates'), (840, 'testing'), (740, 'unstable'), (738, 'experimental'), (540, 'proposed-updates'), (540, 'stable') Architecture: amd64 (x86_64) Kernel: Linux 2.6.39-2-amd64-ipnp-n22a-4 (SMP w/2 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=cs_CZ.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/bash Versions of packages yarssr depends on: ii libgnome2-perl 1.042-2+b1 Perl interface to the GNOME librar ii libgnome2-vfs-perl 1.081-2 Perl interface to the 2.x series o ii libgnomevfs2-extra 1:2.24.4-1 GNOME Virtual File System (extra m ii libgtk2-gladexml-perl 1.007-1+b1 Perl interface to use user interfa ii libgtk2-perl2:1.223-1+b1 Perl interface to the 2.x series o ii libgtk2-trayicon-perl 0.06-1+b1Perl interface to fill the system ii libxml-rss-perl 1.49-1 Perl module for managing RSS (RDF ii perl5.12.3-7+b1 Larry Wall's Practical Extraction yarssr recommends no packages. yarssr suggests no packages. -- no debconf information -- Joachim nomeata Breitner Debian Developer nome...@debian.org | ICQ# 74513189 | GPG-Keyid: 4743206C JID: nome...@joachim-breitner.de | http://people.debian.org/~nomeata signature.asc Description: This is a digitally signed message part
