Bug#575062: aptitude: file descriptor leak of debtags related files

[Manuel A. Fernandez Montecelo]

Control: tags -1 - moreinfo
Control: close -1


2016-01-13 14:34 Paul Wise:

On Tue, 2016-01-12 at 19:21 +, Manuel A. Fernandez Montecelo wrote:


Paul (or anybody else), have noticed any problem with this in the
several updates at the end of the year?


I don't think I did, no.


I checked in my system for the last couple of upgrades with "debtags"
installed, and also didn't complain.  So it seems that this is not
present anymore.

Therefore, closing now.

Thanks all for the report, follow-ups and the patience :-)

--
Manuel A. Fernandez Montecelo 

Bug#575062: aptitude: file descriptor leak of debtags related files

[Paul Wise]

On Tue, 2016-01-12 at 19:21 +, Manuel A. Fernandez Montecelo wrote:

> Paul (or anybody else), have noticed any problem with this in the
> several updates at the end of the year?

I don't think I did, no.

-- 
bye,
pabs

https://wiki.debian.org/PaulWise




signature.asc
Description: This is a digitally signed message part

Bug#575062: aptitude: file descriptor leak of debtags related files

[Manuel A. Fernandez Montecelo]

2015-11-11 00:43 To Paul Wise:

2015-11-09 0:41 GMT+00:00 Paul Wise :

On Sat, 2015-11-07 at 22:13 +, Manuel A. Fernandez Montecelo wrote:


If you have systems with testing (or unstable, but still didn't upgrade the 
package), could you perhaps try to see if this is still happening

when you upgrade in the next few days, and report back the results in this bug 
report?

I no longer get the warning but I also didn't have debtags installed.

I noticed that debtags ships this file:

==> /etc/apt/apt.conf.d/80debtags <==
// Update the package tags database from new index files
APT::Update::Post-Invoke { "[ ! -x /usr/bin/debtags ] || debtags update || 
true"; };

I would guess that this is responsible, I've installed the debtags
package and will check for the warnings next time I upgrade lvm2.


That's great, thanks Paul.

Hopefully I will remember to check next time lvm2 is updated, to have
more data points.


Paul (or anybody else), have noticed any problem with this in the
several updates at the end of the year?


--
Manuel A. Fernandez Montecelo 

Bug#575062: aptitude: file descriptor leak of debtags related files

[Manuel A. Fernandez Montecelo]

2015-11-09 0:41 GMT+00:00 Paul Wise :
> On Sat, 2015-11-07 at 22:13 +, Manuel A. Fernandez Montecelo wrote:
>
>> If you have systems with testing (or unstable, but still didn't upgrade the 
>> package), could you perhaps try to see if this is still happening
> when you upgrade in the next few days, and report back the results in this 
> bug report?
>
> I no longer get the warning but I also didn't have debtags installed.
>
> I noticed that debtags ships this file:
>
> ==> /etc/apt/apt.conf.d/80debtags <==
> // Update the package tags database from new index files
> APT::Update::Post-Invoke { "[ ! -x /usr/bin/debtags ] || debtags update || 
> true"; };
>
> I would guess that this is responsible, I've installed the debtags
> package and will check for the warnings next time I upgrade lvm2.

That's great, thanks Paul.

Hopefully I will remember to check next time lvm2 is updated, to have
more data points.


Cheers.
-- 
Manuel A. Fernandez Montecelo 

Bug#575062: aptitude: file descriptor leak of debtags related files

[Paul Wise]

On Sat, 2015-11-07 at 22:13 +, Manuel A. Fernandez Montecelo wrote:

> If you have systems with testing (or unstable, but still didn't upgrade the 
> package), could you perhaps try to see if this is still happening
when you upgrade in the next few days, and report back the results in this bug 
report?

I no longer get the warning but I also didn't have debtags installed.

I noticed that debtags ships this file:

==> /etc/apt/apt.conf.d/80debtags <==
// Update the package tags database from new index files
APT::Update::Post-Invoke { "[ ! -x /usr/bin/debtags ] || debtags update || 
true"; };

I would guess that this is responsible, I've installed the debtags
package and will check for the warnings next time I upgrade lvm2.

-- 
bye,
pabs

https://wiki.debian.org/PaulWise




signature.asc
Description: This is a digitally signed message part

Bug#575062: aptitude: file descriptor leak of debtags related files

[Manuel A. Fernandez Montecelo]

Control: tags -1 - confirmed + moreinfo unreproducible


Hi all,

(pabs copied because of the duplicate #611235, abe because of BTS
confirming it as late as 2013)


2010-03-23 08:09 Raphaël Hertzog:

Package: aptitude
Version: 0.6.1.5-3
Severity: important

During upgrade today I got this while upgrading the lvm2 package:

Paramétrage de lvm2 (2.02.62-1) ...
Installation de la nouvelle version du fichier de configuration 
/etc/lvm/lvm.conf ...
Setting up LVM Volume GroupsFile descriptor 43 
(/var/lib/debtags/vocabulary.idx) leaked on vgscan invocation. Parent PID 
17721: /bin/sh
File descriptor 44 (/var/lib/debtags/vocabulary) leaked on vgscan invocation. 
Parent PID 17721: /bin/sh
File descriptor 45 (/var/lib/debtags/package-tags.idx) leaked on vgscan 
invocation. Parent PID 17721: /bin/sh
 Reading all physical volumes.  This may take a while...
 Found volume group "VG-CRYPT" using metadata type lvm2
File descriptor 43 (/var/lib/debtags/vocabulary.idx) leaked on vgchange 
invocation. Parent PID 17721: /bin/sh
File descriptor 44 (/var/lib/debtags/vocabulary) leaked on vgchange invocation. 
Parent PID 17721: /bin/sh
File descriptor 45 (/var/lib/debtags/package-tags.idx) leaked on vgchange 
invocation. Parent PID 17721: /bin/sh
 2 logical volume(s) in volume group "VG-CRYPT" now active
.

I think that aptitude was the process who opened those files. If it's not feel
free to reassign where appropriate. You should ensure those files are
closed when you fork to run dpkg.



2013-01-08 20:34 Axel Beckert:

tags 497129 + confirmed
tags 623609 + moreinfo
found 373846 0.6.4-1
found 373846 0.6.4-1.2
tags 555399 + unreproducible
tags 665794 + moreinfo
# Daniel H. marked it as found
tags 575062 + confirmed
# Daniel H. marked it as found
tags 575062 + confirmed
tags 665794 + moreinfo
# based on report date and aptitude version in Squeeze at that time (i.e. 
didn't try to reproduce it)
found 676365 0.6.3-3.2+squeeze1
thanks



I am quite sure (but not 100%) that I tried to reproduce this a few
weeks ago and that I couldn't.  I also remember seeing these error
messages in the distant past when upgrading myself, but not lately, and
cannot recall if they were related to aptitude/debtags anyway.

The original reports now merged happened in 2010-2011, but no new
reports / seconds since then (except Axel's confirmation in 2013, that
looks more like a BTS bookkeping than a real confirmation).  One of the
messages in the bug reports points to Ubuntu bugs, but it's not related
to debtags or aptitude.

Opening the tags was changed in the last intervening years, from using
libept as intermediary to using xapian directly, so I am wondering if it
was fixed by then.


I already upgraded lvm2 in unstable a couple of days ago, and playing
with this in my main / only machine at the time is quite risky
(esp. because of downgrading)...  but this package was updated on the
last few days in November, and still not in testing ("4 of 5 days old").

If you have systems with testing (or unstable, but still didn't upgrade
the package), could you perhaps try to see if this is still happening
when you upgrade in the next few days, and report back the results in
this bug report?


Cheers.
--
Manuel A. Fernandez Montecelo 

Bug#575062: aptitude: file descriptor leak of debtags related files

[Raphaël Hertzog]

Package: aptitude
Version: 0.6.1.5-3
Severity: important

During upgrade today I got this while upgrading the lvm2 package:

Paramétrage de lvm2 (2.02.62-1) ...
Installation de la nouvelle version du fichier de configuration 
/etc/lvm/lvm.conf ...
Setting up LVM Volume GroupsFile descriptor 43 
(/var/lib/debtags/vocabulary.idx) leaked on vgscan invocation. Parent PID 
17721: /bin/sh
File descriptor 44 (/var/lib/debtags/vocabulary) leaked on vgscan invocation. 
Parent PID 17721: /bin/sh
File descriptor 45 (/var/lib/debtags/package-tags.idx) leaked on vgscan 
invocation. Parent PID 17721: /bin/sh
  Reading all physical volumes.  This may take a while...
  Found volume group VG-CRYPT using metadata type lvm2
File descriptor 43 (/var/lib/debtags/vocabulary.idx) leaked on vgchange 
invocation. Parent PID 17721: /bin/sh
File descriptor 44 (/var/lib/debtags/vocabulary) leaked on vgchange invocation. 
Parent PID 17721: /bin/sh
File descriptor 45 (/var/lib/debtags/package-tags.idx) leaked on vgchange 
invocation. Parent PID 17721: /bin/sh
  2 logical volume(s) in volume group VG-CRYPT now active
.

I think that aptitude was the process who opened those files. If it's not feel
free to reassign where appropriate. You should ensure those files are
closed when you fork to run dpkg.

Cheers,

-- Package-specific info:
aptitude 0.6.1.5 compiled at Mar 12 2010 09:52:06
Compiler: g++ 4.4.3
Compiled against:
  apt version 4.8.0
  NCurses version 5.7
  libsigc++ version: 2.2.4.2
  Ept support enabled.
  Gtk+ support disabled.

Current library versions:
  NCurses version: ncurses 5.7.20100313
  cwidget version: 0.5.16
  Apt version: 4.8.0
linux-gate.so.1 =  (0xf77b5000)
libapt-pkg-libc6.9-6.so.4.8 = /usr/lib/libapt-pkg-libc6.9-6.so.4.8 
(0xf76d9000)
libncursesw.so.5 = /lib/libncursesw.so.5 (0xf7693000)
liblog4cxx.so.10 = /usr/lib/liblog4cxx.so.10 (0xf74ec000)
libsigc-2.0.so.0 = /usr/lib/libsigc-2.0.so.0 (0xf74e6000)
libcwidget.so.3 = /usr/lib/libcwidget.so.3 (0xf7426000)
libept.so.0 = /usr/lib/libept.so.0 (0xf73b3000)
libxapian.so.15 = /usr/lib/libxapian.so.15 (0xf7265000)
libz.so.1 = /usr/lib/libz.so.1 (0xf7251000)
libsqlite3.so.0 = /usr/lib/libsqlite3.so.0 (0xf71cc000)
libboost_iostreams.so.1.40.0 = /usr/lib/libboost_iostreams.so.1.40.0 
(0xf71c1000)
libpthread.so.0 = /lib/i686/cmov/libpthread.so.0 (0xf71a8000)
libstdc++.so.6 = /usr/lib/libstdc++.so.6 (0xf70b3000)
libm.so.6 = /lib/i686/cmov/libm.so.6 (0xf708d000)
libgcc_s.so.1 = /lib/libgcc_s.so.1 (0xf706e000)
libc.so.6 = /lib/i686/cmov/libc.so.6 (0xf6f27000)
libutil.so.1 = /lib/i686/cmov/libutil.so.1 (0xf6f23000)
libdl.so.2 = /lib/i686/cmov/libdl.so.2 (0xf6f1f000)
libaprutil-1.so.0 = /usr/lib/libaprutil-1.so.0 (0xf6eff000)
libdb-4.8.so = /usr/lib/libdb-4.8.so (0xf6d98000)
libapr-1.so.0 = /usr/lib/libapr-1.so.0 (0xf6d6a000)
libbz2.so.1.0 = /lib/libbz2.so.1.0 (0xf6d59000)
librt.so.1 = /lib/i686/cmov/librt.so.1 (0xf6d5)
/lib/ld-linux.so.2 (0xf77b6000)
libuuid.so.1 = /lib/libuuid.so.1 (0xf6d4c000)
libcrypt.so.1 = /lib/i686/cmov/libcrypt.so.1 (0xf6d19000)
libexpat.so.1 = /usr/lib/libexpat.so.1 (0xf6cf3000)
Terminal: xterm
$DISPLAY is set.
`which aptitude`: /usr/bin/aptitude
aptitude version information:

aptitude linkage:

-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable'), (150, 
'experimental')
Architecture: i386 (x86_64)

Kernel: Linux 2.6.32-3-amd64 (SMP w/2 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages aptitude depends on:
ii  apt [libapt-pkg-libc6.9 0.7.25.3 Advanced front-end for dpkg
ii  libboost-iostreams1.40. 1.40.0-6+b1  Boost.Iostreams Library
ii  libc6   2.10.2-6 Embedded GNU C Library: Shared lib
ii  libcwidget3 0.5.16-3 high-level terminal interface libr
ii  libept0 0.5.30   High-level library for managing De
ii  libgcc1 1:4.4.3-4GCC support library
ii  liblog4cxx100.10.0-1.1   A logging library for C++
ii  libncursesw55.7+20100313-1   shared libraries for terminal hand
ii  libsigc++-2.0-0c2a  2.2.4.2-1type-safe Signal Framework for C++
ii  libsqlite3-03.6.23-1 SQLite 3 shared library
ii  libstdc++6  4.4.3-4  The GNU Standard C++ Library v3
ii  libxapian15 1.0.18-1 Search engine library
ii  zlib1g  1:1.2.3.4.dfsg-3 compression library - runtime

Versions of packages aptitude recommends:
ii  apt-xapian-index  0.26   maintenance tools for a Xapian ind
ii  aptitude-doc-en [aptitude-doc 0.6.1.5-3  English manual for aptitude, a ter
ii