Bug#581428: dash: exit with syntax error on configure file
unmerge 581428
reassign 581428 src:parole 0.2.0.2-3
severity 581428 wishlist
retitle 581428 parole: configure script does not accept CONFIG_SHELL=/bin/dash
tags 581428 + upstream patch
quit
Hi Yves-Alexis,
Yves-Alexis Perez wrote:
On jeu., 2010-05-13 at 22:35 +, Gerrit Pape wrote:
The problematic line in the script
is 21295
BROWSER_PLUGIN_DIR=${BROWSER_PLUGIN_DIR:-\${libdir}/mozilla/plugins}
You can workaround this problem with this patch to parole's ./configure
Well, configure files are autogenerated, so that means the problem lies
before that. Does that mean autotools generate incorrect configure
files, or does that means that particular one is buggy?
It is from configure.ac. Patch below.
Or does that
mean dash is definitely doing the wrong thing?
I think it's a dash bug. As a separate but related question, it's
possible the configure script is doing the wrong thing, too. The
Austin standards revision group considered this and decided:
The standard is unclear on this issue, and no conformance
distinction can be made between alternative implementations based
on this. This is being referred to the sponsor.
The next revision of the standard (Issue 8) will probably disallow
this construct, using the proposed wording:
If any unescaped double-quote characters occur within the
string, other than in embedded command substitutions, the
behavior is unspecified.
See http://austingroupbugs.net/view.php?id=221 for details.
It seems we have some other packages which will FTBFS with errors in
configure too, and I guess a fully archive rebuild would exhibit quite
some failures because of that.
http://bugs.debian.org/582952
I'm not finger pointing, but is the dash
change really legit?
Sounds like (useful) finger pointing to me. ;-)
Since the configure script is making use of a murky part of POSIX, I
still consider it an (upstream) bug. Here's a quick patch. Running
autoconf and rebuilding with it (with dash from experimental as
/bin/sh) gives
[...]
| CCLD parole
| /usr/bin/ld: parole-button.o: undefined reference to symbol 'XGrabKey'
| /usr/bin/ld: note: 'XGrabKey' is defined in DSO /usr/lib64/libX11.so.6
| so try adding it to the linker command line
| /usr/lib64/libX11.so.6: could not read symbols: Invalid operation
| collect2: ld returned 1 exit status
which looks like progress to me.
Thoughts welcome, as always.
configure.ac |2 +-
debian/rules |3 ---
2 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/configure.ac b/configure.ac
index 79814b5..29dd50e 100644
--- a/configure.ac
+++ b/configure.ac
@@ -211,7 +211,7 @@ AC_MSG_CHECKING([whether to build the browser plugin])
AM_CONDITIONAL([ENABLE_BROWSER_PLUGIN], [test x$ac_browser_plugin = xyes])
AC_MSG_RESULT([$ac_browser_plugin])
if test x$ac_browser_plugin = xyes; then
-BROWSER_PLUGIN_DIR=${BROWSER_PLUGIN_DIR:-\${libdir}/mozilla/plugins}
+: ${BROWSER_PLUGIN_DIR:=\$libdir/mozilla/plugins}
AC_ARG_VAR([BROWSER_PLUGIN_DIR],[Where to install the browser plugin])
AC_DEFINE(BUILD_BROWSER_PLUGIN, 1, [whether to build with browser plugin
support])
fi
diff --git a/debian/rules b/debian/rules
index 5665df5..a890608 100755
--- a/debian/rules
+++ b/debian/rules
@@ -1,9 +1,6 @@
#!/usr/bin/make -f
#LDFLAGS += -Wl,-z,defs -Wl,--as-needed
-export SHELL=/bin/bash
-export CONFIG_SHELL=/bin/bash
-
%:
dh $@
--
1.7.5.rc3
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#581428: dash: exit with syntax error on configure file
On jeu., 2010-05-13 at 22:35 +, Gerrit Pape wrote:
Hi Yves-Alexis, thanks for the report. It's a different issue than
#581351 and the configure script doesn't run with dash 0.5.4-12 and
0.5.5.1-3 either; posh fails also. The problematic line in the script
is 21295
BROWSER_PLUGIN_DIR=${BROWSER_PLUGIN_DIR:-\${libdir}/mozilla/plugins}
You can workaround this problem with this patch to parole's ./configure
Well, configure files are autogenerated, so that means the problem lies
before that. Does that mean autotools generate incorrect configure
files, or does that means that particular one is buggy? Or does that
mean dash is definitely doing the wrong thing?
It seems we have some other packages which will FTBFS with errors in
configure too, and I guess a fully archive rebuild would exhibit quite
some failures because of that. I'm not finger pointing, but is the dash
change really legit?
Cheers,
--
Yves-Alexis
signature.asc
Description: This is a digitally signed message part
Bug#581428: dash: exit with syntax error on configure file
found 581428 0.5.4-12 0.5.5.1-3
severity 581428 important
quit
On Thu, May 13, 2010 at 12:25:44AM +0200, Yves-Alexis Perez wrote:
On jeu., 2010-05-13 at 00:07 +0200, Yves-Alexis Perez wrote:
Package: dash
Version: 0.5.5.1-4
Severity: grave
Justification: breaks unrelated package
Hey,
I'm not sure if it's the same bug as #581351 (not sure IFS is involved
here).
Parole ./configure is currently failing with a syntax error. Using bash,
zsh or dash 0.5.5.1-3 works.
Giving the actual error:
Hi Yves-Alexis, thanks for the report. It's a different issue than
#581351 and the configure script doesn't run with dash 0.5.4-12 and
0.5.5.1-3 either; posh fails also. The problematic line in the script
is 21295
BROWSER_PLUGIN_DIR=${BROWSER_PLUGIN_DIR:-\${libdir}/mozilla/plugins}
You can workaround this problem with this patch to parole's ./configure
Regards, Gerrit.
--- configure.orig 2010-05-13 22:21:30.0 +
+++ configure 2010-05-13 22:22:50.0 +
@@ -21292,7 +21292,8 @@
{ $as_echo $as_me:${as_lineno-$LINENO}: result: $ac_browser_plugin 5
$as_echo $ac_browser_plugin 6; }
if test x$ac_browser_plugin = xyes; then
-BROWSER_PLUGIN_DIR=${BROWSER_PLUGIN_DIR:-\${libdir}/mozilla/plugins}
+test -n $BROWSER_PLUGIN_DIR ||
+ BROWSER_PLUGIN_DIR=\${libdir}/mozilla/plugins
$as_echo #define BUILD_BROWSER_PLUGIN 1 confdefs.h
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#581428: dash: exit with syntax error on configure file
Package: dash Version: 0.5.5.1-4 Severity: grave Justification: breaks unrelated package Hey, I'm not sure if it's the same bug as #581351 (not sure IFS is involved here). Parole ./configure is currently failing with a syntax error. Using bash, zsh or dash 0.5.5.1-3 works. Parole is currently in NEW so if you need to check the configure file, the dsc is available at http://debian.corsac.net/unstable/parole_0.2.0.2-2.dsc Cheers, -- Yves-Alexis -- System Information: Debian Release: squeeze/sid APT prefers unstable APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable'), (1, 'experimental') Architecture: amd64 (x86_64) Kernel: Linux 2.6.32-2-amd64 (SMP w/2 CPU cores) Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages dash depends on: ii debianutils 3.2.3 Miscellaneous utilities specific t ii dpkg 1.15.7.1 Debian package management system ii libc6 2.10.2-8 Embedded GNU C Library: Shared lib dash recommends no packages. dash suggests no packages. -- debconf information: * dash/sh: true -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#581428: dash: exit with syntax error on configure file
On jeu., 2010-05-13 at 00:07 +0200, Yves-Alexis Perez wrote:
Package: dash
Version: 0.5.5.1-4
Severity: grave
Justification: breaks unrelated package
Hey,
I'm not sure if it's the same bug as #581351 (not sure IFS is involved
here).
Parole ./configure is currently failing with a syntax error. Using bash,
zsh or dash 0.5.5.1-3 works.
Giving the actual error:
checking whether to build the window title plugin... yes
checking whether to build the power manager plugin... yes
checking whether to build the browser plugin... yes
./configure: 21278: Syntax error: ( unexpected (expecting fi)
and lines around 21278:
21272 #===#
21273 # Build browser plugin?#
21274 #===#
21275 # Check whether --enable-browser-plugin was given.
21276 if test ${enable_browser_plugin+set} = set; then :
21277 enableval=$enable_browser_plugin; ac_browser_plugin=$enableval
21278 else
21279 ac_browser_plugin=yes
21280 fi
21281
21282 { $as_echo $as_me:${as_lineno-$LINENO}: checking whether to build the
browser plugin 5
21283 $as_echo_n checking whether to build the browser plugin... 6; }
21284 if test x$ac_browser_plugin = xyes; then
21285 ENABLE_BROWSER_PLUGIN_TRUE=
21286 ENABLE_BROWSER_PLUGIN_FALSE='#'
21287 else
21288 ENABLE_BROWSER_PLUGIN_TRUE='#'
21289 ENABLE_BROWSER_PLUGIN_FALSE=
21290 fi
21291
Hope that helps,
--
Yves-Alexis
signature.asc
Description: This is a digitally signed message part
