Bug#589708: guilt: undeclared dependency on git ( 1:1.8)
On 20 July 2010 08:37, Jonathan Nieder jrnie...@gmail.com wrote:
Package: guilt
Version: 0.33-1
Severity: serious
Justification: policy §3.5
Tags: patch
Hi Iulian, :)
Hello Jonathan
guilt has some code that in my opinion should be patched out in Debian:
| case $gitver in
| 1.5.*) ;; # git config
| 1.6.*) ;; # git config
| 1.7.*) ;; # git config
| *) die Unsupported version of git ($gitver) ;;
| esac
The problem with this code is that it goes behind the package
manager’s back and makes the code obsolete before it really should
be. Because previous versions of guilt would error out when run
with git 1.7.x, now git is going to need to Breaks: old versions of
guilt. Which imposes a constraint during upgrades:
guilt has to be deconfigured before git is upgraded.
That’s even in cases like Bug#576937 where the only incompatibility
between guilt and new git was that created by this check!
Now _upstream_ such a check makes sense because some people are
installing guilt without a package manager. So I think we should
patch it out for Debian, and handle backward incompatibilities
by adding Breaks: to git where necessary.
However, that is not what this patch is about. This patch just
gets dependencies correct for the current situation, where guilt
is going to break itself once git 1.8 comes out... we might as
well declare it.
Thoughts welcome, as always.
Signed-off-by: Jonathan Nieder jrnie...@gmail.com
---
diff --git a/debian/changelog b/debian/changelog
index d254d54..3bc446f 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+guilt (0.33-2) UNRELEASED; urgency=low
+
+ * Depends: git ( 1:1.8).
+
+ -- Jonathan Nieder jrnie...@gmail.com Tue, 20 Jul 2010 02:25:11 -0500
+
guilt (0.33-1) unstable; urgency=low
* New upstream release.
diff --git a/debian/control b/debian/control
index 598edfb..112d4e7 100644
--- a/debian/control
+++ b/debian/control
@@ -12,7 +12,8 @@ Vcs-Git: git://git.debian.org/git/collab-maint/guilt.git
Package: guilt
Architecture: all
-Depends: ${misc:Depends}, git-core (= 1.4)
+Depends: ${misc:Depends}, git-core (= 1.4) | git (= 1:1.7),
+ git-core (= 1:1.7.0.4-1) | git ( 1:1.8)
Description: quilt for git; similar to Mercurial queues
Guilt (Git Quilt) is a series of bash scripts which add a Mercurial
queues-like functionality and interface to git. The one distinguishing
--
Looks good. I will apply the patch tomorrow.
I apologies for the delayed response. I have got some personal things to do
and
I didn't find the time to look at the bugs filled against the packages I
maintain.
Thank you for the patch.
Cheers!
Iulian
Bug#589708: guilt: undeclared dependency on git ( 1:1.8)
Package: guilt
Version: 0.33-1
Severity: serious
Justification: policy §3.5
Tags: patch
Hi Iulian, :)
guilt has some code that in my opinion should be patched out in Debian:
| case $gitver in
| 1.5.*) ;; # git config
| 1.6.*) ;; # git config
| 1.7.*) ;; # git config
| *) die Unsupported version of git ($gitver) ;;
| esac
The problem with this code is that it goes behind the package
manager’s back and makes the code obsolete before it really should
be. Because previous versions of guilt would error out when run
with git 1.7.x, now git is going to need to Breaks: old versions of
guilt. Which imposes a constraint during upgrades:
guilt has to be deconfigured before git is upgraded.
That’s even in cases like Bug#576937 where the only incompatibility
between guilt and new git was that created by this check!
Now _upstream_ such a check makes sense because some people are
installing guilt without a package manager. So I think we should
patch it out for Debian, and handle backward incompatibilities
by adding Breaks: to git where necessary.
However, that is not what this patch is about. This patch just
gets dependencies correct for the current situation, where guilt
is going to break itself once git 1.8 comes out... we might as
well declare it.
Thoughts welcome, as always.
Signed-off-by: Jonathan Nieder jrnie...@gmail.com
---
diff --git a/debian/changelog b/debian/changelog
index d254d54..3bc446f 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+guilt (0.33-2) UNRELEASED; urgency=low
+
+ * Depends: git ( 1:1.8).
+
+ -- Jonathan Nieder jrnie...@gmail.com Tue, 20 Jul 2010 02:25:11 -0500
+
guilt (0.33-1) unstable; urgency=low
* New upstream release.
diff --git a/debian/control b/debian/control
index 598edfb..112d4e7 100644
--- a/debian/control
+++ b/debian/control
@@ -12,7 +12,8 @@ Vcs-Git: git://git.debian.org/git/collab-maint/guilt.git
Package: guilt
Architecture: all
-Depends: ${misc:Depends}, git-core (= 1.4)
+Depends: ${misc:Depends}, git-core (= 1.4) | git (= 1:1.7),
+ git-core (= 1:1.7.0.4-1) | git ( 1:1.8)
Description: quilt for git; similar to Mercurial queues
Guilt (Git Quilt) is a series of bash scripts which add a Mercurial
queues-like functionality and interface to git. The one distinguishing
--
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
