Bug#592133: RFP: curlpp -- C++ wrapper for libcurl
Op woensdag 18 september 2013 20:50:01 schreef Ximin Luo: - All 4 files you install via debian/docs should probably not be installed. NEWS is empty, INSTALL contains instructions for building the package (not needed in a Debian package that's already built), README contains things that can also be found elsewhere in the package. CHANGES should be installed but as /usr/share/doc/*/changelog.gz instead of the placeholderfile that's there now. Done, mostly. I decided to keep the README since it does contain some non-redundant info, it seems weird not to have one even if it's short, and lots of other packages have short READMEs that one could argue are redundant - see /usr/share/doc/*/README. I hope this is OK. I've also used the --link-doc option of dh_installdocs to link libcurlpp-dev's docs to libcurlpp0 to avoid repetition. Thanks. I would indeed argue that most of those READMEs are indeed redundant and should be dropped, but it's not a big deal. - In debian/patches/, both patches should probably have a header Forwarded: http://code.google.com/p/curlpp/issues/detail?id=25;. DEP-3 http://dep.debian.net/deps/dep3/ says in regards to Forwarded: If the field is missing, its implicit value is yes if the Bug field is present, otherwise it's no. The field is really required only if the patch is vendor specific, in that case its value should be not-needed to indicate that the patch must not be forwarded upstream (whereas no simply means that it has not yet been done). for fix-include-config, the field is not-needed since it is vendor-specific (the patch breaks the install for windows users), and for include-dynamic-headers we can omit the field because the Bug field is already present. OK, good. If this is fixed, I think I can sponsor your package. Uploaded new version to mentors, at the previous address: http://mentors.debian.net/debian/pool/main/c/curlpp/curlpp_0.7.3-1.dsc Alright, uploaded. Let me know if there are updates you want sponsored. Thanks for your work so far. -- Thijs Kinkhorst th...@uvt.nl – LIS Unix Universiteit van Tilburg – Library and IT Services • Postbus 90153, 5000 LE Bezoekadres Warandelaan 2 • Tel. 013 466 3035 • G 236 • http://www.uvt.nl signature.asc Description: This is a digitally signed message part.
Bug#592133: RFP: curlpp -- C++ wrapper for libcurl
Hi Ximin, Thanks for your work on curlpp! This is just what we need so I can sponsor your upload. All in all the packaging looks good to me. Good work! Some small comments you may want to address before I upload: - The package description misses full stops (.) behind the sentences, and spells shared wrong. - All 4 files you install via debian/docs should probably not be installed. NEWS is empty, INSTALL contains instructions for building the package (not needed in a Debian package that's already built), README contains things that can also be found elsewhere in the package. CHANGES should be installed but as /usr/share/doc/*/changelog.gz instead of the placeholderfile that's there now. - In debian/patches/, both patches should probably have a header Forwarded: http://code.google.com/p/curlpp/issues/detail?id=25;. - File src/curlpp/autolink.h seems to have a different copyright holder than the rest of the code. This should be listed in debian/copyright. If this is fixed, I think I can sponsor your package. Cheers, Thijs -- Thijs Kinkhorst th...@uvt.nl – LIS Unix Universiteit van Tilburg – Library and IT Services Bezoekadres Warandelaan 2 • Tel. 013 466 3035 • G 236 -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#592133: RFP: curlpp -- C++ wrapper for libcurl
On 18/09/13 13:24, Thijs Kinkhorst wrote: Hi Ximin, Thanks for your work on curlpp! This is just what we need so I can sponsor your upload. All in all the packaging looks good to me. Good work! Thank you! Some small comments you may want to address before I upload: - The package description misses full stops (.) behind the sentences, and spells shared wrong. Done. - All 4 files you install via debian/docs should probably not be installed. NEWS is empty, INSTALL contains instructions for building the package (not needed in a Debian package that's already built), README contains things that can also be found elsewhere in the package. CHANGES should be installed but as /usr/share/doc/*/changelog.gz instead of the placeholderfile that's there now. Done, mostly. I decided to keep the README since it does contain some non-redundant info, it seems weird not to have one even if it's short, and lots of other packages have short READMEs that one could argue are redundant - see /usr/share/doc/*/README. I hope this is OK. I've also used the --link-doc option of dh_installdocs to link libcurlpp-dev's docs to libcurlpp0 to avoid repetition. - In debian/patches/, both patches should probably have a header Forwarded: http://code.google.com/p/curlpp/issues/detail?id=25;. DEP-3 http://dep.debian.net/deps/dep3/ says in regards to Forwarded: If the field is missing, its implicit value is yes if the Bug field is present, otherwise it's no. The field is really required only if the patch is vendor specific, in that case its value should be not-needed to indicate that the patch must not be forwarded upstream (whereas no simply means that it has not yet been done). for fix-include-config, the field is not-needed since it is vendor-specific (the patch breaks the install for windows users), and for include-dynamic-headers we can omit the field because the Bug field is already present. - File src/curlpp/autolink.h seems to have a different copyright holder than the rest of the code. This should be listed in debian/copyright. Done - I've gone and updated debian/copyright to the DEP-5 format too. If this is fixed, I think I can sponsor your package. Uploaded new version to mentors, at the previous address: http://mentors.debian.net/debian/pool/main/c/curlpp/curlpp_0.7.3-1.dsc X -- GPG: 4096R/1318EFAC5FBBDBCE git://github.com/infinity0/pubkeys.git signature.asc Description: OpenPGP digital signature
Bug#592133: RFP: curlpp -- C++ wrapper for libcurl
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 retitle 592133 ITP: curlpp -- C++ wrapper for libcurl owner 592133 ! thanks Hello, I have updated the packaging here: http://anonscm.debian.org/gitweb/?p=users/infinity0-guest/curlpp.git And uploaded to mentors here: https://mentors.debian.net/package/curlpp I would appreciate a sponsor! X On 10/09/13 13:00, Ximin Luo wrote: +goedson I keep forgetting the bugs email addresses aren't subscription mailing lists. On 05/09/13 17:37, Ximin Luo wrote: Package: wnpp Followup-For: Bug #592133 Owner: Ximin Luo infini...@gmx.com Hey, any progress on this? If you don't have time to work on it, I do - in which case please tell me the preferred place to host the git repo - e.g. alioth, debian, etc. Thanks, Ximin - -- GPG: 4096R/1318EFAC5FBBDBCE git://github.com/infinity0/pubkeys.git -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iQIcBAEBCAAGBQJSOJUOAAoJEIYN7zuPZQt52poP/3MiV5PodcTxqppRH39GAFoY Rz5iWXVfvdH7QsbGiKXKqhaihTgfY4hUH799/nt2S0xePmu8HWLOyTSo8U4I7JRq +WwtYbnps1PI18eA9vUjhKYq5fLWZjwTOGu1dV3lmvPXWHH8I2pe0w9rikyjwoCx vB54VMzAOe58U4hmOGDQiP1cystFOiM0la9LKgdFcM3QNAGfTQbfyu6NFmgWVq81 Hh3xaRAfjGEc8mfKa63uM7WlHBVYt7/KfWB1Ij4hfoGYlKrrHIC1vFGO5TE+B9Qn 5bKGF9WhoSkQgWZlYw4ORksQnwunfPmGkwSWGW2pfk+MbtDkp9yDLmSPXrGdVPec Vccpw1y+N2QUHDp4WOzNBSBi1aJGWQfr3Pwj81ZDI73nPqSuWg3/TRba6z9cXH6h nnFfzZb+6xxN4uZvNAbamp/ouD1R8zG8ENqPhVEJM6qAjpNRMHa5Lu1Kut0HH9CR RoO2Xdl/lQ4IOhLhntdraNKbt617wM2tpAPRek5ppEqM/q8SF0CKh/SqWWP68B03 rOfvyTGfWyTL5m/4/5D20WEFCJVt9dT8bolXPObO4Sr9m+gypb01WObnM+l67h2+ 4x1yPxhvRS1ehb+duL3qaeRgCY+X9BzhH5MX37emZTXMWooEgSz3CAA3FG7lU/JZ imJSvSOcjcQFuvdsntPu =ASeM -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#592133: RFP: curlpp -- C++ wrapper for libcurl
+goedson I keep forgetting the bugs email addresses aren't subscription mailing lists. On 05/09/13 17:37, Ximin Luo wrote: Package: wnpp Followup-For: Bug #592133 Owner: Ximin Luo infini...@gmx.com Hey, any progress on this? If you don't have time to work on it, I do - in which case please tell me the preferred place to host the git repo - e.g. alioth, debian, etc. Thanks, Ximin -- GPG: 4096R/1318EFAC5FBBDBCE git://github.com/infinity0/pubkeys.git signature.asc Description: OpenPGP digital signature
Bug#592133: RFP: curlpp -- C++ wrapper for libcurl
Package: wnpp Followup-For: Bug #592133 Owner: Ximin Luo infini...@gmx.com Hey, any progress on this? If you don't have time to work on it, I do - in which case please tell me the preferred place to host the git repo - e.g. alioth, debian, etc. Thanks, Ximin -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
