Bug#598196: Acknowledgement (debian-cd: more patches for documentation)
On Mon, 27 Sep 2010 22:08:43 +0100 Steve McIntyre st...@einval.com wrote: On Mon, Sep 27, 2010 at 09:32:01PM +0930, Karl Goetz wrote: On Mon, 27 Sep 2010 12:00:05 + ow...@bugs.debian.org (Debian Bug Tracking System) wrote: === modified file 'build.sh' --- build.sh 2010-05-27 13:33:26 + +++ build.sh 2010-07-30 13:16:00 + @@ -13,8 +13,8 @@ export COMPLETE=1 fi -if [ $# -gt 1 ] ; then -echo ERROR: too many arguments. 2 +if [ $1 -ne 1 ] ; then +echo ERROR: Invalid number of arguments. 2 exit 1 elif [ -n $1 ] ; then export ARCHES=$1 H. What are you trying to do here? $1 isn't the number of arguments!?! Hm, My reading of the readme.html as that ARCHES was the architecture build.sh was accepting for this run. I've just grepped through the source tree and noticed 'docs/running.html:pcodebuild.sh i386 amd64 powerpc/code/p', which indicates my reading is wrong :). === modified file 'CONF.sh' --- CONF.sh 2010-07-09 11:54:19 + +++ CONF.sh 2010-07-30 13:03:54 + @@ -181,8 +181,8 @@ # them too export MAX_PKG_SIZE=6 -# uncoment this to make build_all.sh try to build a simple CD image if -# the proper official CD run does not work +# Should build_all.sh try to build a simple CD image if the proper official +# CD run does not work? ATTEMPT_FALLBACK=yes # Set your disk type here. Known types are: @@ -357,14 +357,14 @@ # If so we will link to them on the web site. export OMIT_RELEASE_NOTES=1 +# Set this to override the default location +#export RELEASE_NOTES_LOCATION=http://www.debian.org/releases/$CODENAME; + # Set to 1 to not include the doc/tools directories on CD1 # Useful to save space and avoids failures if you have a mirror # without those directories. #export OMIT_DOC_TOOLS=1 -# Set this to override the default location -#export RELEASE_NOTES_LOCATION=http://www.debian.org/releases/$CODENAME; - case $OFFICIAL in Official) export OFFICIAL_VAL=2 OK. The change for ATTEMPT_FALLBACK is good, thanks. But why have you phew. moved the RELEASE_NOTES_LOCATION setting? Harmless, but... keeping the release notes in one place. kk -- Karl Goetz, (Kamping_Kaiser / VK5FOSS) Debian contributor / gNewSense Maintainer http://www.kgoetz.id.au No, I won't join your social networking group signature.asc Description: PGP signature
Bug#598196: Acknowledgement (debian-cd: more patches for documentation)
On Wed, Sep 29, 2010 at 08:11:12PM +0930, Karl Goetz wrote: On Mon, 27 Sep 2010 22:08:43 +0100 Steve McIntyre st...@einval.com wrote: On Mon, Sep 27, 2010 at 09:32:01PM +0930, Karl Goetz wrote: On Mon, 27 Sep 2010 12:00:05 + ow...@bugs.debian.org (Debian Bug Tracking System) wrote: === modified file 'build.sh' --- build.sh2010-05-27 13:33:26 + +++ build.sh2010-07-30 13:16:00 + @@ -13,8 +13,8 @@ export COMPLETE=1 fi -if [ $# -gt 1 ] ; then -echo ERROR: too many arguments. 2 +if [ $1 -ne 1 ] ; then +echo ERROR: Invalid number of arguments. 2 exit 1 elif [ -n $1 ] ; then export ARCHES=$1 H. What are you trying to do here? $1 isn't the number of arguments!?! Hm, My reading of the readme.html as that ARCHES was the architecture build.sh was accepting for this run. I've just grepped through the source tree and noticed 'docs/running.html:pcodebuild.sh i386 amd64 powerpc/code/p', which indicates my reading is wrong :). :-) OK. NAK on this patch then. === modified file 'CONF.sh' --- CONF.sh 2010-07-09 11:54:19 + +++ CONF.sh 2010-07-30 13:03:54 + @@ -181,8 +181,8 @@ # them too export MAX_PKG_SIZE=6 -# uncoment this to make build_all.sh try to build a simple CD image if -# the proper official CD run does not work +# Should build_all.sh try to build a simple CD image if the proper official +# CD run does not work? ATTEMPT_FALLBACK=yes # Set your disk type here. Known types are: @@ -357,14 +357,14 @@ # If so we will link to them on the web site. export OMIT_RELEASE_NOTES=1 +# Set this to override the default location +#export RELEASE_NOTES_LOCATION=http://www.debian.org/releases/$CODENAME; + # Set to 1 to not include the doc/tools directories on CD1 # Useful to save space and avoids failures if you have a mirror # without those directories. #export OMIT_DOC_TOOLS=1 -# Set this to override the default location -#export RELEASE_NOTES_LOCATION=http://www.debian.org/releases/$CODENAME; - case $OFFICIAL in Official) export OFFICIAL_VAL=2 OK. The change for ATTEMPT_FALLBACK is good, thanks. But why have you phew. moved the RELEASE_NOTES_LOCATION setting? Harmless, but... keeping the release notes in one place. OK, cool. Applied in svn now. -- Steve McIntyre, Cambridge, UK.st...@einval.com I suspect most samba developers are already technically insane... Of course, since many of them are Australians, you can't tell. -- Linus Torvalds -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#598196: Acknowledgement (debian-cd: more patches for documentation)
On Mon, 27 Sep 2010 12:00:05 + ow...@bugs.debian.org (Debian Bug Tracking System) wrote: Thank you for filing a new Bug report with Debian. This is an automatically generated reply to let you know your message has been received. Then here are my other two patches. kk -- Karl Goetz, (Kamping_Kaiser / VK5FOSS) Debian contributor / gNewSense Maintainer http://www.kgoetz.id.au No, I won't join your social networking group === modified file 'build.sh' --- build.sh 2010-05-27 13:33:26 + +++ build.sh 2010-07-30 13:16:00 + @@ -13,8 +13,8 @@ export COMPLETE=1 fi -if [ $# -gt 1 ] ; then -echo ERROR: too many arguments. 2 +if [ $1 -ne 1 ] ; then +echo ERROR: Invalid number of arguments. 2 exit 1 elif [ -n $1 ] ; then export ARCHES=$1 === modified file 'CONF.sh' --- CONF.sh 2010-07-09 11:54:19 + +++ CONF.sh 2010-07-30 13:03:54 + @@ -181,8 +181,8 @@ # them too export MAX_PKG_SIZE=6 -# uncoment this to make build_all.sh try to build a simple CD image if -# the proper official CD run does not work +# Should build_all.sh try to build a simple CD image if the proper official +# CD run does not work? ATTEMPT_FALLBACK=yes # Set your disk type here. Known types are: @@ -357,14 +357,14 @@ # If so we will link to them on the web site. export OMIT_RELEASE_NOTES=1 +# Set this to override the default location +#export RELEASE_NOTES_LOCATION=http://www.debian.org/releases/$CODENAME; + # Set to 1 to not include the doc/tools directories on CD1 # Useful to save space and avoids failures if you have a mirror # without those directories. #export OMIT_DOC_TOOLS=1 -# Set this to override the default location -#export RELEASE_NOTES_LOCATION=http://www.debian.org/releases/$CODENAME; - case $OFFICIAL in Official) export OFFICIAL_VAL=2 signature.asc Description: PGP signature
Bug#598196: Acknowledgement (debian-cd: more patches for documentation)
On Mon, Sep 27, 2010 at 09:32:01PM +0930, Karl Goetz wrote: On Mon, 27 Sep 2010 12:00:05 + ow...@bugs.debian.org (Debian Bug Tracking System) wrote: Thank you for filing a new Bug report with Debian. This is an automatically generated reply to let you know your message has been received. Then here are my other two patches. kk -- Karl Goetz, (Kamping_Kaiser / VK5FOSS) Debian contributor / gNewSense Maintainer http://www.kgoetz.id.au No, I won't join your social networking group === modified file 'build.sh' --- build.sh 2010-05-27 13:33:26 + +++ build.sh 2010-07-30 13:16:00 + @@ -13,8 +13,8 @@ export COMPLETE=1 fi -if [ $# -gt 1 ] ; then -echo ERROR: too many arguments. 2 +if [ $1 -ne 1 ] ; then +echo ERROR: Invalid number of arguments. 2 exit 1 elif [ -n $1 ] ; then export ARCHES=$1 H. What are you trying to do here? $1 isn't the number of arguments!?! === modified file 'CONF.sh' --- CONF.sh2010-07-09 11:54:19 + +++ CONF.sh2010-07-30 13:03:54 + @@ -181,8 +181,8 @@ # them too export MAX_PKG_SIZE=6 -# uncoment this to make build_all.sh try to build a simple CD image if -# the proper official CD run does not work +# Should build_all.sh try to build a simple CD image if the proper official +# CD run does not work? ATTEMPT_FALLBACK=yes # Set your disk type here. Known types are: @@ -357,14 +357,14 @@ # If so we will link to them on the web site. export OMIT_RELEASE_NOTES=1 +# Set this to override the default location +#export RELEASE_NOTES_LOCATION=http://www.debian.org/releases/$CODENAME; + # Set to 1 to not include the doc/tools directories on CD1 # Useful to save space and avoids failures if you have a mirror # without those directories. #export OMIT_DOC_TOOLS=1 -# Set this to override the default location -#export RELEASE_NOTES_LOCATION=http://www.debian.org/releases/$CODENAME; - case $OFFICIAL in Official) export OFFICIAL_VAL=2 OK. The change for ATTEMPT_FALLBACK is good, thanks. But why have you moved the RELEASE_NOTES_LOCATION setting? Harmless, but... -- Steve McIntyre, Cambridge, UK.st...@einval.com ...In the UNIX world, people tend to interpret `non-technical user' as meaning someone who's only ever written one device driver. -- Daniel Pead -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
