Bug#613632: Incorrect "ERROR: Incorrect line for eth0 in /etc/network/routes"

[Mathieu Parent]

Package: ifupdown-extra
Version: 0.14
Severity: important
Tags: patch

The static-routes part of the package doesn't work because there is a typo.

See attached the patch.

Would this go in a stable-update?

Regards

Mathieu

-- System Information:
Debian Release: 6.0
  APT prefers squeeze-updates
  APT policy: (500, 'squeeze-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.32-5-amd64 (SMP w/16 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages ifupdown-extra depends on:
ii  bind9-host [host]    1:9.7.2.dfsg.P3-1.1 Version of 'host' bundled with BIN
ii  host                 1:9.7.2.dfsg.P3-1.1 Transitional package
ii  iproute              20100519-3          networking and traffic control too
ii  iputils-arping       3:20100418-3        Tool to send ICMP echo requests to
ii  iputils-ping [ping]  3:20100418-3        Tools to test the reachability of
ii  net-tools            1.60-23             The NET-3 networking toolkit
ii  netcat-traditional [ 1.10-38             TCP/IP swiss army knife

Versions of packages ifupdown-extra recommends:
pn  ethtool                       <none>     (no description available)

ifupdown-extra suggests no packages.

--- 20static-routes-old	2009-08-01 01:43:09.000000000 +0200
+++ 20static-routes	2011-02-16 10:15:21.000000000 +0100
@@ -57,7 +57,7 @@
 	# /etc/network/if-pre-down.d/ (which you don't need to)
 	cat $ROUTEFILE | egrep "${IFACE}$" | 
 	while read network netmask gateway interface ; do
-            if [ -n "$interface" ] && [ -n "$network" ] && [ -n "$netmask" ] && [ "$gateway" = "reject" ] ; then
+            if [ -n "$interface" ] && [ -n "$network" ] && [ -n "$netmask" ] && [ "$gateway" != "reject" ] ; then
                 [ "$VERBOSITY" -eq 1 ] && echo "DEBUG: Deleting route for $network / $netmask through gateway $gateway at $interface"
                     route del -net $network netmask $netmask gw $gateway dev $interface
             else
@@ -69,7 +69,7 @@
 add_static_routes() {
 	cat $ROUTEFILE | egrep "${IFACE}$" | 
 	while read network netmask gateway interface ; do
-            if [ -n "$interface" ] && [ -n "$network" ] && [ -n "$netmask" ] && [ "$gateway" = "reject" ] ; then
+            if [ -n "$interface" ] && [ -n "$network" ] && [ -n "$netmask" ] && [ "$gateway" != "reject" ] ; then
 		[ "$VERBOSITY" -eq 1 ] && echo "DEBUG: Adding route for $network / $netmask through gateway $gateway at $interface"
 		route add -net $network netmask $netmask gw $gateway dev $interface
             else