Bug#617285: pptpsetup: use absolute path for pptp in tunnel file

[James Cameron]

Thanks, taken upstream.

63eea745af41f781b60cfdd39813e4f000ead5f0

pptpsetup - use absolute path to pptp

/usr/sbin may not be in PATH, especially when pptp is configured for use
by non-root user.

See discussion in Debian bug 617285.

Bug#617285: pptpsetup: use absolute path for pptp in tunnel file

[Christoph Biedl]

tags upstream confirmed
thanks

Stefan Kisdaroczi wrote...

> Please consider applying the attached patch. It should not break anything for 
> users using pptp as root, but works for more secure setup's using a non-root 
> user too.

That still seems a wise thing to do. James?

Christoph


signature.asc
Description: Digital signature

Bug#617285: pptpsetup: use absolute path for pptp in tunnel file

[Stefan Kisdaroczi]

Package: pptp-linux
Version: 1.7.2-6
Severity: minor
Tags: patch

Hi,

the tunnel files generated by pptpsetup are not working if pptp is used as non-
root user.

The first paragraph of file USING (root of source tree) suggests using the 
absolute path too:
 Usage Notes
 
 pptp is started as a psuedo-tty child process using pppd's pty option:
 pppd call provider [pppd-options] \
 pty /usr/sbin/pptp hostname --nolaunchpppd [pptp-options]
 ...

Please consider applying the attached patch. It should not break anything for 
users using pptp as root, but works for more secure setup's using a non-root 
user too.

Thanks
Stefan
diff -uNrp pptp-linux-1.7.2.orig/pptpsetup pptp-linux-1.7.2/pptpsetup
--- pptp-linux-1.7.2.orig/pptpsetup	2011-03-07 18:48:40.0 +0100
+++ pptp-linux-1.7.2/pptpsetup	2011-03-07 19:52:39.336169936 +0100
@@ -85,7 +85,7 @@ sub create {
 
 print FILE TUNNEL;
 # written by pptpsetup
-pty pptp $SERVER --nolaunchpppd
+pty /usr/sbin/pptp $SERVER --nolaunchpppd
 lock
 noauth
 nobsdcomp


signature.asc
Description: This is a digitally signed message part.

Bug#617285: pptpsetup: use absolute path for pptp in tunnel file

[Ola Lundqvist]

Hi Stefan

As pptp obviously can be run also for non-root users I'm starting to think
that we should move pptp from /usr/sbin to /usr/bin. That would also solve
this problem, right?

What do you think about that alternative?

Best regards,

// Ola

On Mon, Mar 07, 2011 at 08:44:59PM +0100, Stefan Kisdaroczi wrote:
 Package: pptp-linux
 Version: 1.7.2-6
 Severity: minor
 Tags: patch
 
 Hi,
 
 the tunnel files generated by pptpsetup are not working if pptp is used as 
 non-
 root user.
 
 The first paragraph of file USING (root of source tree) suggests using the 
 absolute path too:
  Usage Notes
  
  pptp is started as a psuedo-tty child process using pppd's pty option:
  pppd call provider [pppd-options] \
  pty /usr/sbin/pptp hostname --nolaunchpppd [pptp-options]
  ...
 
 Please consider applying the attached patch. It should not break anything for 
 users using pptp as root, but works for more secure setup's using a non-root 
 user too.
 
 Thanks
 Stefan





-- 
 - Ola Lundqvist ---
/  o...@debian.org Annebergsslingan 37  \
|  o...@inguza.com  654 65 KARLSTAD  |
|  http://inguza.com/  +46 (0)70-332 1551   |
\  gpg/f.p.: 7090 A92B 18FE 7994 0C36  4FE4 18A1 B1CF 0FE5 3DD9 /
 ---



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org