Package: libdkim
Version: 1:1.0.21-1
Severity: normal
Tags: patch
User: debian-...@lists.debian.org
Usertags: ld-as-needed

(Originally reported as
https://bugs.launchpad.net/ubuntu/+source/libdkim/+bug/770761.)

libdkim puts libraries before the objects that use them on the link
line.  As described in
http://wiki.debian.org/ToolChain/DSOLinking#Only_link_with_needed_libraries,
this must be the other way round to build successfully with 'ld
--as-needed'.  Patch follows.

  * Fix link ordering for 'ld --as-needed'.

diff -u libdkim-1.0.21/debian/Makefile.in libdkim-1.0.21/debian/Makefile.in
--- libdkim-1.0.21/debian/Makefile.in
+++ libdkim-1.0.21/debian/Makefile.in
@@ -51,13 +51,13 @@
        $(AR) $(ARFLAGS) $@ $(libdkim_OBJS)
 
 $(SHLIBFORLINK): $(libdkim_PURE_OBJS)
-       $(SHLIBLINK) -o $@ $(LIBS) $(libdkim_PURE_OBJS)
+       $(SHLIBLINK) -o $@ $(libdkim_PURE_OBJS) $(LIBS)
        -mkdir .lib 2>/dev/null
        [ -z "$(SHLIBSONAME)" ] || (cd .lib \
           && ln -sf ../$(SHLIBFORLINK) $(SHLIBSONAME))
 
 libdkimtest: $(libdkimtest_OBJS) $(SHLIBFORLINK)
-       $(CXX) -L. -ldkim $(LIBS) -o $@ libdkimtest.o
+       $(CXX) -L. -o $@ libdkimtest.o -ldkim $(LIBS)
 
 libdkimtest.o: $(libdkimtest_SOURCES) $(HDRS)
        $(CXX) $(CXXFLAGS) -o $@ -c $<

-- 
Colin Watson                                       [cjwat...@ubuntu.com]



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to