Bug#628247: sofia-sip Bug#628247: Generated code
The same issue happens to me (amd64 debian testing) without trying parallel build. I think there is something wrong with the awk script, or maybe even with mawk in debian testing? Generated sip_extra.h starts like that: --- /** SIP, SIPS or TEL URL */ }; typedef struct sip_p_preferred_identity_s sip_p_preferred_identity_t; /**@ingrourl_t paid_url[1]; /** SIP, SIPS or TEL URL */ }; typedef struct sip_p_preferred_identity_s sip_p_preferred_identity_t; /**@ingrourl_t paid_url[1]; /** SIP, SIPS or TEL URL */ }; ... --- Thanks, Yamato.
Bug#628247: sofia-sip Bug#628247: Generated code
I'm not sure why, but I noticed that the following modification in
msg_parser.awk makes it work for me:
@@ -315,6 +315,7 @@ function templates ()
}
getline header TEMPLATE;
getline template TEMPLATE;
+ getline dummy TEMPLATE;
getline footer TEMPLATE;
if (TEMPLATE1) {
Hope it helps to find the solution!
Disclaimer: I had never seen an awk script before today, and still have no
idea what the implications of this fix can be.
Yamato.
On Sat, Nov 12, 2011 at 12:59 PM, Yamato Tanaka yamato...@gmail.com wrote:
The same issue happens to me (amd64 debian testing) without trying
parallel build.
I think there is something wrong with the awk script, or maybe even with
mawk in debian testing?
Generated sip_extra.h starts like that:
---
/** SIP, SIPS or TEL URL */
};
typedef struct sip_p_preferred_identity_s sip_p_preferred_identity_t;
/**@ingrourl_t paid_url[1]; /** SIP, SIPS or TEL URL */
};
typedef struct sip_p_preferred_identity_s sip_p_preferred_identity_t;
/**@ingrourl_t paid_url[1]; /** SIP, SIPS or TEL URL */
};
...
---
Thanks,
Yamato.
Bug#628247: sofia-sip Bug#628247: Generated code
Nevermind about the previous fix, it repaired the sip_extra.h generation, but many other headers were incorrectly generated. The ultimate fix is to use gawk instead of mawk! apt-get install gawk and make sure the awk alternative is set to gawk makes everything work perfectly. Hope it helps to repair the build system! Yamato. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#628247: sofia-sip Bug#628247: Generated code
severity 628247 important thanks I'm dropping the severity of this one to take it off the release team's radar. It's only a problem for highly parallel builds (and so mostly only for lucas :) and we have a number of easy workarounds to avoid it, one or more of which I'll include with the next upload. In the meantime there's no reason for this to be distracting the people who are looking to track the real RC issues that need resolving for the next release. Cheers, Ron -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#628247: sofia-sip Bug#628247: Generated code
Hi, 2011/8/21 Ron r...@debian.org: I have seen problems like this with parallel builds and generated headers before though, so I am fairly confidant this is the kind of issue we are looking for with this one. I was less confidant that I could fix it 'by eye' though without a better understanding of all the build dependencies and/or the ability to actually reproduce it myself. It will be good if we can find a fix for it - but I'll also downgrade the severity of this bug if we don't find one by the time it becomes a release blocker. None of the normal Debian buildds have been hit by it to date, and don't build with -j10 doesn't seem like a totally unreasonable workaround until we do. I think we have run this kind of problem earlier. If you use parallel builds, do it like make -j4 built-sources make -jN all make -jN check The built-sources target is supposed to generate all the code there is to generate. -- Pekka.Pessi mail at nokia.com -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#628247: sofia-sip Bug#628247: Generated code
Hi, On Thu, Aug 18, 2011 at 11:24:45AM +0300, Pekka Pessi wrote: The header in question sofia-sip/sip_extra.h is autogenerated by an awk script. It would help much if I could see its contents... This is a bug in the makefiles, not the header or the awk script as such. It only shows up under heavily parallel builds. Lucas usually builds these with `make -j10`, and even then a test rebuild showed we don't always lose the race, it depends on the order the threads complete. I've never seen it happen with -j4 on a quad core box (and I think I've run some at -j8 on a hyperthreaded quad too and didn't see it fail on that either). At the instant of the failure, the header would have been partially complete (or perhaps partially overwritten by another thread that also tried to make it) - by the time the build actually ceases though it will probably look just fine. What we're looking for is a hole in the makefile prerequisites that either doesn't serialise creation of this file correctly, or that leads to it being created by two separate goals, where the second one overwrites the output of the first (possibly while the targets of the first are actually trying to use it). I had a quick look through the makefiles myself at the time (and pinged you on #sofia-sip to see if it was already known), but no obvious problem jumped out at me, and I haven't had enough spare time to fully analyse the dependency chain there. I have seen problems like this with parallel builds and generated headers before though, so I am fairly confidant this is the kind of issue we are looking for with this one. I was less confidant that I could fix it 'by eye' though without a better understanding of all the build dependencies and/or the ability to actually reproduce it myself. It will be good if we can find a fix for it - but I'll also downgrade the severity of this bug if we don't find one by the time it becomes a release blocker. None of the normal Debian buildds have been hit by it to date, and don't build with -j10 doesn't seem like a totally unreasonable workaround until we do. Cheers, Ron -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#628247: Generated code
Hi, The header in question sofia-sip/sip_extra.h is autogenerated by an awk script. It would help much if I could see its contents... -- Pekka.Pessi mail at nokia.com -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
