Package: nodm
Version: 0.10-1
Severity: wishlist
Tags: patch

The idempotency property of initscripts is really useful, but nodm
slightly ruins it by printing what (on first glance) appear to be
errors ("Already started!" / "Already stopped!").

Unless there was a problem changing the state, I shouldn't see any
messages of this sort. This is the de facto policy of most other
daemons.

Patch attached.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      la...@debian.org
       `-
diff --git a/debian/nodm.init b/debian/nodm.init
index 1b8bb6e..bd2ada6 100644
--- a/debian/nodm.init
+++ b/debian/nodm.init
@@ -54,13 +54,13 @@ case "$1" in
                then
                        log_warning_msg "Not starting $NAME because 
NODM_ENABLED is '$NODM_ENABLED' in /etc/default/$NAME"
                else
-                       start-stop-daemon --start --oknodo --pidfile ${PIDFILE} 
--make-pidfile --background --exec /usr/sbin/nodm
+                       start-stop-daemon --start --quiet --oknodo --pidfile 
${PIDFILE} --make-pidfile --background --exec /usr/sbin/nodm
                fi
                [ "$VERBOSE" != no ] && log_end_msg $?
                ;;
        stop)
                [ "$VERBOSE" != no ] && log_daemon_msg "Stopping $DESC" "$NAME"
-               start-stop-daemon --stop --pidfile ${PIDFILE} --oknodo
+               start-stop-daemon --stop --quiet --pidfile ${PIDFILE} --oknodo
                rm -f ${PIDFILE}
                [ "$VERBOSE" != no ] && log_end_msg $?
                ;;

Attachment: signature.asc
Description: PGP signature

Reply via email to