Bug#639593: libdca-utils: No large file support on x86
Am 29.08.2011 16:33, schrieb Reinhard Tartler: I'm personally not familiar enough with the code to make this decision, and in fact, I suppose nobody in pkg-multimedia is. I have rebuilt libdca once without and once with CFLAGS += -D_FILE_OFFSET_BITS=64 and created md5sums of all files in the resulting debian/tmp directory. The only files that differ between both builds are the frontends /usr/bin/dcadec and /usr/bin/extract_dca (which is expected) as well as the static library. The shared library is not affected by these build flags at all. Does anyone have any objections against applying this fix to the Debian package? - Fabian PS: --- /home/fabian/libdts_ohne_fileoffset.txt 2011-10-05 14:31:55.0 +0200 +++ /home/fabian/libdts_mit_fileoffset.txt 2011-10-05 14:41:29.0 +0200 @@ -1,12 +1,12 @@ -d508892ca2322b13cb8e85bcb0a59240 debian/tmp/usr/bin/dcadec +35561d783620424ca242d2f026424f53 debian/tmp/usr/bin/dcadec 183d6daedd432dd7a4b7ee2db47623f2 debian/tmp/usr/bin/extract_dts 183d6daedd432dd7a4b7ee2db47623f2 debian/tmp/usr/bin/dtsdec -7b1e0b8842f53caf0bfc3be31e7b5cc4 debian/tmp/usr/bin/extract_dca +b75d0e4fda4e931c2ad114a6451bc45a debian/tmp/usr/bin/extract_dca 694cff06059055bd5cb6f0b111a89ae8 debian/tmp/usr/include/dts.h db3e9fdd256e101ea69e3d313d2f7ad8 debian/tmp/usr/include/dca.h 241960ed714a5486f5408ec88b32eb20 debian/tmp/usr/share/man/man1/extract_dca.1 66788271bae517672d927a0df8d767fa debian/tmp/usr/share/man/man1/dcadec.1 -10b982f7b2313a0f6f2b9f26e3839083 debian/tmp/usr/lib/libdca.a +b32f48b7b0169aaeecd6f23ea76ae83d debian/tmp/usr/lib/libdca.a 67da4f056c998299866060d011ad0861 debian/tmp/usr/lib/pkgconfig/libdts.pc 8a1fd218df495aa63c65249d5e4654e8 debian/tmp/usr/lib/pkgconfig/libdca.pc 3ea6ca625024247a3b0fa2db929300d2 debian/tmp/usr/lib/libdca.so.0.0.0 -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#639593: libdca-utils: No large file support on x86
A more elegant fix is to add these build flags conditionally by means of getconf, which adds the appropriate flags on i386 but adds nothing new on amd64: $ git diff diff --git a/debian/rules b/debian/rules index ad6f467..89a0069 100755 --- a/debian/rules +++ b/debian/rules @@ -1,5 +1,8 @@ #!/usr/bin/make -f +CFLAGS += $(shell getconf LFS_CFLAGS) +LDFLAGS += $(shell getconf LFS_LDFLAGS) + include /usr/share/cdbs/1/rules/debhelper.mk include /usr/share/cdbs/1/class/autotools.mk Considered reasonable and applied in git now. ;) - Fabian -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#639593: libdca-utils: No large file support on x86
Hi, thanks for the bug report. Am 28.08.2011 14:53, schrieb Julian Hughes: The same command with the same file works normally on amd64. The same command with small files works normally on x86. That's expected. Does it work if you recompile the package with CFLAGS += -D_FILE_OFFSET_BITS=64 in debian/rules? Team mates, will this change the library ABI in an incompatible way? - Fabian -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#639593: libdca-utils: No large file support on x86
On Sun, Aug 28, 2011 at 15:58:16 (CEST), Alessio Treglia wrote: tags 639593 upstream forwarded 639593 https://trac.videolan.org/vlc/ticket/836 thanks Has been rejected for the vlc bugtracker. It seems that libdca does not have a proper backtracker. Therefore, forwarding to the devel mailing list might is more likely to reach people that could do something about this. http://mailman.videolan.org/listinfo/libdca-devel -- Gruesse/greetings, Reinhard Tartler, KeyID 945348A4 -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#639593: libdca-utils: No large file support on x86
Am 29.08.2011 13:59, schrieb Reinhard Tartler: Has been rejected for the vlc bugtracker. It seems that libdca does not have a proper backtracker. Therefore, forwarding to the devel mailing list might is more likely to reach people that could do something about this. http://mailman.videolan.org/listinfo/libdca-devel This has been silent for 4 years now. What's against manually applying CFLAGS += -D_FILE_OFFSET_BITS=64 in the Debian package? - Fabian -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#639593: libdca-utils: No large file support on x86
On Mon, Aug 29, 2011 at 15:08:19 (CEST), Fabian Greffrath wrote: Am 29.08.2011 13:59, schrieb Reinhard Tartler: Has been rejected for the vlc bugtracker. It seems that libdca does not have a proper backtracker. Therefore, forwarding to the devel mailing list might is more likely to reach people that could do something about this. http://mailman.videolan.org/listinfo/libdca-devel This has been silent for 4 years now. Which means that it may or may not be dead upstream. Submitting this patch would check this claim. What's against manually applying CFLAGS += -D_FILE_OFFSET_BITS=64 in the Debian package? I'm personally not familiar enough with the code to make this decision, and in fact, I suppose nobody in pkg-multimedia is. -- Gruesse/greetings, Reinhard Tartler, KeyID 945348A4 -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#639593: libdca-utils: No large file support on x86
On Mon, 29 Aug 2011 13:19:50 +0200 Fabian Greffrath fab...@greffrath.com wrote: Does it work if you recompile the package with CFLAGS += -D_FILE_OFFSET_BITS=64 in debian/rules? Hi Fabian Yes, now it works with large files $ du woodstock.dts 2481332 woodstock.dts $ dcadec -o wavall -r woodstock.dts wood.wav libdca-0.0.5 - by Gildas Bazin gba...@videolan.org based on the a52dec code from Michel Lespinasse wal...@zoy.org and Aaron Holtzman Stream with high frequencies VQ coding ^C5304 frames in 7.91 sec (670.54 fps), 637 last 5.43 sec (117.31 fps) etc. Thank you. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#639593: libdca-utils: No large file support on x86
Package: libdca-utils Version: 0.0.5-3 Severity: normal dcadec fails with large files. Example: $ du woodstock.dts 2481332 woodstock.dts $ dcadec -o wavall -r woodstock.dts wood.wav libdca-0.0.5 - by Gildas Bazin gba...@videolan.org based on the a52dec code from Michel Lespinasse wal...@zoy.org and Aaron Holtzman Value too large for defined data type - could not open file woodstock.dts The same command with the same file works normally on amd64. The same command with small files works normally on x86. -- System Information: Debian Release: 6.0.2 APT prefers stable APT policy: (990, 'stable'), (500, 'stable-updates'), (500, 'unstable'), (1, 'experimental') Architecture: i386 (i686) Kernel: Linux 3.0.1 (SMP w/2 CPU cores; PREEMPT) Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages libdca-utils depends on: ii libc6 2.11.2-10 Embedded GNU C Library: Shared lib ii libdca0 0.0.5-3decoding library for DTS Coherent libdca-utils recommends no packages. libdca-utils suggests no packages. -- no debconf information -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
