Bug#653544: php-mail: Assigning the return value of new by reference is deprecated

[Russell Coker]

Package: php-mail
Version: 1.2.0-2
Severity: normal
Tags: patch

PHP Deprecated:  Assigning the return value of new by reference is deprecated 
in /usr/share/php/Mail/smtp.php on line 349

I see the above message in my Apache error.log when I use php-mail.  The 
attached patch stops the error messages and appears to give exactly the same 
functionality.

-- System Information:
Debian Release: 6.0.3
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.32-5-xen-amd64 (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages php-mail depends on:
ii  php-pear                5.3.3-7+squeeze3 PEAR - PHP Extension and 
Applicati

Versions of packages php-mail recommends:
ii  php-net-smtp                  1.4.2-3    PHP PEAR module implementing SMTP 

php-mail suggests no packages.

-- no debconf information

--- php-mail-1.2.0.orig/Mail-1.2.0/Mail/smtp.php
+++ php-mail-1.2.0/Mail-1.2.0/Mail/smtp.php
@@ -346,7 +346,7 @@
         }
 
         include_once 'Net/SMTP.php';
-        $this->_smtp = &new Net_SMTP($this->host,
+        $this->_smtp = new Net_SMTP($this->host,
                                      $this->port,
                                      $this->localhost);