Bug#672546: xserver-xorg-video-openchrome: FTBFS on hurd-i386: unconditional libdrm requirement

2014-05-07 Thread Gabriele Giacone
On irc, I was told to send patches to xorg-devel@ to get them reviewed. http://www.x.org/wiki/Development/Documentation/SubmittingPatches/ Then I noticed header I add has already been unconditionally added in upstream master so my part is useless.

Bug#672546: xserver-xorg-video-openchrome: FTBFS on hurd-i386: unconditional libdrm requirement

2014-05-06 Thread Gabriele Giacone
Attached another version with needed #defines instead of including embedded drm header. Cleaner? I'd update upstream bug as well. Or do we want simply not to build it on hurd anymore? -- G..e diff -u xserver-xorg-video-openchrome-0.3.3/debian/changelog

Bug#672546: xserver-xorg-video-openchrome: FTBFS on hurd-i386: unconditional libdrm requirement

2014-05-06 Thread Samuel Thibault
Gabriele Giacone, le Tue 06 May 2014 17:00:34 +0200, a écrit : Attached another version with needed #defines instead of including embedded drm header. Cleaner? copy/pasting code is usually never cleaner than just including a header. Or do we want simply not to build it on hurd anymore? If

Bug#672546: xserver-xorg-video-openchrome: FTBFS on hurd-i386: unconditional libdrm requirement

2014-05-06 Thread Gabriele Giacone
On Tue, May 6, 2014 at 5:13 PM, Samuel Thibault sthiba...@debian.org wrote: Gabriele Giacone, le Tue 06 May 2014 17:00:34 +0200, a écrit : Attached another version with needed #defines instead of including embedded drm header. Cleaner? copy/pasting code is usually never cleaner than just

Bug#672546: xserver-xorg-video-openchrome: FTBFS on hurd-i386: unconditional libdrm requirement

2014-05-06 Thread Samuel Thibault
Gabriele Giacone, le Tue 06 May 2014 17:34:06 +0200, a écrit : On Tue, May 6, 2014 at 5:13 PM, Samuel Thibault sthiba...@debian.org wrote: Gabriele Giacone, le Tue 06 May 2014 17:00:34 +0200, a écrit : Attached another version with needed #defines instead of including embedded drm header.

Bug#672546: xserver-xorg-video-openchrome: FTBFS on hurd-i386: unconditional libdrm requirement

2014-05-06 Thread Gabriele Giacone
On Tue, May 06, 2014 at 06:03:18PM +0200, Samuel Thibault wrote: In the meantime, how about applying it It's up to X maintainers to decide. Pino didn't get any feedback from neither Debian nor upstream for 2 years, at least that's what bug trackers say. No mail on openchrome mailing list

Bug#672546: xserver-xorg-video-openchrome: FTBFS on hurd-i386: unconditional libdrm requirement

2014-05-05 Thread Gabriele Giacone
On Sat, Feb 08, 2014 at 10:00:51PM +0100, Samuel Thibault wrote: Well, in the meanwhile the source code has changed, and would need to be fixed to be buildable without libdrm, see via_memmgr.c having a lot of unconditional uses of DRM_*. Perhaps we should rather give up with porting

Bug#672546: xserver-xorg-video-openchrome: FTBFS on hurd-i386: unconditional libdrm requirement

2014-05-05 Thread Samuel Thibault
Gabriele Giacone, le Mon 05 May 2014 16:55:08 +0200, a écrit : +diff --git a/src/via_memmgr.c b/src/via_memmgr.c +index 5d4cc3f..e174771 100644 +--- a/src/via_memmgr.c b/src/via_memmgr.c +@@ -74,6 +74,7 @@ drm_bo_alloc_surface(ScrnInfoPtr pScrn, unsigned int width, unsigned int height,

Bug#672546: xserver-xorg-video-openchrome: FTBFS on hurd-i386: unconditional libdrm requirement

2014-05-05 Thread Gabriele Giacone
On Mon, May 05, 2014 at 04:57:53PM +0200, Samuel Thibault wrote: + pitch = ALIGN_TO(pitch, alignment); Err, this can not work: pitch becomes completely undefined... Only said it would have built, not also worked ;) Attached new workaround. -- G..e diff -u

Bug#672546: xserver-xorg-video-openchrome: FTBFS on hurd-i386: unconditional libdrm requirement

2014-05-05 Thread Samuel Thibault
Gabriele Giacone, le Mon 05 May 2014 18:02:34 +0200, a écrit : On Mon, May 05, 2014 at 04:57:53PM +0200, Samuel Thibault wrote: + pitch = ALIGN_TO(pitch, alignment); Err, this can not work: pitch becomes completely undefined... Only said it would have built, not also worked ;)

Bug#672546: xserver-xorg-video-openchrome: FTBFS on hurd-i386: unconditional libdrm requirement

2014-05-05 Thread Samuel Thibault
And again, see what I wrote: considering how drm seems to be stuffed into its source code, I don't think we want to spend more time on the openchrome driver; the dependency was already dropped from the xorg package, we can just ask ftpmaster to drop the remaining previous binaries. Samuel --

Bug#672546: xserver-xorg-video-openchrome: FTBFS on hurd-i386: unconditional libdrm requirement

2014-05-05 Thread Gabriele Giacone
On Mon, May 5, 2014 at 6:12 PM, Samuel Thibault sthiba...@debian.org wrote: Gabriele Giacone, le Mon 05 May 2014 18:02:34 +0200, a écrit : On Mon, May 05, 2014 at 04:57:53PM +0200, Samuel Thibault wrote: + pitch = ALIGN_TO(pitch, alignment); Err, this can not work: pitch becomes

Bug#672546: xserver-xorg-video-openchrome: FTBFS on hurd-i386: unconditional libdrm requirement

2014-05-05 Thread Samuel Thibault
Gabriele Giacone, le Mon 05 May 2014 23:50:40 +0200, a écrit : On Mon, May 5, 2014 at 6:12 PM, Samuel Thibault sthiba...@debian.org wrote: Gabriele Giacone, le Mon 05 May 2014 18:02:34 +0200, a écrit : On Mon, May 05, 2014 at 04:57:53PM +0200, Samuel Thibault wrote: + pitch =

Bug#672546: xserver-xorg-video-openchrome: FTBFS on hurd-i386: unconditional libdrm requirement

2014-02-08 Thread Samuel Thibault
Samuel Thibault, le Sun 30 Jun 2013 11:50:05 +0200, a écrit : Pino Toscano, le Sat 12 May 2012 00:18:41 +0200, a écrit : The problem is that libdrm is considered an hard requirement (by the buildsystem and the Debian packaging), while it is only if the DRI support is enabled (and indeed

Bug#672546: xserver-xorg-video-openchrome: FTBFS on hurd-i386: unconditional libdrm requirement

2013-06-30 Thread Samuel Thibault
Hello, Pino Toscano, le Sat 12 May 2012 00:18:41 +0200, a écrit : The problem is that libdrm is considered an hard requirement (by the buildsystem and the Debian packaging), while it is only if the DRI support is enabled (and indeed there seems to be only libdrm usage in the DRI-related

Bug#672546: xserver-xorg-video-openchrome: FTBFS on hurd-i386: unconditional libdrm requirement

2012-05-11 Thread Pino Toscano
Package: xserver-xorg-video-openchrome Version: 1:0.2.904+svn1050-1 Severity: important Tags: patch User: debian-h...@lists.debian.org Usertags: hurd Hi, currently, xserver-xorg-video-openchrome does not build on GNU/Hurd. The problem is that libdrm is considered an hard requirement (by the