Bug#673765: dom4j FTBFS with openjdk-7

2012-05-23 Thread Niels Thykier
On 2012-05-21 11:56, James Page wrote: Package: dom4j Version: 1.6.1+dfsg.2-5 Severity: normal Tags: patch User: ubuntu-de...@lists.ubuntu.com Usertags: origin-ubuntu quantal ubuntu-patch openjdk-7-transition Dear Maintainer, In Ubuntu, the attached patch was applied to achieve the

Bug#673765: dom4j FTBFS with openjdk-7

2012-05-23 Thread James Page
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi Niels On 23/05/12 07:27, Niels Thykier wrote: However, I must admit I am a bit concerned in the use of of != with reals (floats/doubles)[0]. To my understanding (in at least C/C++) that is very likely to always be true due to even minor

Bug#673765: dom4j FTBFS with openjdk-7

2012-05-23 Thread Niels Thykier
On 2012-05-23 10:19, James Page wrote: Hi Niels On 23/05/12 07:27, Niels Thykier wrote: However, I must admit I am a bit concerned in the use of of != with reals (floats/doubles)[0]. To my understanding (in at least C/C++) that is very likely to always be true due to even minor rounding

Bug#673765: dom4j FTBFS with openjdk-7

2012-05-23 Thread James Page
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 23/05/12 09:48, Niels Thykier wrote: Revisiting this, couldn't we use Double.compare(double, double) for this? This way we should be safe from changes (if any) in how doubles are handled in the future as well as any changes to the standard

Bug#673765: dom4j FTBFS with openjdk-7

2012-05-21 Thread James Page
Package: dom4j Version: 1.6.1+dfsg.2-5 Severity: normal Tags: patch User: ubuntu-de...@lists.ubuntu.com Usertags: origin-ubuntu quantal ubuntu-patch openjdk-7-transition -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Dear Maintainer, In Ubuntu, the attached patch was applied to achieve the