Bug#689914: does funny things on short cksum output

2013-05-27 Thread Marc Haber
On Fri, May 24, 2013 at 10:14:36AM -0600, Bob Proulx wrote: I assume you discovered this case by inspection of the code rather than in actual practice. This would be a very unlikely case to ever hit in real life. If it did then it would produce one spurious cron email out of years of runs.

Bug#689914: does funny things on short cksum output

2013-05-27 Thread Ola Lundqvist
Hi Marc Good to know, thanks. Yes it is possible that it did a CRC16 check before. That would make sense as extracting the first five characters would have been a bit odd otherwise. Hope the problem is solved now. :-) // Ola On Mon, May 27, 2013 at 09:26:02AM +0200, Marc Haber wrote: On Fri,

Bug#689914: does funny things on short cksum output

2013-05-27 Thread Marc Haber
On Mon, May 27, 2013 at 06:44:16PM +0200, Ola Lundqvist wrote: Hope the problem is solved now. :-) I will open a new bug if it isn't ;-) Thanks for providing a great tool. Greetings Marc -- - Marc Haber | I

Bug#689914: does funny things on short cksum output

2013-05-26 Thread Ola Lundqvist
Ah! I missed that $$ part of the command. You are right, that would have solved it too. Anyway %N is even better so I'll stick to the uploaded variant. // Ola On Fri, May 24, 2013 at 08:48:03PM -0600, Bob Proulx wrote: Hi Ola, Ola Lundqvist wrote: RANDOM=$(dd if=/dev/urandom count=1 2

Bug#689914: does funny things on short cksum output

2013-05-24 Thread Ola Lundqvist
Hi Marc Thanks. Ah, yes I did not think of that case. Will apply. // Ola On Sun, Oct 07, 2012 at 07:08:22PM +0200, Marc Haber wrote: Package: cron-apt Severity: normal Please consider the following patch: --- cron-apt.orig 2012-10-07 19:07:15.772153360 +0200 +++ cron-apt

Bug#689914: does funny things on short cksum output

2013-05-24 Thread Ola Lundqvist
Hi again I'm also adding Bob into this mail chain as he was the one that wrote the code for RANDOM in 2004. When testing this out I noticed the following: ola@quartz:~/svn/fsp/cron-apt$ dd if=/dev/urandom count=1 2 /dev/null | cksum 2815760522 512 ola@quartz:~/svn/fsp/cron-apt$ echo 2815760522

Bug#689914: does funny things on short cksum output

2013-05-24 Thread Bob Proulx
Hi Ola, Marc, Ola Lundqvist wrote: I'm also adding Bob into this mail chain as he was the one that wrote the code for RANDOM in 2004. Actually I had suggested the randomization using $RANDOM in email in May 2003 and after discussion with Ola it settled on using #!/bin/bash to support it. I

Bug#689914: does funny things on short cksum output

2013-05-24 Thread Ola Lundqvist
Hi Bob On Fri, May 24, 2013 at 10:14:36AM -0600, Bob Proulx wrote: Hi Ola, Marc, Ola Lundqvist wrote: I'm also adding Bob into this mail chain as he was the one that wrote the code for RANDOM in 2004. Actually I had suggested the randomization using $RANDOM in email in May 2003 and

Bug#689914: does funny things on short cksum output

2013-05-24 Thread Bob Proulx
Hi Ola, Ola Lundqvist wrote: RANDOM=$(dd if=/dev/urandom count=1 2 /dev/null | cksum | awk '{print$1}') Splitting on whitespace is more resilient to input differences than splitting on each space character. IMNHO using awk for field selection is almost always better than using

Bug#689914: does funny things on short cksum output

2012-10-07 Thread Marc Haber
Package: cron-apt Severity: normal Please consider the following patch: --- cron-apt.orig 2012-10-07 19:07:15.772153360 +0200 +++ cron-apt2012-10-07 19:07:32.748173175 +0200 @@ -299,7 +299,7 @@ if [ $RUNSLEEP -gt 0 ] ; then if [ -z $RANDOM ] ; then # A fix for