Bug#693918: patch

2012-12-19 Thread Niels Thykier 
On 2012-12-12 07:42, Bastien ROUCARIÈS wrote:
 Package: lintian
 Version: 2.5.10.2
 control: retitle -1 [new check] Add check for missing keywords field in 
 .desktop  file
 control: tag -1 + patch
 
 
 Patch here 
 

Hi,

I applied the (last of) your patch(es), but in the commit message I
forgot to mention that I downgrade the severity to wishlist (W - I).

~Niels


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#693918: patch

2012-12-13 Thread Bastien ROUCARIÈS 
Package: lintian
Version: 2.5.10.2
control: retitle -1 [new check] Add check for missing keywords field in 
.desktop  file
control: tag -1 + patch


Patch here 

-- 
Dr-Ing Bastien ROUCARIÈS uUniversité de Cergy/SATIE ENS Cachan
From d4363231a0d1ca72fe4625e578e2e65ed35bc238 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bastien=20ROUCARI=C3=88S?= roucaries.bast...@gmail.com
Date: Wed, 12 Dec 2012 07:35:22 +0100
Subject: [PATCH] Add desktop file with no keywords warning

---
 checks/menu-format  |8 
 checks/menu-format.desc |   11 +++
 2 files changed, 19 insertions(+)

diff --git a/checks/menu-format b/checks/menu-format
index 34de8fa..1ad1743 100644
--- a/checks/menu-format
+++ b/checks/menu-format
@@ -95,6 +95,7 @@ my %known_desktop_keys = map { $_ = 1 }
Comment
Icon
Hidden
+   Keywords
OnlyShowIn
NotShowIn
TryExec
@@ -648,6 +649,13 @@ sub VerifyDesktopFile {
 }
 }
 
+# test if missing Keywords(only if NoDisplay is not set)
+if (!defined $vals{NoDisplay}) {
+if(!defined $vals{Keywords}) {
+tag 'desktop-entry-lacks-Keywords-entry', $file;
+}
+} 
+
 # Only test whether the binary is in the package if the desktop file is
 # directly under /usr/share/applications.  Too many applications use
 # desktop files for other purposes with custom paths.
diff --git a/checks/menu-format.desc b/checks/menu-format.desc
index 1fc567d..e5e5ad0 100644
--- a/checks/menu-format.desc
+++ b/checks/menu-format.desc
@@ -306,6 +306,17 @@ Info: The categories for this desktop entry do not contain any Main
  useful for checking the syntax of desktop entries.
 Ref: http://standards.freedesktop.org/menu-spec/1.0/apa.html
 
+Tag: desktop-entry-lacks-Keywords-entry
+Severity: minor
+Certainty: certain
+Info: The categories for this desktop entry do not contain any 
+ Keywords. Keywords should not be redundant with the values of Name 
+ or GenericName.
+ .
+ The desktop-file-validate tool in the desktop-file-utils package is
+ useful for checking the syntax of desktop entries.
+Ref: http://standards.freedesktop.org/desktop-entry-spec/1.0/apc.html
+
 Tag: desktop-entry-uses-reserved-category
 Severity: normal
 Certainty: certain
-- 
1.7.10.4

Bug#693918: patch

2012-12-12 Thread Bastien ROUCARIES 
control:tag  -1 patch

On Wed, Dec 12, 2012 at 5:24 PM, Bastien ROUCARIES
roucaries.bast...@gmail.com wrote:
 control: -1 patch


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#693918: patch

2012-12-11 Thread Bastien ROUCARIÈS 
Package: lintian
Version: 2.5.10.2
control: retitle -1 [new check] Add check for missing keywords field in 
.desktop  file
control: tag -1 + patch


Patch here 

-- 
Dr-Ing Bastien ROUCARIÈS uUniversité de Cergy/SATIE ENS Cachan
From d4363231a0d1ca72fe4625e578e2e65ed35bc238 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bastien=20ROUCARI=C3=88S?= roucaries.bast...@gmail.com
Date: Wed, 12 Dec 2012 07:35:22 +0100
Subject: [PATCH] Add desktop file with no keywords warning

---
 checks/menu-format  |8 
 checks/menu-format.desc |   11 +++
 2 files changed, 19 insertions(+)

diff --git a/checks/menu-format b/checks/menu-format
index 34de8fa..1ad1743 100644
--- a/checks/menu-format
+++ b/checks/menu-format
@@ -95,6 +95,7 @@ my %known_desktop_keys = map { $_ = 1 }
Comment
Icon
Hidden
+   Keywords
OnlyShowIn
NotShowIn
TryExec
@@ -648,6 +649,13 @@ sub VerifyDesktopFile {
 }
 }
 
+# test if missing Keywords(only if NoDisplay is not set)
+if (!defined $vals{NoDisplay}) {
+if(!defined $vals{Keywords}) {
+tag 'desktop-entry-lacks-Keywords-entry', $file;
+}
+} 
+
 # Only test whether the binary is in the package if the desktop file is
 # directly under /usr/share/applications.  Too many applications use
 # desktop files for other purposes with custom paths.
diff --git a/checks/menu-format.desc b/checks/menu-format.desc
index 1fc567d..e5e5ad0 100644
--- a/checks/menu-format.desc
+++ b/checks/menu-format.desc
@@ -306,6 +306,17 @@ Info: The categories for this desktop entry do not contain any Main
  useful for checking the syntax of desktop entries.
 Ref: http://standards.freedesktop.org/menu-spec/1.0/apa.html
 
+Tag: desktop-entry-lacks-Keywords-entry
+Severity: minor
+Certainty: certain
+Info: The categories for this desktop entry do not contain any 
+ Keywords. Keywords should not be redundant with the values of Name 
+ or GenericName.
+ .
+ The desktop-file-validate tool in the desktop-file-utils package is
+ useful for checking the syntax of desktop entries.
+Ref: http://standards.freedesktop.org/desktop-entry-spec/1.0/apc.html
+
 Tag: desktop-entry-uses-reserved-category
 Severity: normal
 Certainty: certain
-- 
1.7.10.4