Bug#696671: tpu: isc-dhcp/4.2.2.dfsg.1-5+deb70u3
Adam D. Barratt a...@adam-barratt.org.uk (28/02/2013): Unblocked, but needs a d-i ack. AFAICT netcfg is the only consumer on the d-i side, on non-Linux ports only. isc-dhcp-client-udeb doesn't come with dhcp hooks anyway, and a better upgrade handling shouldn't hurt anything in d-i; I don't think there's any objection to unblocking it. Mraw, KiBi. signature.asc Description: Digital signature
Bug#696671: tpu: isc-dhcp/4.2.2.dfsg.1-5+deb70u3
Control: tags -1 + confirmed d-i On Wed, 2013-02-20 at 21:11 -0500, Michael Gilbert wrote: On Sun, Feb 17, 2013 at 8:50 AM, Philipp Kern wrote: On Sat, Feb 16, 2013 at 04:20:45PM -0500, Michael Gilbert wrote: On Sat, Feb 16, 2013 at 4:18 PM, Michael Gilbert wrote: I've attached an updated proposed patch, which also fixes #698582 (and consequentially #700363). File attached. Really attached this time ... thanks. Please go ahead. Uploaded. Unblocked, but needs a d-i ack. Regards, Adam -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#696671: tpu: isc-dhcp/4.2.2.dfsg.1-5+deb70u3
On Sun, Feb 17, 2013 at 8:50 AM, Philipp Kern wrote: On Sat, Feb 16, 2013 at 04:20:45PM -0500, Michael Gilbert wrote: On Sat, Feb 16, 2013 at 4:18 PM, Michael Gilbert wrote: I've attached an updated proposed patch, which also fixes #698582 (and consequentially #700363). File attached. Really attached this time ... thanks. Please go ahead. Uploaded. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#696671: tpu: isc-dhcp/4.2.2.dfsg.1-5+deb70u3
Control: tag -1 confirmed
Hi,
On Sat, Feb 16, 2013 at 04:20:45PM -0500, Michael Gilbert wrote:
On Sat, Feb 16, 2013 at 4:18 PM, Michael Gilbert wrote:
I've attached an updated proposed patch, which also fixes #698582 (and
consequentially #700363).
File attached.
Really attached this time ...
thanks. Please go ahead. One tiny remark, though:
+ if [ -e /etc/dhcp/dhclient.conf ] \
+ [ `md5sum /etc/dhcp/dhclient.conf | awk '{print $1;}'` =
6e3910d75cd5cde0042ecb6d48492ae9 ]; then
+ sed -i -e
's/rfc3442-classless-static-routes;/rfc3442-classless-static-routes,
ntp-servers;/' /etc/dhcp/dhclient.conf
+ fi
Please don't do things with awk that can be realized with cut,
especially in a preinst. But since awk is still pseudo-essential
(pre-depends of base-files) in wheezy, it doesn't make a difference.
Kind regards
Philipp Kern
signature.asc
Description: Digital signature
Bug#696671: tpu: isc-dhcp/4.2.2.dfsg.1-5+deb70u3
On Sat, Jan 19, 2013 at 7:46 AM, Philipp Kern wrote: So -1 will fire up dhclient, try to get a lease for a preset amount of time (i.e. querying multiple times) and then fork for continuously renewing the lease or exit with failure code 2? Actually, the preset amount of time (if you want to call it that) for -1 is instantaneously, and on failure to get a lease it gives up right away, rather than wasting the users' time doing multiple retries. I've attached an updated proposed patch, which also fixes #698582 (and consequentially #700363). Apologies for the delay on getting around to this. Best wishes, Mike -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#696671: tpu: isc-dhcp/4.2.2.dfsg.1-5+deb70u3
On Sat, Feb 16, 2013 at 4:02 PM, Michael Gilbert wrote: On Sat, Jan 19, 2013 at 7:46 AM, Philipp Kern wrote: So -1 will fire up dhclient, try to get a lease for a preset amount of time (i.e. querying multiple times) and then fork for continuously renewing the lease or exit with failure code 2? Actually, the preset amount of time (if you want to call it that) for -1 is instantaneously, and on failure to get a lease it gives up right away, rather than wasting the users' time doing multiple retries. Rereading your question, yes by default it has a 60 second timeout and queries for responses from servers during that time. It will fail will exit code 2 if it that one attempt fails, rather than retrying. Best wishes, Mike -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#696671: tpu: isc-dhcp/4.2.2.dfsg.1-5+deb70u3
On Sat, Feb 16, 2013 at 4:18 PM, Michael Gilbert wrote: I've attached an updated proposed patch, which also fixes #698582 (and consequentially #700363). File attached. Really attached this time ... isc-dhcp.patch Description: Binary data
Bug#696671: tpu: isc-dhcp/4.2.2.dfsg.1-5+deb70u3
On Tue, Dec 25, 2012 at 10:11:22 -0500, Michael Gilbert wrote: Package: release.debian.org User: release.debian@packages.debian.org Usertags: tpu Severity: normal I plan to upload a tpu for isc-dhcp fixing two important issues. One fixes an unclean error situation, and the other sets up the default dhclient configuration to work in ipv6-only configurations. The first change is less important, so I can drop it if needed. Please review the proposed patch attached. There's now 698582 which should probably be addressed in any tpu upload. Cheers, Julien signature.asc Description: Digital signature
Bug#696671: tpu: isc-dhcp/4.2.2.dfsg.1-5+deb70u3
On Tue, Dec 25, 2012 at 11:19:18PM -0500, Michael Gilbert wrote: As seen in #695810 (merged with #486520), ifupdown switched to calling dhclient with the -1 option, and in past releases it had not, so it is now a more prevalent problem. Although sure severity is questionable, and I'm not willing to exert much effort to include it. I'll remove if that's what is wanted. So -1 will fire up dhclient, try to get a lease for a preset amount of time (i.e. querying multiple times) and then fork for continuously renewing the lease or exit with failure code 2? I just want to be sure I understand the logic before ACKing it. (And sorry for the delay on that.) Thanks Philipp Kern signature.asc Description: Digital signature
Bug#696671: tpu: isc-dhcp/4.2.2.dfsg.1-5+deb70u3
Package: release.debian.org User: release.debian@packages.debian.org Usertags: tpu Severity: normal I plan to upload a tpu for isc-dhcp fixing two important issues. One fixes an unclean error situation, and the other sets up the default dhclient configuration to work in ipv6-only configurations. The first change is less important, so I can drop it if needed. Please review the proposed patch attached. Thanks, Mike isc-dhcp.patch Description: Binary data
Bug#696671: tpu: isc-dhcp/4.2.2.dfsg.1-5+deb70u3
On Tue, Dec 25, 2012 at 10:11:22 -0500, Michael Gilbert wrote: Package: release.debian.org User: release.debian@packages.debian.org Usertags: tpu Severity: normal I plan to upload a tpu for isc-dhcp fixing two important issues. One fixes an unclean error situation, and the other sets up the default dhclient configuration to work in ipv6-only configurations. The first change is less important, so I can drop it if needed. Please review the proposed patch attached. Was that first one forwarded/applied upstream? The report's over 4 years old, why is it suddenly important now? Cheers, Julien signature.asc Description: Digital signature
Bug#696671: tpu: isc-dhcp/4.2.2.dfsg.1-5+deb70u3
On Tue, Dec 25, 2012 at 4:01 PM, Julien Cristau wrote: On Tue, Dec 25, 2012 at 10:11:22 -0500, Michael Gilbert wrote: Package: release.debian.org User: release.debian@packages.debian.org Usertags: tpu Severity: normal I plan to upload a tpu for isc-dhcp fixing two important issues. One fixes an unclean error situation, and the other sets up the default dhclient configuration to work in ipv6-only configurations. The first change is less important, so I can drop it if needed. Please review the proposed patch attached. Was that first one forwarded/applied upstream? It was forwarded a long time ago, but it's apparently been ignored. Upstream is quite opaque, so who knows what the deal is. The report's over 4 years old, why is it suddenly important now? As seen in #695810 (merged with #486520), ifupdown switched to calling dhclient with the -1 option, and in past releases it had not, so it is now a more prevalent problem. Although sure severity is questionable, and I'm not willing to exert much effort to include it. I'll remove if that's what is wanted. Best wishes, Mike -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
