Bug#699425: Fetchmail's resolvconf update script can be simplified

2013-01-31 Thread Thomas Hood
Package: fetchmail
Version: 6.3.22-2
Severity: minor

Fetchmail's resolvconf update script
(/etc/resolvconf/update-libc.d/fetchmail) can be simplified.

Resolvconf no longer calls update scripts with --nscd to indicate that
nscd is running and has been restarted. (Resolvconf no longer restarts nscd
when resolv.conf changes.) Consequently, the while...done statement can be
deleted from fetchmail's resolvconf update script as shown in the appended
patch.

Whether or not it is still necessary to awaken fetchmail after a
resolv.conf change, I don't know. Someone who knows fetchmail better than I
do will have to be the judge of that. They just need to be aware that the
glibc resolver has been enhanced such that resolver clients are asked to
re-initialize the resolver when resolv.conf changes. At least for nscd that
means that nscd doesn't have to be restarted after a resolv.conf change (as
it once did have to be).
-- 
Thomas Hood

--- fetchmail_ORIG 2013-01-31 11:11:39.926431750 +0100
+++ fetchmail 2013-01-31 11:11:57.522479569 +0100
@@ -1,12 +1,5 @@
 #!/bin/sh

-while [ $1 ]; do
- if [ $1 = --nscd ]; then
- exit 0
- fi
- shift
-done
-
 if [ -x /etc/init.d/fetchmail ]  [ -n $(pidof fetchmail) ]; then
  /etc/init.d/fetchmail awaken
 fi


Bug#699425: [pkg-fetchmail-maint] Bug#699425: Fetchmail's resolvconf update script can be simplified

2013-01-31 Thread Nico Golde
severity 699425 wishlist
thanks

* Thomas Hood jdth...@gmail.com [2013-01-31 11:25]:
 Package: fetchmail
 Version: 6.3.22-2
 Severity: minor
 
 Fetchmail's resolvconf update script
 (/etc/resolvconf/update-libc.d/fetchmail) can be simplified.

While I appreciate patches in general, I don't see the bug in this case. 
Hence downgrading.

Cheers
Nico
-- 
Nico Golde - http://www.ngolde.de - n...@jabber.ccc.de - GPG: 0xA0A0


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org