Package: libfakechroot
Version: 2.16-1
Severity: minor
Tags: patch

Dear Maintainer,

might the condition to free ptr be inverted ?

If I am wrong, it would help to document briefly
the condition in a comment in the source code.

Thanks in advance for your comments and/or corrections !

Regards,
JH Chatenet 

--- a/src/mktemp.c      2011-12-11 13:05:34.000000000 +0100
+++ b/src/mktemp.c      2013-08-09 15:08:13.000000000 +0200
@@ -31,15 +31,15 @@
 
     debug("mktemp(\"%s\")", template);
     tmp[FAKECHROOT_PATH_MAX-1] = '\0';
     strncpy(tmp, template, FAKECHROOT_PATH_MAX-2);
     ptr = tmp;
 
     if (!fakechroot_localdir(ptr)) {
-        localdir = 1;
+        localdir = 0;
         expand_chroot_path_malloc(ptr, fakechroot_path, fakechroot_buf);
     }
 
     if (nextcall(mktemp)(ptr) == NULL) {
         if (!localdir) free(ptr);
         return NULL;
     }
 


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to