Bug#725772: RFS: nfft -- Library for computing Non-uniform Fast Fourier Transforms
Hi Ghislain, On Thu, Oct 24, 2013 at 05:48:35PM +0100, Ghislain Vaillant wrote: Hi Andreas, I have updated the package following your comments. http://anonscm.debian.org/gitweb/?p=debian-science/packages/nfft.git I'm afraid I have some further remarks: d/control: - Thanks to Scott's explanation I think I understood now the dh-exec mechanism and so I think you can remove dh-exec from the Build-Depends - Priorities: The source package should be Priority: optional and only for the *-dbg package you should explicitly specify Priority: extra. The point is that priority extra packages will be excluded from some QA checks which we do not really want in general but actually debug packages should feature this extra - Neat tip: You might like to check, how config modell using cme fix dpkg-control is formating your control file. I personally like this. d/changelog: You created a new changelog paragraph. For not yet uploaded packages this is at best confusiing even if your *-1 entry claims that it was uploaded to unstable (which it was not - at best this should be UNRELEASED). Also the consequence of this new entry is, that the ITP bug is not closed by an upload if I would upload as is. You can easily verify this effect when looking at the tasks page[1] which is not linking to an according WNPP bug (in contrast to for instance liblevmar-dev). The reason is that only the latest paragraph of d/changelog is parsed. So my advise would be to *not* log your actual changes inside d/changelog until we have *really* the first version inside Debian. There is sufficient information inside the Git commit logs. Just remove the 3.2.3-2 paragraph and it also makes sense to target with 3.2.3-1 at UNRELEASED while leaving me as the sponsor the task to switch this to unstable once I decide to upload. This is (should be??) written in Debian Science policy document and helps other team members to see immediately that a package was not yet uploaded. Regarding the SoB sponsering I told you I have added the *-dev package to the relevant development tasks of Debian Science which can be seen for example in mathematics-dev task[1]. Could you now please add an according entry at the SoB Wiki page[2] to make sure you understood the mechanism I would like to push via SoB. Kind regards Andreas. [1] http://blends.alioth.debian.org/science/tasks/mathematics-dev#libnfft3-dev [2] https://wiki.debian.org/DebianPureBlends/SoB -- http://fam-tille.de -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#725772: RFS: nfft -- Library for computing Non-uniform Fast Fourier Transforms
Hi Andreas, I have updated the package following your comments. http://anonscm.debian.org/gitweb/?p=debian-science/packages/nfft.git Cheers, Ghislain -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#725772: RFS: nfft -- Library for computing Non-uniform Fast Fourier Transforms
On Tue, Oct 22, 2013 at 2:42 AM, Andreas Tille andr...@an3as.eu wrote: d/*.install: The files are starting by a line #!/usr/bin/dh-exec I admit I have never seen this before even if I suspect this might be somewhere in the docs which you have definitely read in a way more recent version than me. The line does not harm but to the best of my knowledge you can safely remove it. I just wanted to point out that line extends dh_install. From the manpage: The purpose of the program is to extend dh_install(1)'s functionality, by allowing to specify a destination filename. This can be accomplished by a special syntax: the = mark between a source and a destination means that the source file should be installed with the specified destination name. Lintian is supposed to pick up on if you are using it superfluously http://lintian.debian.org/tags/dh-exec-script-without-dh-exec-features.html -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#725772: RFS: nfft -- Library for computing Non-uniform Fast Fourier Transforms
Hi Ghislain, On Mon, Oct 21, 2013 at 02:54:50PM +0100, Ghislain Vaillant wrote: Just a short update on this RFS, Following your advice, I have moved the package over to debian-science and followed the debian-science policy. It now hosted on http://anonscm.debian.org/gitweb/?p=debian-science/packages/nfft.git Thanks. In turn (and because I think you are not a member of Debian Blends team) I added the -dev package to mathematics-dev, physics-dev and engineering-dev: http://anonscm.debian.org/viewvc/blends?view=revisionrevision=3887 Please tell me whether you regard this as sensible (or please ask if you have no idea what I'm talking about). When doing so I realised that physics-dev is very badly / not really maintained. Any volunteer to check the package pool for packages that are helpful for developing applications for physicists? I have removed the version uploaded on mentors.debian.org for now to avoid duplication. If you want me to sponsor this as SoB[1] package I personally do not require an upload to mentors.d.o because I use the repository anyway. When looking at the package I have the following hints: d/copyright: The header is not a valid DEP5 header. You can easily check the file by using cme fix dpkg-copyright d/*.install: The files are starting by a line #!/usr/bin/dh-exec I admit I have never seen this before even if I suspect this might be somewhere in the docs which you have definitely read in a way more recent version than me. The line does not harm but to the best of my knowledge you can safely remove it. d/watch: Pure nitpicking: The file contains some boilerplate comments like # Uncomment to examine a Webserver directory You actually *have* uncommented the line - I'd recommend droping useless comments. Regarding building he package: When using git-buildpackage it comes very handy if the pristine-tar information is inside the repository. I think this is even written down in Debian Science policy (did not checked; if it is not it should be - it is in several other team policies). Please use git import-orig --pristine-tar orig.tar.gz to import the original tarball information to get a byte identical orig tarball without downloading again from scratch. Kind regards Andreas. [1] http://wiki.debian.org/DebianPureBlends/SoB -- http://fam-tille.de -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#725772: RFS: nfft -- Library for computing Non-uniform Fast Fourier Transforms
On Tue, 2013-10-22 at 08:42 +0200, Andreas Tille wrote: Hi Ghislain, On Mon, Oct 21, 2013 at 02:54:50PM +0100, Ghislain Vaillant wrote: Just a short update on this RFS, Following your advice, I have moved the package over to debian-science and followed the debian-science policy. It now hosted on http://anonscm.debian.org/gitweb/?p=debian-science/packages/nfft.git Thanks. In turn (and because I think you are not a member of Debian Blends team) I added the -dev package to mathematics-dev, physics-dev and engineering-dev: http://anonscm.debian.org/viewvc/blends?view=revisionrevision=3887 Please tell me whether you regard this as sensible (or please ask if you have no idea what I'm talking about). When doing so I realised that physics-dev is very badly / not really maintained. Any volunteer to check the package pool for packages that are helpful for developing applications for physicists? I believe nfft should be part of the same groups as fftw. I have removed the version uploaded on mentors.debian.org for now to avoid duplication. If you want me to sponsor this as SoB[1] package I personally do not require an upload to mentors.d.o because I use the repository anyway. Good, I'll leave it like this then. When looking at the package I have the following hints: d/copyright: The header is not a valid DEP5 header. You can easily check the file by using cme fix dpkg-copyright Thanks for the tip. d/*.install: The files are starting by a line #!/usr/bin/dh-exec I admit I have never seen this before even if I suspect this might be somewhere in the docs which you have definitely read in a way more recent version than me. The line does not harm but to the best of my knowledge you can safely remove it. I probably took it blindly from somewhere else. Good to know for the future. d/watch: Pure nitpicking: The file contains some boilerplate comments like # Uncomment to examine a Webserver directory You actually *have* uncommented the line - I'd recommend droping useless comments. I am happy with nitpicking. That's how I'll learn. Regarding building he package: When using git-buildpackage it comes very handy if the pristine-tar information is inside the repository. I think this is even written down in Debian Science policy (did not checked; if it is not it should be - it is in several other team policies). Please use git import-orig --pristine-tar orig.tar.gz to import the original tarball information to get a byte identical orig tarball without downloading again from scratch. I'll have a look at pristine-tar. Kind regards Andreas. [1] http://wiki.debian.org/DebianPureBlends/SoB -- http://fam-tille.de I'll make an update of the package addressing your comments. Thanks for your time. Ghislain -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
