tags 741848 + pending
thanks

Dear maintainer,

I've prepared an NMU for gst-plugins-ugly0.10 (versioned as 0.10.19-2.1)
and uploaded it to unstable. I hope you don't mind me avoiding the
DELAYED queue, but the patch has been sitting in the BTS over a week
now, and this package is currently blocking the libx264-142 transition:

https://release.debian.org/transitions/html/libx264-142.html

Regarding the patch itself, the BTS contains two patches that workaround
the same issue: AC_CHECK_A52DEC always returns
"HAVE_A52DEC=no". Matthias identified the reason why this recently
broke: In a52dec_0.7.4-17, I have made the struct a52_state_t visible
again, because the handbrake package currently makes use of that
struct. Given the lack of development on the a52dec front, I asserted
that this wouldn't break existing packages, but it seems that m4/a52.m4
of this package explicitly checks for the availabity of this struct, and
asserts that a52dec was "too old" if this type is present. Ideally the
test should be rewritten, but for the purposes of Debian/Ubuntu,
disabling the check as done by Hideki seems just fine to me.

Regards,
Reinhard
diff -Nru gst-plugins-ugly0.10-0.10.19/debian/changelog gst-plugins-ugly0.10-0.10.19/debian/changelog
--- gst-plugins-ugly0.10-0.10.19/debian/changelog	2012-04-23 02:53:01.000000000 -0400
+++ gst-plugins-ugly0.10-0.10.19/debian/changelog	2014-04-07 20:26:02.000000000 -0400
@@ -1,3 +1,11 @@
+gst-plugins-ugly0.10 (0.10.19-2.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * debian/patches
+    - add a52dec.patch to enable a52dec module and closes: #741848
+
+ -- Hideki Yamane <henr...@debian.org>  Mon, 24 Mar 2014 23:56:56 +0900
+
 gst-plugins-ugly0.10 (0.10.19-2) unstable; urgency=low
 
   * debian/patches/01_opencore-amr-0.1.3.patch:
diff -Nru gst-plugins-ugly0.10-0.10.19/debian/patches/a52dec.patch gst-plugins-ugly0.10-0.10.19/debian/patches/a52dec.patch
--- gst-plugins-ugly0.10-0.10.19/debian/patches/a52dec.patch	1969-12-31 19:00:00.000000000 -0500
+++ gst-plugins-ugly0.10-0.10.19/debian/patches/a52dec.patch	2014-04-07 20:25:26.000000000 -0400
@@ -0,0 +1,23 @@
+Description: enable A52DEC module generation
+
+ AC_CHECK_A52DEC always returns "HAVE_A52DEC=no" so module would not
+ be generated. This patch changes to do it.
+
+Author: Hideki Yamane <henr...@debian.org>
+Bug-Debian: http://bugs.debian.org/741848
+Forwarded: no
+Last-Update: 2014-03-26
+
+Index: gst-plugins-ugly0.10-0.10.19/configure.ac
+===================================================================
+--- gst-plugins-ugly0.10-0.10.19.orig/configure.ac
++++ gst-plugins-ugly0.10-0.10.19/configure.ac
+@@ -242,7 +242,7 @@ echo
+ dnl *** a52dec ***
+ translit(dnm, m, l) AM_CONDITIONAL(USE_A52DEC, true)
+ AG_GST_CHECK_FEATURE(A52DEC, [a52dec], a52dec, [
+-  AC_CHECK_A52DEC(HAVE_A52DEC=yes, HAVE_A52DEC=no)
++  AC_CHECK_A52DEC(,HAVE_A52DEC="yes")
+ ])
+ 
+ dnl *** amr-nb ***
diff -Nru gst-plugins-ugly0.10-0.10.19/debian/patches/series gst-plugins-ugly0.10-0.10.19/debian/patches/series
--- gst-plugins-ugly0.10-0.10.19/debian/patches/series	2012-04-23 02:52:15.000000000 -0400
+++ gst-plugins-ugly0.10-0.10.19/debian/patches/series	2014-04-07 20:22:13.000000000 -0400
@@ -1,2 +1,3 @@
 01_opencore-amr-0.1.3.patch
 99_ltmain_as-needed.patch
+a52dec.patch

Reply via email to