Bug#746411: linux-image-3.2.0-4-amd64: regression: suspend/resume not working after update
Ben Hutchings b...@decadent.org.uk writes: Thanks a lot. This should be reverted in the next security update. (Yes, even though it is not a security issue.) looking forward for the update, thanks! greetings, jens PS: i could imagine the revert will break stuff for other machines and likely a fixed version of e07518e9ce84547ef7a81478dbd3fed1539726da will be needed? if i can be of help by testing a possible new version, feel free to contact me pgpW3luRnq7Vs.pgp Description: PGP signature
Bug#746411: linux-image-3.2.0-4-amd64: regression: suspend/resume not working after update
On Thu, 2014-05-08 at 20:52 +0200, Jens Thiele wrote: if i revert the commit: commit e07518e9ce84547ef7a81478dbd3fed1539726da Author: Robert Richter r...@kernel.org Date: Wed Jan 15 15:57:29 2014 +0100 perf/x86/amd/ibs: Fix waking up from S3 for AMD family 10h suspend/resume works for me again $ git branch -v * linux-3.2.y f453538 Linux 3.2.58 $ git diff-tree -R -p e07518e9ce84547ef7a81478dbd3fed1539726da (patch attached) Thanks a lot. This should be reverted in the next security update. (Yes, even though it is not a security issue.) Ben. -- Ben Hutchings Sturgeon's Law: Ninety percent of everything is crap. signature.asc Description: This is a digitally signed message part
Bug#746411: linux-image-3.2.0-4-amd64: regression: suspend/resume not working after update
Jens Thiele ka...@karme.de writes: Ben Hutchings b...@decadent.org.uk writes: How is it 'not working'? didn't have time to inspect the details yet did some more tests - it doesn't matter wether i am on power or battery - I have a reproducible crash on every second resume (first resume works / second crashes without any output :( ) - tried to debug using netconsole, but unfortunately i don't get any netconsole output on the second resume - unfortunately i didn't find a linux-image-3.2.0-4-amd64_3.2.54-2.deb anymore, but using linux-image-3.2.0-4-amd64_3.2.46-1+deb7u1_amd64.deb from debian security suspend/resume works jens pgp9SY59QRFT9.pgp Description: PGP signature
Bug#746411: linux-image-3.2.0-4-amd64: regression: suspend/resume not working after update
if i revert the commit:
commit e07518e9ce84547ef7a81478dbd3fed1539726da
Author: Robert Richter r...@kernel.org
Date: Wed Jan 15 15:57:29 2014 +0100
perf/x86/amd/ibs: Fix waking up from S3 for AMD family 10h
suspend/resume works for me again
$ git branch -v
* linux-3.2.y f453538 Linux 3.2.58
$ git diff-tree -R -p e07518e9ce84547ef7a81478dbd3fed1539726da
(patch attached)
diff --git a/arch/x86/kernel/cpu/perf_event_amd_ibs.c b/arch/x86/kernel/cpu/perf_event_amd_ibs.c
index ea34253..3b8a2d3 100644
--- a/arch/x86/kernel/cpu/perf_event_amd_ibs.c
+++ b/arch/x86/kernel/cpu/perf_event_amd_ibs.c
@@ -9,7 +9,6 @@
#include linux/perf_event.h
#include linux/module.h
#include linux/pci.h
-#include linux/syscore_ops.h
#include asm/apic.h
@@ -210,18 +209,6 @@ out:
return ret;
}
-static void ibs_eilvt_setup(void)
-{
- /*
- * Force LVT offset assignment for family 10h: The offsets are
- * not assigned by the BIOS for this family, so the OS is
- * responsible for doing it. If the OS assignment fails, fall
- * back to BIOS settings and try to setup this.
- */
- if (boot_cpu_data.x86 == 0x10)
- force_ibs_eilvt_setup();
-}
-
static inline int get_ibs_lvt_offset(void)
{
u64 val;
@@ -257,36 +244,6 @@ static void clear_APIC_ibs(void *dummy)
setup_APIC_eilvt(offset, 0, APIC_EILVT_MSG_FIX, 1);
}
-#ifdef CONFIG_PM
-
-static int perf_ibs_suspend(void)
-{
- clear_APIC_ibs(NULL);
- return 0;
-}
-
-static void perf_ibs_resume(void)
-{
- ibs_eilvt_setup();
- setup_APIC_ibs(NULL);
-}
-
-static struct syscore_ops perf_ibs_syscore_ops = {
- .resume = perf_ibs_resume,
- .suspend = perf_ibs_suspend,
-};
-
-static void perf_ibs_pm_init(void)
-{
- register_syscore_ops(perf_ibs_syscore_ops);
-}
-
-#else
-
-static inline void perf_ibs_pm_init(void) { }
-
-#endif
-
static int __cpuinit
perf_ibs_cpu_notifier(struct notifier_block *self, unsigned long action, void *hcpu)
{
@@ -313,12 +270,18 @@ static __init int amd_ibs_init(void)
if (!caps)
return -ENODEV; /* ibs not supported by the cpu */
- ibs_eilvt_setup();
+ /*
+ * Force LVT offset assignment for family 10h: The offsets are
+ * not assigned by the BIOS for this family, so the OS is
+ * responsible for doing it. If the OS assignment fails, fall
+ * back to BIOS settings and try to setup this.
+ */
+ if (boot_cpu_data.x86 == 0x10)
+ force_ibs_eilvt_setup();
if (!ibs_eilvt_valid())
goto out;
- perf_ibs_pm_init();
get_online_cpus();
ibs_caps = caps;
/* make ibs_caps visible to other cpus: */
pgpcyb0IuDlLg.pgp
Description: PGP signature
Bug#746411: linux-image-3.2.0-4-amd64: regression: suspend/resume not working after update
Ben Hutchings b...@decadent.org.uk writes: How is it 'not working'? didn't have time to inspect the details yet - Crash/hang when trying to suspend? suspend itself seems to work - Immediate resume after suspending? no - Unresponsive when trying to resume? - Crash/hang after resuming? looks like a complete crash on resume nothing in the logs have to power down to get the device working again jens pgp3ZccnL_u2X.pgp Description: PGP signature
Bug#746411: linux-image-3.2.0-4-amd64: regression: suspend/resume not working after update
can't reproduce at the moment :( maybe this bug report is invalid/can be closed -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#746411: linux-image-3.2.0-4-amd64: regression: suspend/resume not working after update
Jens Thiele ka...@karme.de writes: can't reproduce at the moment :( maybe this bug report is invalid/can be closed now it happened again looks like it only happens on suspend to ram on battery device is a thinkpad edge 11 (amd version) ** Model information sys_vendor: LENOVO product_name: 2545A26 product_version: ThinkPad Edge chassis_vendor: LENOVO chassis_version: Not Available bios_vendor: LENOVO bios_version: 87ET44WW (1.18 ) board_vendor: LENOVO board_name: 2545A26 board_version: Not Available -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#746411: linux-image-3.2.0-4-amd64: regression: suspend/resume not working after update
Control: tag -1 moreinfo On Tue, 2014-04-29 at 20:58 +0200, Jens Thiele wrote: Package: src:linux Version: 3.2.57-3 Severity: normal suspend/resume not working after update from 3.2.54-2 to 3.2.57-3 maybe this is caused by the change: - perf/x86/amd/ibs: Fix waking up from S3 for AMD family 10h introduced in 3.2.57-1 cpu family: 16 model : 6 model name: AMD Athlon(tm) II Neo K345 Dual-Core Processor How is it 'not working'? - Crash/hang when trying to suspend? - Immediate resume after suspending? - Unresponsive when trying to resume? - Crash/hang after resuming? Ben. -- Ben Hutchings Life would be so much easier if we could look at the source code. signature.asc Description: This is a digitally signed message part
Bug#746411: linux-image-3.2.0-4-amd64: regression: suspend/resume not working after update
Package: src:linux Version: 3.2.57-3 Severity: normal suspend/resume not working after update from 3.2.54-2 to 3.2.57-3 maybe this is caused by the change: - perf/x86/amd/ibs: Fix waking up from S3 for AMD family 10h introduced in 3.2.57-1 cpu family : 16 model : 6 model name : AMD Athlon(tm) II Neo K345 Dual-Core Processor -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
