Bug#746477: /usr/bin/conky: conky terminates after several minutes with you don't need that many fonts message
Hi,
I have created a pull request on github.
Regards
Damian
Am 01.05.2014 06:42, schrieb Vincent Cheng:
On Wed, Apr 30, 2014 at 4:12 AM, Me m...@arcsin.de wrote:
Package: conky-std
Version: 1.9.0-2
Severity: normal
File: /usr/bin/conky
Dear Maintainer,
conky terminates reproducibly after several minutes on my system logging the
following:
Conky: desktop window (183) is subwindow of root window (d3)
Conky: window type - desktop
Conky: drawing to created window (0x2e2)
Conky: drawing to double buffer
Conky: you don't need that many fonts, sorry.
In between, conky works as expected. The following patch helps:
--- conky-1.9.0.orig/src/specials.c
+++ conky-1.9.0/src/specials.c
@@ -330,6 +330,15 @@ void new_gauge(struct text_object *obj,
}
#ifdef X11
+int find_font(char *name)
+{
+int i;
+for (i = 0; i font_count; i++)
+if (strncmp(name, fonts[i].name, DEFAULT_TEXT_BUFFER_SIZE)
== EQUAL)
+return i;
+return 0;
+}
+
void new_font(char *buf, char *args)
{
if ((output_methods TO_X) == 0)
@@ -337,6 +346,13 @@ void new_font(char *buf, char *args)
if (args) {
struct special_t *s = new_special(buf, FONT);
+ int index;
+
+if (index = find_font(args))
+{
+s-font_added = index;
+return;
+}
if (s-font_added font_count || !s-font_added ||
(strncmp(args, fonts[s-font_added].name, DEFAULT_TEXT_BUFFER_SIZE) !=
EQUAL) ) {
int tmp = selected_font;
Can you forward the patch upstream [1]? Thanks!
Regards,
Vincent
[1] https://github.com/brndnmtthws/conky
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#746477: /usr/bin/conky: conky terminates after several minutes with you don't need that many fonts message
Package: conky-std
Version: 1.9.0-2
Severity: normal
File: /usr/bin/conky
Dear Maintainer,
conky terminates reproducibly after several minutes on my system logging the
following:
Conky: desktop window (183) is subwindow of root window (d3)
Conky: window type - desktop
Conky: drawing to created window (0x2e2)
Conky: drawing to double buffer
Conky: you don't need that many fonts, sorry.
In between, conky works as expected. The following patch helps:
--- conky-1.9.0.orig/src/specials.c
+++ conky-1.9.0/src/specials.c
@@ -330,6 +330,15 @@ void new_gauge(struct text_object *obj,
}
#ifdef X11
+int find_font(char *name)
+{
+int i;
+for (i = 0; i font_count; i++)
+if (strncmp(name, fonts[i].name, DEFAULT_TEXT_BUFFER_SIZE) ==
EQUAL)
+return i;
+return 0;
+}
+
void new_font(char *buf, char *args)
{
if ((output_methods TO_X) == 0)
@@ -337,6 +346,13 @@ void new_font(char *buf, char *args)
if (args) {
struct special_t *s = new_special(buf, FONT);
+ int index;
+
+if (index = find_font(args))
+{
+s-font_added = index;
+return;
+}
if (s-font_added font_count || !s-font_added || (strncmp(args,
fonts[s-font_added].name, DEFAULT_TEXT_BUFFER_SIZE) != EQUAL) ) {
int tmp = selected_font;
-- System Information:
Debian Release: 7.4
APT prefers stable-updates
APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)
Kernel: Linux 3.13-0.bpo.1-amd64 (SMP w/4 CPU cores)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/dash
Versions of packages conky-std depends on:
ii libaudclient2 3.2.4-1
ii libc6 2.13-38+deb7u1
ii libcairo2 1.12.2-3
ii libcurl3-gnutls 7.26.0-1+wheezy9
ii libdbus-glib-1-2 0.100.2-1
ii libglib2.0-0 2.33.12+really2.32.4-5
ii libimlib2 1.4.5-1
ii libiw30 30~pre9-8
ii liblua5.1-0 5.1.5-4
ii libncurses5 5.9-10
ii libtinfo5 5.9-10
ii libx11-6 2:1.5.0-1+deb7u1
ii libxdamage1 1:1.1.3-2
ii libxext6 2:1.3.1-2+deb7u1
ii libxfixes31:5.0-4+deb7u1
ii libxft2 2.3.1-1
ii libxml2 2.8.0+dfsg1-7+nmu3
ii libxmmsclient60.8+dfsg-4
conky-std recommends no packages.
Versions of packages conky-std suggests:
pn apcupsdnone
pn audacious none
pn mocnone
pn mpdnone
pn xmms2 none
-- no debconf information
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#746477: /usr/bin/conky: conky terminates after several minutes with you don't need that many fonts message
On Wed, Apr 30, 2014 at 4:12 AM, Me m...@arcsin.de wrote:
Package: conky-std
Version: 1.9.0-2
Severity: normal
File: /usr/bin/conky
Dear Maintainer,
conky terminates reproducibly after several minutes on my system logging the
following:
Conky: desktop window (183) is subwindow of root window (d3)
Conky: window type - desktop
Conky: drawing to created window (0x2e2)
Conky: drawing to double buffer
Conky: you don't need that many fonts, sorry.
In between, conky works as expected. The following patch helps:
--- conky-1.9.0.orig/src/specials.c
+++ conky-1.9.0/src/specials.c
@@ -330,6 +330,15 @@ void new_gauge(struct text_object *obj,
}
#ifdef X11
+int find_font(char *name)
+{
+int i;
+for (i = 0; i font_count; i++)
+if (strncmp(name, fonts[i].name, DEFAULT_TEXT_BUFFER_SIZE)
== EQUAL)
+return i;
+return 0;
+}
+
void new_font(char *buf, char *args)
{
if ((output_methods TO_X) == 0)
@@ -337,6 +346,13 @@ void new_font(char *buf, char *args)
if (args) {
struct special_t *s = new_special(buf, FONT);
+ int index;
+
+if (index = find_font(args))
+{
+s-font_added = index;
+return;
+}
if (s-font_added font_count || !s-font_added ||
(strncmp(args, fonts[s-font_added].name, DEFAULT_TEXT_BUFFER_SIZE) !=
EQUAL) ) {
int tmp = selected_font;
Can you forward the patch upstream [1]? Thanks!
Regards,
Vincent
[1] https://github.com/brndnmtthws/conky
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
