Bug#749929: RFS: aircrack-ng/1:1.2-0~beta3-1
On Mon, 2014-06-02 at 19:38 +0200, Carlos Alberto Lopez Perez wrote: ieee-data installs the file in the 4th place My mistake, I didn't see that it installs a symlink there. As commented on my previous reply, the package don't installs airoscript-ng. Yeah, that was mainly for forwarding upstream. In general I agree with you, but this release is IMHO an improvement over the previous 1.1 series and is as stable as the older one. Fair enough. Because is completely broken and only manages to confuse users. Please check: http://trac.aircrack-ng.org/ticket/1317 I see, thanks for the pointer. I tried to do it, but it was such a mess that I decided to go back. ... I will gladly accept patches if you are interested in any of this tools. I see, makes sense. The changelog says that it is a C# library to parse Airodump-ng output files. Probably not useful then. This patches are the ones that airdriver-ng used. 99% of this patches not longer apply or make any sense. See the ticket http://trac.aircrack-ng.org/ticket/1317 I think this patches should be removed from the upstream repository. Makes sense, would be nice if the Kali patch got upstreamed. I've pinged one of the Kali/Debian devs about it on #debian-derivatives. http://trac.aircrack-ng.org/ticket/1436 Thanks. -- bye, pabs http://wiki.debian.org/PaulWise signature.asc Description: This is a digitally signed message part
Bug#749929: RFS: aircrack-ng/1:1.2-0~beta3-1
On 01/06/14 03:47, Paul Wise wrote: On Sat, May 31, 2014 at 1:37 AM, Carlos Alberto Lopez Perez wrote: dget -x http://mentors.debian.net/debian/pool/main/a/aircrack-ng/aircrack-ng_1.2-0~beta3-1.dsc Some comments below. Other comments via private mail. Upstream website SSL is broken because it doesn't send CA certs along with it, they need to use SSLCertificateChainFile. Also cacert.org isn't trusted by many browsers or CA cert stores so it probably isn't the best choice. https://httpd.apache.org/docs/2.2/mod/mod_ssl.html#sslcertificatechainfile I will forward your comments regarding the SSL certificate of aircrack-ng.org to Thomas. I would suggest using experimental instead of unstable for betas. In general I agree with you, but this release is IMHO an improvement over the previous 1.1 series and is as stable as the older one. I think that Thomas should have called it release candidate instead of beta. Most probably, the final 1.2 version would be very similar to this one. Also I wouldn't want it to miss the next stable release of Debian. Previous 1.1 version don't has proper support for libnl, which causes some problems on modern kernels. Why remove airdriver-ng? Because is completely broken and only manages to confuse users. Please check: http://trac.aircrack-ng.org/ticket/1317 Please use dh --parallel to enable parallel building. Ok. Will add it. Override_dh_auto_install doesn't need to override the normal make install, just use dh_auto_install Ok. I think you want uversionmangle instead of dversionmangle: https://wiki.debian.org/debian/watch#Common_mistakes Would check it. Upstream might want to replace evalrev with running autorevision: http://packages.debian.org/autorevision Is there any technical advantage of doing that? Please, feel free to open a ticket on http://trac.aircrack-ng.org What about enabling ext_scripts? I tried to do it, but it was such a mess that I decided to go back. * airdrop-ng: depends on pylorcon which is not available on Debian. * versuck-ng: is just a password generator from 2009 for Verizon wireless routers with 64bit WEP Keys. I doubt any user out there is still using this. * airgraph-ng and airoscript-ng: both failed on the install phase. I wasn't able to get them working after a make install. I will gladly accept patches if you are interested in any of this tools. Are any of the C# things buildable with Mono or useful on Debian? I have no idea, never tried to build that. The changelog says that it is a C# library to parse Airodump-ng output files. If you know where this can be useful for Debian let me know it. Otherwise I prefer to skip adding a dependency on Mono. Is upstream working on getting the many patches merged into Linux mainline? Either way it would be great if they had DEP-3 style patch headers or similar. This patches are the ones that airdriver-ng used. 99% of this patches not longer apply or make any sense. See the ticket http://trac.aircrack-ng.org/ticket/1317 I think this patches should be removed from the upstream repository. airoscript overrides TMPDIR but it should use the user-provided one and doesn't clean up properly if TMPDIR is not /tmp/. It would be good if the airoscript logo files were generated at build time so they can never get out of sync with the source .xcf/.svg files. The package don't installs airoscript (see my previous comments about ext_scripts) I tried to do it, but the install phase is broken (at least for me). Right now I don't have time to fix this, I tried to do it, but it was not a quick fix so I decided to let that for another moment. If you are interested in airoscript-ng I will accept patches to enable it on the Debian package. Please ask upstream to remove the two prebuilt gettext .mo files from SVN/tarballs, they should be created at build time http://trac.aircrack-ng.org/ticket/1436 signature.asc Description: OpenPGP digital signature
Bug#749929: RFS: aircrack-ng/1:1.2-0~beta3-1
On 01/06/14 04:24, Paul Wise wrote: On Sun, Jun 1, 2014 at 9:47 AM, Paul Wise wrote: Some comments below. More: Some bits of airoscript-ng use /usr/local unconditionally. As commented on my previous reply, the package don't installs airoscript-ng. GCC warnings: tkiptun-ng.c: In function 'main': tkiptun-ng.c:4195:11: warning: ignoring return value of 'setuid', declared with attribute warn_unused_result [-Wunused-result] setuid( getuid() ); ^ airbase-ng.c:73:19: warning: 'gcry_thread_cbs' is deprecated (declared at /usr/include/gcrypt.h:213) [-Wdeprecated-declarations] GCRY_THREAD_OPTION_PTHREAD_IMPL; ^ airbase-ng.c: In function 'main': airbase-ng.c:4566:11: warning: ignoring return value of 'setuid', declared with attribute warn_unused_result [-Wunused-result] setuid( getuid() ); ^ airodump-ng.c:77:16: warning: 'gcry_thread_cbs' is deprecated (declared at /usr/include/gcrypt.h:213) [-Wdeprecated-declarations] GCRY_THREAD_OPTION_PTHREAD_IMPL; ^ aircrack-ng.c:84:16: warning: 'gcry_thread_cbs' is deprecated (declared at /usr/include/gcrypt.h:213) [-Wdeprecated-declarations] GCRY_THREAD_OPTION_PTHREAD_IMPL; ^ The gcry* warnings appeared after that I enabled building with libgcrypt20 by default. Building with libgcrypt11 don't causes this warnings. I guess I will have to fix that at some moment. I will look at the setuid warnings. lintian: I: aircrack-ng source: debian-watch-file-should-uversionmangle-not-dversionmangle line 3 P: aircrack-ng source: debian-watch-may-check-gpg-signature I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man1/ivstools.1.gz:7 I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man1/ivstools.1.gz:9 I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man1/ivstools.1.gz:15 I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man1/ivstools.1.gz:17 I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man8/airbase-ng.8.gz:40 I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man8/airbase-ng.8.gz:46 I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man8/airbase-ng.8.gz:47 I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man8/airbase-ng.8.gz:50 I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man8/airbase-ng.8.gz:53 I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man8/airbase-ng.8.gz:55 I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man8/airbase-ng.8.gz:60 I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man8/airbase-ng.8.gz:78 I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man8/airbase-ng.8.gz:81 I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man8/airbase-ng.8.gz:85 I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man8/airbase-ng.8.gz 7 more occurrences not shown I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man8/airodump-ng.8.gz:45 I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man8/airodump-ng.8.gz:64 I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man8/airodump-ng.8.gz:69 I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man8/airodump-ng.8.gz:166 I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man8/besside-ng.8.gz:39 I already know about this, but I consider the hyphen-used-as-minus-sign warnings pretty low priority. signature.asc Description: OpenPGP digital signature
Bug#749929: RFS: aircrack-ng/1:1.2-0~beta3-1
On 01/06/14 04:39, Paul Wise wrote: On Sun, Jun 1, 2014 at 10:24 AM, Paul Wise wrote: On Sun, Jun 1, 2014 at 9:47 AM, Paul Wise wrote: Some comments below. More: One more - the ieee-data package places the oui files in a different location to where aircrack-ng looks for them. Yes, I know. airodump-ng looks for the oui file at this 4 places: /etc/aircrack-ng/airodump-ng-oui.txt /usr/local/etc/aircrack-ng/airodump-ng-oui.txt /usr/share/aircrack-ng/airodump-ng-oui.txt /usr/share/misc/oui.txt ieee-data installs the file in the 4th place signature.asc Description: OpenPGP digital signature
Bug#749929: RFS: aircrack-ng/1:1.2-0~beta3-1
On Sat, May 31, 2014 at 1:37 AM, Carlos Alberto Lopez Perez wrote: dget -x http://mentors.debian.net/debian/pool/main/a/aircrack-ng/aircrack-ng_1.2-0~beta3-1.dsc Some comments below. Other comments via private mail. Upstream website SSL is broken because it doesn't send CA certs along with it, they need to use SSLCertificateChainFile. Also cacert.org isn't trusted by many browsers or CA cert stores so it probably isn't the best choice. https://httpd.apache.org/docs/2.2/mod/mod_ssl.html#sslcertificatechainfile I would suggest using experimental instead of unstable for betas. Why remove airdriver-ng? Please use dh --parallel to enable parallel building. Override_dh_auto_install doesn't need to override the normal make install, just use dh_auto_install I think you want uversionmangle instead of dversionmangle: https://wiki.debian.org/debian/watch#Common_mistakes Upstream might want to replace evalrev with running autorevision: http://packages.debian.org/autorevision What about enabling ext_scripts? Are any of the C# things buildable with Mono or useful on Debian? Is upstream working on getting the many patches merged into Linux mainline? Either way it would be great if they had DEP-3 style patch headers or similar. airoscript overrides TMPDIR but it should use the user-provided one and doesn't clean up properly if TMPDIR is not /tmp/. It would be good if the airoscript logo files were generated at build time so they can never get out of sync with the source .xcf/.svg files. Please ask upstream to remove the two prebuilt gettext .mo files from SVN/tarballs, they should be created at build time -- bye, pabs http://wiki.debian.org/PaulWise -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#749929: RFS: aircrack-ng/1:1.2-0~beta3-1
On Sun, Jun 1, 2014 at 9:47 AM, Paul Wise wrote: Some comments below. More: Some bits of airoscript-ng use /usr/local unconditionally. GCC warnings: tkiptun-ng.c: In function 'main': tkiptun-ng.c:4195:11: warning: ignoring return value of 'setuid', declared with attribute warn_unused_result [-Wunused-result] setuid( getuid() ); ^ airbase-ng.c:73:19: warning: 'gcry_thread_cbs' is deprecated (declared at /usr/include/gcrypt.h:213) [-Wdeprecated-declarations] GCRY_THREAD_OPTION_PTHREAD_IMPL; ^ airbase-ng.c: In function 'main': airbase-ng.c:4566:11: warning: ignoring return value of 'setuid', declared with attribute warn_unused_result [-Wunused-result] setuid( getuid() ); ^ airodump-ng.c:77:16: warning: 'gcry_thread_cbs' is deprecated (declared at /usr/include/gcrypt.h:213) [-Wdeprecated-declarations] GCRY_THREAD_OPTION_PTHREAD_IMPL; ^ aircrack-ng.c:84:16: warning: 'gcry_thread_cbs' is deprecated (declared at /usr/include/gcrypt.h:213) [-Wdeprecated-declarations] GCRY_THREAD_OPTION_PTHREAD_IMPL; ^ lintian: I: aircrack-ng source: debian-watch-file-should-uversionmangle-not-dversionmangle line 3 P: aircrack-ng source: debian-watch-may-check-gpg-signature I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man1/ivstools.1.gz:7 I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man1/ivstools.1.gz:9 I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man1/ivstools.1.gz:15 I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man1/ivstools.1.gz:17 I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man8/airbase-ng.8.gz:40 I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man8/airbase-ng.8.gz:46 I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man8/airbase-ng.8.gz:47 I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man8/airbase-ng.8.gz:50 I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man8/airbase-ng.8.gz:53 I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man8/airbase-ng.8.gz:55 I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man8/airbase-ng.8.gz:60 I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man8/airbase-ng.8.gz:78 I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man8/airbase-ng.8.gz:81 I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man8/airbase-ng.8.gz:85 I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man8/airbase-ng.8.gz 7 more occurrences not shown I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man8/airodump-ng.8.gz:45 I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man8/airodump-ng.8.gz:64 I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man8/airodump-ng.8.gz:69 I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man8/airodump-ng.8.gz:166 I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man8/besside-ng.8.gz:39 -- bye, pabs http://wiki.debian.org/PaulWise -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#749929: RFS: aircrack-ng/1:1.2-0~beta3-1
On Sun, Jun 1, 2014 at 10:24 AM, Paul Wise wrote: On Sun, Jun 1, 2014 at 9:47 AM, Paul Wise wrote: Some comments below. More: One more - the ieee-data package places the oui files in a different location to where aircrack-ng looks for them. -- bye, pabs http://wiki.debian.org/PaulWise -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#749929: RFS: aircrack-ng/1:1.2-0~beta3-1
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package aircrack-ng * Package name: aircrack-ng Version : 1:1.2-0~beta3-1 Upstream Author : Thomas d'Otreppe tdotre...@aircrack-ng.org * URL : http://www.aircrack-ng.org * License : GPL-2 Section : net It builds those binary packages: aircrack-ng - wireless WEP/WPA cracking utilities To access further information about this package, please visit the following URL: http://mentors.debian.net/package/aircrack-ng Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/a/aircrack-ng/aircrack-ng_1.2-0~beta3-1.dsc Changes since the last upload: * New upstream release. * Remove all Debian patchess that are now merged upstream. * Apply: wrap-and-sort -sa * Build with PCRE: Add support for regular expression matching for ESSID in airodump-ng. * Build with libgcrypt20 by default, but allow to use libgcrypt11 otherwise. * Fix libnl detection (Debian patches 002-fix-libnl-detection.diff and 003-dont-abort-libnl-nolinux.diff). * Add build dependency on libnl-genl-3-dev. * Remove airdriver-ng (LP: #499513) (Closes: #449299). * Not longer recommend wget, because we don't ship airdriver-ng neither airoump-ng-oui-update. * Recommend the Debian package ieee-data that contains the OUI data. Add Debian patch 001-Airodump_whitespace_oui.diff to correctly parse it. Not longer ship airodump-ng-oui-update (Use update-oui instead). (Closes: #739199) * Switch to debhelper 9 and enable all hardening flags (PIE works now). * Update debian/watch and debian/copyright. * Upgrade to new standars version. Regards! signature.asc Description: OpenPGP digital signature
Bug#749929: RFS: aircrack-ng/1:1.2-0~beta3-1
On 30/05/14 19:37, Carlos Alberto Lopez Perez wrote: [...] * Remove all Debian patchess that are now merged upstream. ^ patches [...] * Upgrade to new standars version. ^ standards I just fixed now this two typos on the changelog and uploaded to mentors again. signature.asc Description: OpenPGP digital signature