Bug#753273: FTBFS with clang instead of gcc

[Chris Knadle]

On Monday, June 30, 2014 02:19:51 Alexander wrote:
 Source: mumble
 Severity: minor
 Tags: patch
 User: pkg-llvm-t...@lists.alioth.debian.org
 Usertags: clang-ftbfs
 
 Hello,
 
 Using the rebuild infrastructure, your package fails to build with clang
 (instead of gcc).
 
 We detected this kinf of error:
 http://clang.debian.net/status.php?version=3.4.2key=DEFAULT_CONSTRUCTOR
 
 Full build log is available here:
 http://clang.debian.net/logs/2014-06-16/mumble_1.2.6-1_unstable_clang.log
 
 Thanks,
 Alexander

Greetings, Alexander.

Thanks very much for reporting this bug and including a patch.  I've had a 
good look at the patch and verified that all of these changes are required to 
get Mumble to compile with clang.

I built Mumble with clang via cowbuilder, using these instructions:

   
http://henrich-on-debian.blogspot.com/2013/03/use-clang-with-pbuildercowbuilder.html?_escaped_fragment_=#!

... it seemed to require 'export CHOOSE_COMPILER=clang' though.



Concerning the patch: of the 4 changes, 2 have been implemented upstream, and 
I'll report the other 2 concerning making enums SampleFormat and eSampleFormat 
public.

I've implemented the patch to fix this, which will close the bug with the 
upload of 1.2.7.

Thanks much!

  -- Chris

--

Chris Knadle
chris.kna...@coredump.us

signature.asc
Description: This is a digitally signed message part.

Bug#753273: FTBFS with clang instead of gcc

[Alexander]

Source: mumble
Severity: minor
Tags: patch
User: pkg-llvm-t...@lists.alioth.debian.org
Usertags: clang-ftbfs

Hello,

Using the rebuild infrastructure, your package fails to build with clang 
(instead of gcc).

We detected this kinf of error:
http://clang.debian.net/status.php?version=3.4.2key=DEFAULT_CONSTRUCTOR

Full build log is available here:
http://clang.debian.net/logs/2014-06-16/mumble_1.2.6-1_unstable_clang.log

Thanks,
Alexander

-- System Information:
Debian Release: jessie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
--- mumble-1.2.6/src/mumble/VoiceRecorderDialog.cpp	2014-05-14 22:01:46.0 +0400
+++ mumble-1.2.6-my/src/mumble/VoiceRecorderDialog.cpp	2014-06-30 02:05:44.626266741 +0400
@@ -38,7 +38,7 @@
 #include ServerHandler.h
 #include VoiceRecorder.h
 
-VoiceRecorderDialog::VoiceRecorderDialog(QWidget *p = NULL) : QDialog(p), qtTimer(new QTimer(this)) {
+VoiceRecorderDialog::VoiceRecorderDialog(QWidget *p) : QDialog(p), qtTimer(new QTimer(this)) {
 	qtTimer-setObjectName(QLatin1String(qtTimer));
 	qtTimer-setInterval(200);
 	setupUi(this);
--- mumble-1.2.6/src/mumble/VoiceRecorderDialog.h	2014-05-14 22:01:46.0 +0400
+++ mumble-1.2.6-my/src/mumble/VoiceRecorderDialog.h	2014-06-30 02:16:02.295191873 +0400
@@ -43,7 +43,7 @@
 
 		QTimer *qtTimer;
 	public:
-		explicit VoiceRecorderDialog(QWidget *p);
+		explicit VoiceRecorderDialog(QWidget *p = NULL);
 		~VoiceRecorderDialog();
 
 		void closeEvent(QCloseEvent *evt);
--- mumble-1.2.6/src/mumble/AudioInput.h	2014-05-14 22:01:46.0 +0400
+++ mumble-1.2.6-my/src/mumble/AudioInput.h	2014-06-30 02:09:52.885761475 +0400
@@ -79,9 +79,10 @@
 	private:
 		Q_OBJECT
 		Q_DISABLE_COPY(AudioInput)
+public:
+		typedef enum { SampleShort, SampleFloat } SampleFormat;
 	protected:
 		typedef enum { CodecCELT, CodecSpeex } CodecFormat;
-		typedef enum { SampleShort, SampleFloat } SampleFormat;
 		typedef void (*inMixerFunc)(float * RESTRICT, const void * RESTRICT, unsigned int, unsigned int);
 	private:
 		SpeexResamplerState *srsMic, *srsEcho;
--- mumble-1.2.6/src/mumble/AudioOutput.h	2014-05-14 22:01:46.0 +0400
+++ mumble-1.2.6-my/src/mumble/AudioOutput.h	2014-06-30 02:11:25.456076966 +0400
@@ -102,8 +102,9 @@
 		float *fSpeakers;
 		float *fSpeakerVolume;
 		bool *bSpeakerPositional;
-	protected:
+public:
 		enum { SampleShort, SampleFloat } eSampleFormat;
+	protected:
 		volatile bool bRunning;
 		unsigned int iFrameSize;
 		volatile unsigned int iMixerFreq;