Package: jbigkit
Version: 2.0-2
Severity: normal
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu utopic ubuntu-patch

Hi Michael,

While investigating packages in Ubuntu that do not have automatic ddebs
generated for them, I found that jbigkit was stripping binaries at install
time.  This makes the package incompatible with DEB_BUILD_OPTIONS=nostrip,
defined in Policy 4.9.1, and is also incompatible with generating debug
symbols packages, which is something I believe Debian will eventually want
to implement as well.

Since the use of 'install -s' is introduced by a Debian-specific patch, I've
modified debian/patches/allNewMainMakefile.diff directly to drop this use of
the -s flag.

I've uploaded this change to the Ubuntu archive; please consider applying it
in Debian as well.

Thanks,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slanga...@ubuntu.com                                     vor...@debian.org
=== modified file 'debian/patches/allNewMainMakefile.diff'
--- debian/patches/allNewMainMakefile.diff	2012-04-08 19:12:41 +0000
+++ debian/patches/allNewMainMakefile.diff	2014-07-10 06:14:59 +0000
@@ -5,8 +5,10 @@
 Upstream Makefile is barebones, and doesn't make any shared libraries.
 
 With some extra effort, this does.
---- a/Makefile
-+++ b/Makefile
+Index: trunk/Makefile
+===================================================================
+--- trunk.orig/Makefile
++++ trunk/Makefile
 @@ -11,9 +11,9 @@
  CFLAGS = $(CCFLAGS) -I../libjbig
  
@@ -30,13 +32,13 @@
 -	scp CHANGES slogin-serv1.cl.cam.ac.uk:public_html/jbigkit/
 +install: all
 +	install -d $(DESTDIR)/usr/lib/$(DEB_HOST_MULTIARCH)
-+	install -s -m 644 libjbig/.libs/*.so.*.*.* libjbig/.libs/*.a $(DESTDIR)/usr/lib/$(DEB_HOST_MULTIARCH)
++	install -m 644 libjbig/.libs/*.so.*.*.* libjbig/.libs/*.a $(DESTDIR)/usr/lib/$(DEB_HOST_MULTIARCH)
 +	install -m 644 libjbig/.libs/*.la $(DESTDIR)/usr/lib/$(DEB_HOST_MULTIARCH)
 +	/sbin/ldconfig -n $(DESTDIR)/usr/lib/$(DEB_HOST_MULTIARCH)
 +	ln -s libjbig.so.0.0.0 $(DESTDIR)/usr/lib/$(DEB_HOST_MULTIARCH)/libjbig.so
 +	install -d $(DESTDIR)/usr/include
 +	install -m 644 libjbig/*.h $(DESTDIR)/usr/include
 +	install -d $(DESTDIR)/usr/bin
-+	install -s -m 755 pbmtools/jbgtopbm pbmtools/jbgtopbm85 pbmtools/pbmtojbg pbmtools/pbmtojbg85 $(DESTDIR)/usr/bin
++	install -m 755 pbmtools/jbgtopbm pbmtools/jbgtopbm85 pbmtools/pbmtojbg pbmtools/pbmtojbg85 $(DESTDIR)/usr/bin
 +	install -d $(DESTDIR)/usr/share/man/man1
 +	install -m 644 pbmtools/*.1 $(DESTDIR)/usr/share/man/man1

Reply via email to