Bug#758857: buildbot: Unable to upgrade master
David, Thank you for your report and your interest in Debian. It seems the code in buildbot/scripts/upgrade_master.py really exits upgrade process if there's a problem with buildbot.tac file. This means the message should be an ERROR and the text should be more descriptive telling you what to change and retry upgrade. As it is noted in upstream bug #2588 you mentioned [1], there's no simple way to automatically fix buildbot.tac file during upgrade. So this task will be left on the user to be handled manually. I'll add more information in /usr/share/doc/buildbot/NEWS.Debian As for other files you mentioned (public_html/*.new), these are created every time you run upgrade-master command. You may remove *.new suffix to apply them to your setup of remove these files at all. Upgrade process when files are overwritten if they weren't changed by user is currently not implemented. Please contact upstream developers to fix this. New master.cfg.sample config file is also an example of configuration file created after every upgrade-master command. Buildbot upstream has a great deal of supporting old configuration values for some time before deprecating. Release notes for 0.8.9 show this [2]: * slavePortnum option deprecated, please use c['protocols']['pb']['port'] to set up PB port This option is deprecated but not removed so you still can use it in this release (but keep in mind to fix it for later upgrades). So that was not exact issue you spotted when master didn't start. Moreover, I have multiple buildbot masters running at hand that have slavePortnum option. I wonder what your problem really was. At last, permission and owner checks before running upgrade would be good but seems to me not mandatory. You could run upgrade-master command from another user just using su or sudo. This is generally a good assumption that administrator checks permissions beforehand. Thank you again. [1]: http://trac.buildbot.net/ticket/2588 [2]: http://docs.buildbot.net/0.8.9/relnotes/index.html#deprecations-removals-and-non-compatible-changes -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#758857: buildbot: Unable to upgrade master
On Sat, Sep 06, 2014 at 11:01:29AM +0300, Andrii Senkovych wrote:
Closing the by by agreement with the reporter. The bug cannot be
reproduced on several buildbot instances on the maintainer's machine
and the end user's problem has been resolved.
I had the same problem unfortunately and I think this is a really bad
upgrade experience, so in case someone else finds this bugreport in
a what the hell, why isn't that working… moment (or maybe it even
helps the maintainer reproducing it, who knows):
Funnily simply deleting the state.sqlite file didn't change anything,
I just got a new empty state.sqlite file (with the wrong owner 'root'
as all the other files are owned by the 'buildbot' user – maybe the
message should indicate how to run the upgrade command as another user
than root), but the message remained the same. What helped was in fact
correcting what the upgrade-master command complained about in the
warning (as in the initial mail): WARNING: rotateLength is a string, it
should be a number
I can't remember ever touching the buildbot.tac file at all, but well,
I had these values in the file:
rotateLength = '1000'
maxRotatedFiles = '10'
[possibly upstream bug #2588 ; my instance was setup in January 2014]
After removing the quotes from both (after fixing rotateLength you get
the same warning about maxRotateFiles) I could run the upgrade-master
command and it finished successfully. These should really be errors
instead of warnings if they make the command fail completely…
Trying to start buildmaster again made it die without any message in the
logs though, but the upgrade command had created a new master.cfg.sample
file and comparing this with my file indicated that the way the port has
to be set changed – notice that I haven't changed the port at all…
anyway, changing the old line to:
c['protocols'] = {'pb': {'port': 9989}}
made the buildmaster start again with all of its old state.
Sidenote: In public_html/ there are also some *.new files for me,
namely for robots.txt and default.css – I doubt I had changed them
either, so at least default.css would have been nice if it was upgraded
automatically (I see why robots.txt wasn't) [even better if it would be
handled like the template files as I have no intension of changing the
CSS], but at least a friendly message that I should do that would be
good.
Best regards
David Kalnischkies
signature.asc
Description: Digital signature
Bug#758857: buildbot: Unable to upgrade master
Your command didn't work: $ echo -n .headers on \n select * from migrate_version;|sqlite3 state.sqlite Usage: .headers on|off But doing it manually: $ sqlite3 state.sqlite sqlite .headers on sqlite select * from migrate_version; repository_id|repository_path|version Buildbot|/usr/lib/python2.7/dist-packages/buildbot/db/migrate|22 $ls -al rwxr-xr-x 1 USER USER 228 sie 27 14:24 . drwxr-xr-x. 1 USER USER 718 wrz 1 07:29 .. -rw-r--r-- 1 USER USER 1,1K maj 14 11:37 buildbot.tac drwx-- 1 USER USER 118 maj 15 08:34 gitpoller-workdir -rw--- 1 USER USER 888K sie 18 08:16 http.log -rw-r--r-- 1 USER USER 5,7K cze 3 12:34 master.cfg -rw--- 1 USER USER 4,4K maj 14 11:37 master.cfg.sample drwxr-xr-x 1 USER USER 94 maj 14 11:37 public_html drwx-- 1 USER USER 491K sie 18 08:24 runtests -rw-r--r-- 1 USER USER 136M sie 18 08:14 state.sqlite drwxr-xr-x 1 USER USER 20 maj 14 11:37 templates -rw-r--r-- 1 USER USER 65M sie 27 14:24 twistd.log If it's hard to reproduce then we can close this bug as incident because i'm can to drop all my history and start with fresh one. I submitted this bug not to restore builds history but to find a problem :) On Wed, 27 Aug 2014 18:38:49 +0300 Andriy Senkovych jolly_ro...@itblog.org.ua wrote: Package: buildbot Followup-For: Bug #758857 Hello fri.K, Thank you for your feedback, but I'm not able to reproduce the bug you mentioned. I have tried to upgrade several different master instances and got upgraded with no problem. Please specify more information on your setup. What is the contents of migrate_version table. To get this info, run following: echo -n .headers on \n select * from migrate_version;|sqlite3 state.sqlite Example output: repository_id|repository_path|version Buildbot|/usr/lib/python2.7/dist-packages/buildbot/db/migrate|24 -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#758857: buildbot: Unable to upgrade master
Package: buildbot Followup-For: Bug #758857 Hello fri.K, Thank you for your feedback, but I'm not able to reproduce the bug you mentioned. I have tried to upgrade several different master instances and got upgraded with no problem. Please specify more information on your setup. What is the contents of migrate_version table. To get this info, run following: echo -n .headers on \n select * from migrate_version;|sqlite3 state.sqlite Example output: repository_id|repository_path|version Buildbot|/usr/lib/python2.7/dist-packages/buildbot/db/migrate|24 -- System Information: Debian Release: jessie/sid APT prefers unstable APT policy: (990, 'unstable'), (500, 'testing'), (500, 'stable') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 3.2.0-2-amd64 (SMP w/2 CPU cores) Locale: LANG=uk_UA.UTF-8, LC_CTYPE=uk_UA.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages buildbot depends on: ii adduser 3.113+nmu3 ii dpkg 1.17.13 ii libjs-sphinxdoc 1.2.2+dfsg-3 ii python2.7.8-1 ii python-dateutil 1.5+dfsg-1 ii python-jinja2 2.7.3-1 ii python-migrate0.9.1-1 ii python-sqlalchemy 0.9.7-1 ii python-twisted14.0.0-2 ii python-twisted-core 14.0.0-2 ii python-twisted-web14.0.0-2 ii python-twisted-words 14.0.0-2 Versions of packages buildbot recommends: ii buildbot-slave 0.8.6p1-1 ii libaprutil1 1.5.3-3 ii python-twisted-mail 14.0.0-2 Versions of packages buildbot suggests: ii cvs 2:1.12.13+real-14 ii darcs 2.8.4-3+b4 ii git 1:2.1.0-1 ii mercurial 3.1-1 ii subversion 1.8.10-1+b1 -- no debconf information -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#758857: buildbot: Unable to upgrade master
Package: buildbot Version: 0.8.9-1 Severity: grave Justification: renders package unusable Dear Maintainer, I'm unable to use buildbot after update, doing: $ buildbot --verbose upgrade-master buildBot-master returns: 014-08-22 08:30:48+0200 [-] Log opened. 2014-08-22 08:30:48+0200 [-] /usr/lib/python2.7/dist-packages/twisted/internet/endpoints.py:30: exceptions.DeprecationWarning: twisted.internet.interfaces.IStreamClientEndpointStringParser was deprecated in Twisted 14.0.0: This interface has been superseded by IStreamClientEndpointStringParserWithReactor. 2014-08-22 08:30:48+0200 [-] /usr/lib/python2.7/dist-packages/twisted/spread/jelly.py:93: exceptions.DeprecationWarning: the sets module is deprecated 2014-08-22 08:30:48+0200 [-] checking basedir 2014-08-22 08:30:48+0200 [-] checking for running master 2014-08-22 08:30:48+0200 [-] WARNING: rotateLength is a string, it should be a number 2014-08-22 08:30:48+0200 [-] Main loop terminated. and exits with 1 If I try to start master, then it says: $ buildbot start buildBot-master Following twistd.log until startup finished.. 2014-08-22 08:56:33+0200 [-] Log opened. 2014-08-22 08:56:33+0200 [-] twistd 14.0.0 (/usr/bin/python 2.7.8) starting up. 2014-08-22 08:56:33+0200 [-] reactor class: twisted.internet.epollreactor.EPollReactor. 2014-08-22 08:56:33+0200 [-] Starting BuildMaster -- buildbot.version: 0.8.9 2014-08-22 08:56:33+0200 [-] Loading configuration from '/home/lkepa/buildBot-master/master.cfg' 2014-08-22 08:56:34+0200 [-] Setting up database with URL 'sqlite:///state.sqlite' 2014-08-22 08:56:34+0200 [-] setting database journal mode to 'wal' 2014-08-22 08:56:34+0200 [-] The Buildmaster database needs to be upgraded before this version of 2014-08-22 08:56:34+0200 [-] buildbot can run. Use the following command-line 2014-08-22 08:56:34+0200 [-] 2014-08-22 08:56:34+0200 [-] buildbot upgrade-master path/to/master 2014-08-22 08:56:34+0200 [-] 2014-08-22 08:56:34+0200 [-] to upgrade the database, and try starting the buildmaster again. You may 2014-08-22 08:56:34+0200 [-] want to make a backup of your buildmaster before doing so. 2014-08-22 08:56:34+0200 [-] Main loop terminated. 2014-08-22 08:56:34+0200 [-] Server Shut Down. -- System Information: Debian Release: jessie/sid APT prefers testing-updates APT policy: (500, 'testing-updates'), (500, 'testing') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 3.14-1-amd64 (SMP w/2 CPU cores) Locale: LANG=pl_PL.UTF-8, LC_CTYPE=pl_PL.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages buildbot depends on: ii adduser 3.113+nmu3 ii dpkg 1.17.10 ii libjs-sphinxdoc 1.2.2+dfsg-2 ii python2.7.8-1 ii python-dateutil 1.5+dfsg-1 ii python-jinja2 2.7.3-1 ii python-migrate0.9.1-1 ii python-sqlalchemy 0.9.7-1 ii python-twisted14.0.0-2 ii python-twisted-core 14.0.0-2 ii python-twisted-web14.0.0-2 ii python-twisted-words 14.0.0-2 Versions of packages buildbot recommends: ii buildbot-slave 0.8.9-1 ii libaprutil1 1.5.3-2 ii python-twisted-mail 14.0.0-2 Versions of packages buildbot suggests: ii git 1:2.1.0~rc1-1 ii subversion 1.8.9-2 -- no debconf information -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
