Bug#759769: aptitude: Installed Size diff reported wrong for packages larger 2GiB if installed

2015-06-29 Thread Manuel A. Fernandez Montecelo 
Control: tags -1 + pending


Commited, thanks for the report and the patch.

http://anonscm.debian.org/cgit/aptitude/aptitude.git/commit/?id=32478647260bba9aff4969cc5265b2d78fca2727

-- 
Manuel A. Fernandez Montecelo manuel.montez...@gmail.com


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#759769: aptitude: Installed Size diff reported wrong for packages larger 2GiB if installed

2014-09-25 Thread Sven Joachim 
Control: tags -1 +patch

On 2014-09-11 21:38 +0200, Jason Rhinelander wrote:

 On Sat, 30 Aug 2014 07:52:54 +0200 Benny Baumann be...@geshi.org wrote:
 To reproduce have a look at the linux-image-*-dbg packages that require
 more than 2GiB on amd64 after installation. When installing such a package
 aptitude will report something like pi linux-image-*-dbg   -1,900M ...
 while the correct display would report +2300M instead.

 Likewise uninstalling such a package will report something along the lines
 of id linux-image-*-dbg   +1,900M where -2,300M would be correct.

 Just to clarify the above, it's only the disk usage on the individual
 package line that is incorrect: the overall total near the top of the
 interface (Will use xxx MB of disk space) is correct.

Also the output on the commandline with the -Z option is affected.

 libreoffice-dbg is another such package (showing -870MB when selected
 for installation instead of the correct +3,425MB).

The following patch fixes both occurrences by changing the type of the
offending variable (InstalledSize is declared as unsigned long long in
/usr/include/apt-pkg/pkgcache.h):

--8---cut here---start-8---
diff --git a/src/cmdline/cmdline_prompt.cc b/src/cmdline/cmdline_prompt.cc
index 292acf6..1c0442c 100644
--- a/src/cmdline/cmdline_prompt.cc
+++ b/src/cmdline/cmdline_prompt.cc
@@ -352,7 +352,7 @@ static void cmdline_show_instinfo(pkgvector items,
   // Show the change in size between the versions.
   if(showsize)
{
- int dsize=(instver.end()?0:instver-InstalledSize)
+ long long dsize=(instver.end()?0:instver-InstalledSize)
-(i-CurrentVer().end()?0:i-CurrentVer()-InstalledSize);
 
  if(dsize0)
diff --git a/src/pkg_columnizer.cc b/src/pkg_columnizer.cc
index 7642775..f85733a 100644
--- a/src/pkg_columnizer.cc
+++ b/src/pkg_columnizer.cc
@@ -161,7 +161,7 @@ cw::column_disposition 
pkg_item::pkg_columnizer::setup_column(const pkgCache::Pk
  pkgCache::VerIterator 
inst_ver=(*apt_cache_file)[pkg].InstVerIter(*apt_cache_file);
 
  // TODO: move this to a generic file (common with cmdline.cc)
- int dsize=(inst_ver.end()?0:inst_ver-InstalledSize)
+ long long dsize=(inst_ver.end()?0:inst_ver-InstalledSize)
-(pkg.CurrentVer().end()?0:pkg.CurrentVer()-InstalledSize);
 
  if(dsize==0)
--8---cut here---end---8---

Cheers,
   Sven


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#759769: aptitude: Installed Size diff reported wrong for packages larger 2GiB if installed

2014-09-11 Thread Jason Rhinelander 

On Sat, 30 Aug 2014 07:52:54 +0200 Benny Baumann be...@geshi.org wrote:

To reproduce have a look at the linux-image-*-dbg packages that require
more than 2GiB on amd64 after installation. When installing such a package
aptitude will report something like pi linux-image-*-dbg   -1,900M ...
while the correct display would report +2300M instead.

Likewise uninstalling such a package will report something along the lines
of id linux-image-*-dbg   +1,900M where -2,300M would be correct.


Just to clarify the above, it's only the disk usage on the individual 
package line that is incorrect: the overall total near the top of the 
interface (Will use xxx MB of disk space) is correct.


libreoffice-dbg is another such package (showing -870MB when selected 
for installation instead of the correct +3,425MB).




Jason Rhinelander



smime.p7s
Description: S/MIME Cryptographic Signature

Bug#759769: aptitude: Installed Size diff reported wrong for packages larger 2GiB if installed

2014-08-29 Thread Benny Baumann 
Package: aptitude
Version: 0.6.11-1
Severity: minor
Tags: lfs

When installing a package that will require more than two GiB on disk
if installed this change of required disk space is reported incorrectly.

To reproduce have a look at the linux-image-*-dbg packages that require
more than 2GiB on amd64 after installation. When installing such a package
aptitude will report something like pi linux-image-*-dbg   -1,900M ...
while the correct display would report +2300M instead.

Likewise uninstalling such a package will report something along the lines
of id linux-image-*-dbg   +1,900M where -2,300M would be correct.

Kind regards,
BenBE.

-- Package-specific info:
Terminal: screen
$DISPLAY not set.
which aptitude: /usr/bin/aptitude

aptitude version information:
aptitude 0.6.11 compiled at Jun  9 2014 20:46:57
Compiler: g++ 4.8.3
Compiled against:
  apt version 4.12.0
  NCurses version 5.9
  libsigc++ version: 2.2.11
  Gtk+ support disabled.
  Qt support disabled.

Current library versions:
  NCurses version: ncurses 5.9.20140712
  cwidget version: 0.5.17
  Apt version: 4.12.0

aptitude linkage:
linux-vdso.so.1 (0x7fff0e3f3000)
libapt-pkg.so.4.12 = /usr/lib/x86_64-linux-gnu/libapt-pkg.so.4.12 
(0x7f125795a000)
libncursesw.so.5 = /lib/x86_64-linux-gnu/libncursesw.so.5 
(0x7f1257724000)
libtinfo.so.5 = /lib/x86_64-linux-gnu/libtinfo.so.5 
(0x7f12574f9000)
libsigc-2.0.so.0 = /usr/lib/x86_64-linux-gnu/libsigc-2.0.so.0 
(0x7f12572f4000)
libcwidget.so.3 = /usr/lib/x86_64-linux-gnu/libcwidget.so.3 
(0x7f1256fed000)
libsqlite3.so.0 = /usr/lib/x86_64-linux-gnu/libsqlite3.so.0 
(0x7f1256d2b000)
libboost_iostreams.so.1.55.0 = 
/usr/lib/x86_64-linux-gnu/libboost_iostreams.so.1.55.0 (0x7f1256b13000)
libxapian.so.22 = /usr/lib/libxapian.so.22 (0x7f1256708000)
libpthread.so.0 = /lib/x86_64-linux-gnu/libpthread.so.0 
(0x7f12564ea000)
libstdc++.so.6 = /usr/lib/x86_64-linux-gnu/libstdc++.so.6 
(0x7f12561df000)
libm.so.6 = /lib/x86_64-linux-gnu/libm.so.6 (0x7f1255ede000)
libgcc_s.so.1 = /lib/x86_64-linux-gnu/libgcc_s.so.1 
(0x7f1255cc7000)
libc.so.6 = /lib/x86_64-linux-gnu/libc.so.6 (0x7f125591e000)
libutil.so.1 = /lib/x86_64-linux-gnu/libutil.so.1 (0x7f125571b000)
libdl.so.2 = /lib/x86_64-linux-gnu/libdl.so.2 (0x7f1255516000)
libz.so.1 = /lib/x86_64-linux-gnu/libz.so.1 (0x7f12552fe000)
libbz2.so.1.0 = /lib/x86_64-linux-gnu/libbz2.so.1.0 
(0x7f12550ee000)
liblzma.so.5 = /lib/x86_64-linux-gnu/liblzma.so.5 (0x7f1254eca000)
librt.so.1 = /lib/x86_64-linux-gnu/librt.so.1 (0x7f1254cc2000)
libuuid.so.1 = /lib/x86_64-linux-gnu/libuuid.so.1 (0x7f1254abc000)
/lib64/ld-linux-x86-64.so.2 (0x7f12582f)

-- System Information:
Debian Release: jessie/sid
  APT prefers testing
  APT policy: (900, 'testing'), (800, 'stable'), (750, 'experimental'), (700, 
'unstable'), (500, 'oldstable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.16-trunk-amd64 (SMP w/8 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages aptitude depends on:
ii  aptitude-common   0.6.11-1
ii  libapt-pkg4.121.0.6
ii  libboost-iostreams1.55.0  1.55.0+dfsg-2
ii  libc6 2.19-9
ii  libcwidget3   0.5.17-1
ii  libgcc1   1:4.9.1-4
ii  libncursesw5  5.9+20140712-2
ii  libsigc++-2.0-0c2a2.2.11-4
ii  libsqlite3-0  3.8.5-2
ii  libstdc++64.9.1-4
ii  libtinfo5 5.9+20140712-2
ii  libxapian22   1.2.18-1

Versions of packages aptitude recommends:
pn  aptitude-doc-en | aptitude-doc  none
ii  libparse-debianchangelog-perl   1.2.0-1
ii  sensible-utils  0.0.9

Versions of packages aptitude suggests:
pn  apt-xapian-index  none
ii  debtags   1.12.1
ii  tasksel   3.20

-- debconf-show failed


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org