Bug#760945: fixed in smokeping 2.6.11-4

2017-11-30 Thread Sven Hartge 
On 30.11.2017 22:24, Antoine Beaupré wrote:
> On 2017-11-30 21:54:57, Sven Hartge wrote:

>> You need to change the code in postinst to
>>
>>chown smokeping:www-data /etc/smokeping/smokeping_secrets
> 
> can you cook me a patch for that?

No problem, see attachment.

Grüße,
Sven.
From 9ebc28f37e74723e3f4a867bec8c8e3d4c8fa269 Mon Sep 17 00:00:00 2001
From: Sven Hartge 
Date: Thu, 30 Nov 2017 22:26:23 +0100
Subject: [PATCH] Change group of secrets file for slaves to www-data
Cc: s...@svenhartge.de

Signed-off-by: Sven Hartge 
---
 debian/postinst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/postinst b/debian/postinst
index 16c379b..e15c8ea 100644
--- a/debian/postinst
+++ b/debian/postinst
@@ -31,7 +31,7 @@ setup_permissions() {
 chown www-data /var/cache/smokeping/images
 chown smokeping:www-data /var/lib/smokeping/__cgi
 chmod 2775 /var/lib/smokeping/__cgi
-chown smokeping:smokeping /etc/smokeping/smokeping_secrets
+chown smokeping:www-data /etc/smokeping/smokeping_secrets
 chmod 640 /etc/smokeping/smokeping_secrets
 }
 
-- 
2.15.0



signature.asc
Description: OpenPGP digital signature

Bug#760945: fixed in smokeping 2.6.11-4

2017-11-30 Thread Antoine Beaupré 
On 2017-11-30 21:54:57, Sven Hartge wrote:
> reopen 760945
> thanks
>
> On 30.11.2017 19:20, Antoine Beaupré wrote:
>
>>* fix slave permissions configuration - thanks Sven Hartge (Closes: 
>> #760945)
>
> Unfortunately this is still not closed. You fixed the "dyndir" issue,
> but the smokeping_secrets file still has the wrong permissions after
> installation/upgrade.
>
> You need to change the code in postinst to
>
>chown smokeping:www-data /etc/smokeping/smokeping_secrets

can you cook me a patch for that?

the code is in collab-maint too, i'd be happy to welcome
co-maintainers...

see also: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=824712

a.

-- 
We tend to overestimate the effect of a technology in the short run and
underestimate the effect in the long run.
- Roy Amara

Bug#760945: fixed in smokeping 2.6.11-4

2017-11-30 Thread Sven Hartge 
reopen 760945
thanks

On 30.11.2017 19:20, Antoine Beaupré wrote:

>* fix slave permissions configuration - thanks Sven Hartge (Closes: 
> #760945)

Unfortunately this is still not closed. You fixed the "dyndir" issue,
but the smokeping_secrets file still has the wrong permissions after
installation/upgrade.

You need to change the code in postinst to

   chown smokeping:www-data /etc/smokeping/smokeping_secrets

to fully fix the problem.

Grüße,
Sven.



signature.asc
Description: OpenPGP digital signature