Package: network-manager
Version: 0.9.10.0-3
Severity: normal
Tags: patch

Dear Maintainer,

NetworkManager.service is not restarted by systemd if NetworkManager
crashed or is killed.

To repeat:

 * boot Debian into Xfce or similar gui with Network Manager Applet
 * kill NetworkManager, as root 'killall -9 NetworkManager'
 * notice how Network Manager Applet just says 'Network Manager is not
   running...'

Workaround is to restart NetworkManager:

 * as root, 'systemctl start NetworkManager.service'

Attached patch fixes this and NetworkManager.service is restarted.
With the patch the service is correctly restarted, and systemd seems to
detect if the service is respawning too fast due to other bugs,
like when NetorkManager is crashing after 'brctl addif br0 eth0' (separate
bug).

-- System Information:
Debian Release: 8.0
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'unstable'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.17.6+ (SMP w/8 CPU cores; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages network-manager depends on:
ii  adduser                3.113+nmu3
ii  dbus                   1.8.12-1
ii  init-system-helpers    1.22
ii  isc-dhcp-client        4.3.1-5
ii  libc6                  2.19-13
ii  libdbus-1-3            1.8.12-1
ii  libdbus-glib-1-2       0.102-1
ii  libgcrypt20            1.6.2-4+b1
ii  libglib2.0-0           2.42.1-1
ii  libgnutls-deb0-28      3.3.8-5
ii  libgudev-1.0-0         215-8
ii  libmm-glib0            1.4.0-1
ii  libndp0                1.4-2
ii  libnewt0.52            0.52.17-1+b1
ii  libnl-3-200            3.2.24-2
ii  libnl-genl-3-200       3.2.24-2
ii  libnl-route-3-200      3.2.24-2
ii  libnm-glib4            0.9.10.0-3
ii  libnm-util2            0.9.10.0-3
ii  libpam-systemd         215-8
ii  libpolkit-gobject-1-0  0.105-8
ii  libreadline6           6.3-8+b2
ii  libsoup2.4-1           2.48.0-1
ii  libsystemd0            215-8
ii  libteamdctl0           1.12-1
ii  libuuid1               2.25.2-4
ii  lsb-base               4.1+Debian13+nmu1
ii  policykit-1            0.105-8
ii  udev                   215-8
ii  wpasupplicant          2.3-1

Versions of packages network-manager recommends:
ii  crda          3.13-1
ii  dnsmasq-base  2.72-2
ii  iptables      1.4.21-2+b1
ii  modemmanager  1.4.0-1
ii  ppp           2.4.6-3

Versions of packages network-manager suggests:
ii  avahi-autoipd  0.6.31-4+b2
pn  libteam-utils  <none>

-- no debconf information
>From 2c1d2bc6064fc924db3537a63636a0153c4f4aea Mon Sep 17 00:00:00 2001
From: Mikko Rapeli <mikko.rap...@iki.fi>
Date: Mon, 15 Dec 2014 16:47:45 +0100
Subject: [PATCH] Tell systemd to restart NetworkManager.service if it exited
 with failure

Crashed NetworkManager.service was not restarted by systemd.

Signed-off-by: Mikko Rapeli <mikko.rap...@iki.fi>
---
 data/NetworkManager.service.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/data/NetworkManager.service.in b/data/NetworkManager.service.in
index 84a9c95..b2e61ff 100644
--- a/data/NetworkManager.service.in
+++ b/data/NetworkManager.service.in
@@ -7,6 +7,7 @@ Before=network.target @DISTRO_NETWORK_SERVICE@
 Type=dbus
 BusName=org.freedesktop.NetworkManager
 ExecStart=@sbindir@/NetworkManager --no-daemon
+Restart=on-failure
 # NM doesn't want systemd to kill its children for it
 KillMode=process
 
-- 
2.1.3

Reply via email to