Bug#774867: [Pkg-lirc-maint] Bug#774867: lirc: diff for NMU version 0.9.0~pre1-1.2
On Sun, Jan 18, 2015 at 01:20:14AM +0100, gregor herrmann wrote: On Sun, 18 Jan 2015 01:03:36 +0100, Stefan Lippers-Hollmann wrote: On Saturday 17 January 2015, gregor herrmann wrote: I've prepared an NMU for lirc (versioned as 0.9.0~pre1-1.2) and uploaded it to DELAYED/2. Please feel free to tell me if I should delay it longer. First of all, I acknowledge the NMU - thanks a lot, go ahead as you wish, but... Thanks! I don't object to the patch, but it doesn't really help with this bug. The bug itself only happens when dist-upgrading from squeeze to wheezy, neither wheezy, jessie or wheezy--jessie upgrades are affected at all, so fixing this bug in jessie doesn't help any squeeze user who's just now starting to look at dist-upgrading to wheezy at all. I thought the same too, when looking at the bug, but my tests were quite interesting: - squeeze chroot, lirc-x installed - updated to wheezy - here the bug occurs - updated to jessie with the patched package: here the problem gets fixed So my conclusion is that the fix does help people who upgraded from squeeze (but it's indeed not necessary for people who install(ed) only the wheezy or jessie version). That's correct. This class of bugs affects older installations that are dist-upgraded through. We don't support skipping releases, but we do support upgrading through releases. The problem occurs because dpkg will *never* replace an existing symlink with a new directory or vice-versa. However, the files do get written, following the symlink. For packages that are a mixture of arch:any and arch:all, and where files are slightly different depending on architecture, this can be a real headache. It may have been caused in Wheezy, but it still needs fixing in Jessie. Therefore I'm curious, what is your plan with this bugfix? Asking the release team for a jessie unblock doesn't really meet the unblock criteria anymore, as the bug doesn't affect jessie nor wheezy to jessie dist-upgrades (actually, had this bug been reported and fixed in time before the wheezy release, I would have already removed this kind of pre-wheezy upgrade support from the packages intended for jessie). I'll let Jonathan answer this question; but since he uploaded the same fix I'd assume that the release team will unblock the package :) I assure you that RC bugs affecting Jessie are still candidates for unblocks :) This piuparts mass bug filing imho would have better concentrated on just wheezy to jessie issues, rather than murkying the waters by including squeeze--wheezy issues as well, that ship has sailed long time ago. I'm also a bit ambivalent about the value of those squeeze-wheezy-jessie upgrade tests where many issues just can't be fixed anymore. But unless I'm confusing something in my test setup, this is a case where a fix in jessie repairs a problem introduced earlier. Indeed, and where this occurs in /usr/share/doc it's not really worth fixing in stable, but should be sorted out where we can. -- Jonathan Wiltshire j...@debian.org Debian Developer http://people.debian.org/~jmw 4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC 74C3 5394 479D D352 4C51 signature.asc Description: Digital signature
Bug#774867: [Pkg-lirc-maint] Bug#774867: lirc: diff for NMU version 0.9.0~pre1-1.2
Hi
[ Apologies if you receive this twice, my mail relay/ smarthost seems
to have problems and my previous/ identical response hasn't gotten
through yet. ]
On Saturday 17 January 2015, gregor herrmann wrote:
Control: tags 774867 + patch
Control: tags 774867 + pending
Dear maintainer,
I've prepared an NMU for lirc (versioned as 0.9.0~pre1-1.2) and
uploaded it to DELAYED/2. Please feel free to tell me if I
should delay it longer.
First of all, I acknowledge the NMU - thanks a lot, go ahead as you
wish, but...
[feel free to ignore the rest of this mail]
I don't object to the patch, but it doesn't really help with this bug.
The bug itself only happens when dist-upgrading from squeeze to wheezy,
neither wheezy, jessie or wheezy--jessie upgrades are affected at all,
so fixing this bug in jessie doesn't help any squeeze user who's just
now starting to look at dist-upgrading to wheezy at all. Actually it's
even worse, symlink_to_dir was only added to dpkg's maintscript
collection in dpkg 1.17.14, while squeeze is at 1.15.11 (admitted,
Pre-Depends: ${misc:Pre-Depends} should handle that aspect).
Therefore I'm curious, what is your plan with this bugfix?
Asking the release team for a jessie unblock doesn't really meet the
unblock criteria anymore, as the bug doesn't affect jessie nor wheezy
to jessie dist-upgrades (actually, had this bug been reported and fixed
in time before the wheezy release, I would have already removed this
kind of pre-wheezy upgrade support from the packages intended for
jessie).
Asking the stable-release managers to accept a wheezy-proposed-updates
upload for an equivalent fix targetting the next wheezy point release
would be justified - and I certainly would have done so up to 'a year
ago', but now that squeeze is EOL for over half a year already, it
feels a bit late (still correct, but as no actual user ever complained,
'why bother' (and get the stable-release managers busy for basically an
obsolete problem) at this point in time)?
So considerding that this change is neither needed for jessie+1
(stretch), nor fullfills the unblock criterias for jessie (and isn't
actually needed there either), the (correct) upload can only migrate
to testing (==stretch) after jessie has been released - when and where
it is even less needed than in jessie itself.
Accordingly, my plan was waiting until this weekend for a potential
response from the reporter, but pending that, to close the bug for
lirc 0.9.0~pre1-1.1 (the package version in jessie, technically not
100% correct, but it conveys the message correctly; asking the release
team for a jessie-ignore would basically do the same job) and tagging
it wheezy and wontfix. But as I mentioned, your change is the correct
solution, it's imho just way too late to fix at this point in time,
when the fix won't ever propagate to the only ones (current squeeze
users who are planning to dist-upgrade to wheezy) anymore. Making it
just academic busy-work for everyone involved.
To be clear, I very much appreciate your effort - thanks a lot - and
I'm fine with getting this uploaded to unstable, but I personally don't
see a need to bother the release team with an unblock request
(certainly not for jessie, nor -at this point in time- for wheezy
anymore) at this point in the freeze.
...and the next regular post-jessie lirc upload will just remove all
pre-jessie upgrade support (including this change[1]) from the package
anyways...
This piuparts mass bug filing imho would have better concentrated on
just wheezy to jessie issues, rather than murkying the waters by
including squeeze--wheezy issues as well, that ship has sailed long
time ago.
Regards
Stefan Lippers-Hollmann
[1] there would be reason to make an exception for this particular
change to go through one stable release, just to get it fixed
once and for all for everyone, but that's mostly academic here.
signature.asc
Description: This is a digitally signed message part.
Bug#774867: [Pkg-lirc-maint] Bug#774867: lirc: diff for NMU version 0.9.0~pre1-1.2
On Sun, 18 Jan 2015 01:03:36 +0100, Stefan Lippers-Hollmann wrote: On Saturday 17 January 2015, gregor herrmann wrote: I've prepared an NMU for lirc (versioned as 0.9.0~pre1-1.2) and uploaded it to DELAYED/2. Please feel free to tell me if I should delay it longer. First of all, I acknowledge the NMU - thanks a lot, go ahead as you wish, but... Thanks! I don't object to the patch, but it doesn't really help with this bug. The bug itself only happens when dist-upgrading from squeeze to wheezy, neither wheezy, jessie or wheezy--jessie upgrades are affected at all, so fixing this bug in jessie doesn't help any squeeze user who's just now starting to look at dist-upgrading to wheezy at all. I thought the same too, when looking at the bug, but my tests were quite interesting: - squeeze chroot, lirc-x installed - updated to wheezy - here the bug occurs - updated to jessie with the patched package: here the problem gets fixed So my conclusion is that the fix does help people who upgraded from squeeze (but it's indeed not necessary for people who install(ed) only the wheezy or jessie version). Therefore I'm curious, what is your plan with this bugfix? Asking the release team for a jessie unblock doesn't really meet the unblock criteria anymore, as the bug doesn't affect jessie nor wheezy to jessie dist-upgrades (actually, had this bug been reported and fixed in time before the wheezy release, I would have already removed this kind of pre-wheezy upgrade support from the packages intended for jessie). I'll let Jonathan answer this question; but since he uploaded the same fix I'd assume that the release team will unblock the package :) This piuparts mass bug filing imho would have better concentrated on just wheezy to jessie issues, rather than murkying the waters by including squeeze--wheezy issues as well, that ship has sailed long time ago. I'm also a bit ambivalent about the value of those squeeze-wheezy-jessie upgrade tests where many issues just can't be fixed anymore. But unless I'm confusing something in my test setup, this is a case where a fix in jessie repairs a problem introduced earlier. Cheers, gregor -- .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/ `. `' Member of VIBE!AT SPI, fellow of the Free Software Foundation Europe `- NP: Schmetterlinge: Ballade vom Glück und Ende des Kapitals signature.asc Description: Digital Signature
Bug#774867: [Pkg-lirc-maint] Bug#774867: lirc: diff for NMU version 0.9.0~pre1-1.2
Hi
On Saturday 17 January 2015, gregor herrmann wrote:
Control: tags 774867 + patch
Control: tags 774867 + pending
Dear maintainer,
I've prepared an NMU for lirc (versioned as 0.9.0~pre1-1.2) and
uploaded it to DELAYED/2. Please feel free to tell me if I
should delay it longer.
First of all, I acknowledge the NMU - thanks a lot, go ahead as you
wish, but...
[feel free to ignore the rest of this mail]
I don't object to the patch, but it doesn't really help with this bug.
The bug itself only happens when dist-upgrading from squeeze to wheezy,
neither wheezy, jessie or wheezy--jessie upgrades are affected at all,
so fixing this bug in jessie doesn't help any squeeze user who's just
now starting to look at dist-upgrading to wheezy at all. Actually it's
even worse, symlink_to_dir was only added to dpkg's maintscript
collection in dpkg 1.17.14, while squeeze is at 1.15.11 (admitted,
Pre-Depends: ${misc:Pre-Depends} should handle that aspect).
Therefore I'm curious, what is your plan with this bugfix?
Asking the release team for a jessie unblock doesn't really meet the
unblock criteria anymore, as the bug doesn't affect jessie nor wheezy
to jessie dist-upgrades (actually, had this bug been reported and fixed
in time before the wheezy release, I would have already removed this
kind of pre-wheezy upgrade support from the packages intended for
jessie).
Asking the stable-release managers to accept a wheezy-proposed-updates
upload for an equivalent fix targetting the next wheezy point release
would be justified - and I certainly would have done so up to 'a year
ago', but now that squeeze is EOL for over half a year already, it
feels a bit late (still correct, but as no actual user ever complained,
'why bother' (and get the stable-release managers busy for basically an
obsolete problem) at this point in time)?
So considerding that this change is neither needed for jessie+1
(stretch), nor fullfills the unblock criterias for jessie (and isn't
actually needed there either), the (correct) upload can only migrate
to testing (==stretch) after jessie has been released - when and where
it is even less needed than in jessie itself.
Accordingly, my plan was waiting until this weekend for a potential
response from the reporter, but pending that, to close the bug for
lirc 0.9.0~pre1-1.1 (the package version in jessie, technically not
100% correct, but it conveys the message correctly; asking the release
team for a jessie-ignore would basically do the same job) and tagging
it wheezy and wontfix. But as I mentioned, your change is the correct
solution, it's imho just way too late to fix at this point in time,
when the fix won't ever propagate to the only ones (current squeeze
users who are planning to dist-upgrade to wheezy) anymore. Making it
just academic busy-work for everyone involved.
To be clear, I very much appreciate your effort - thanks a lot - and
I'm fine with getting this uploaded to unstable, but I personally don't
see a need to bother the release team with an unblock request
(certainly not for jessie, nor -at this point in time- for wheezy
anymore) at this point in the freeze.
...and the next regular /post-jessie/ lirc upload will just remove all
pre-jessie upgrade support (including this change[1]) from the package
anyways...
This piuparts mass bug filing imho would have better concentrated on
just wheezy to jessie issues, rather than murkying the waters by
including squeeze--wheezy issues as well, that ship has sailed long
time ago.
Regards
Stefan Lippers-Hollmann
[1] there would be reason to make an exception for this particular
change to go through one stable release, just to get it fixed
once and for all for everyone, but that's mostly academic here.
signature.asc
Description: This is a digitally signed message part.
