Bug#787080: Bug#894119: libreoffice: Please add libreoffice-online to the debian repository.

2021-03-17 Thread Rene Engelhard
Hi,

Am 16.03.21 um 22:02 schrieb Adi Kriegisch:
> thank you very much for the hard work you've put in packaging libreoffice
> online. Starting from your salsa repo[1] I was able to successfully build
> loolwsd and loleaflet packages with the libreoffice packages from
> buster-backports. There were, however, some issues with the unit tests.
> After trying to investigate some of the issues, I decided to skip the test
> by adding an empty override_dh_auto_test target.

Yeah, that one is a mess upstream:

- unit tests need debug

- tests need write permissions in the LO directory (which they of course
don't have in /usr/lib/libreoffice)

...


> Is there any reason why you use loolwsd's init script to configure it
> instead of setting the defaults in /etc/loolwsd/loolwsd.xml? With the
> current init script this does not work.

That part wasn't updated for some time, I wouldn't be surprised if it broke.

/etc/default is a well-known location for environment variables needed
by init scripts, though.


That said, for init script I'd stay as close as with upstream as
possible since maintaining an initi script is a PITA.

(People ideally should use systemd and the systemd unit anyway but init
scripts still should be shipped if feasible.)


But MRs (or patches if you don't have an account on salsa) welcome.

> I very much hope, you're going to continue your excellent work and
> libreoffice online hits the debian archive any time in a not too distant
> future! ;-)

If someone sorts out the JS mess and packages the modules (and keeps the
chain uptodate) ;-)

Then we just need to figure out the test mess (maybe not run them during
the build at all indeed and make it a

"needs-root breaks-testbed" autopkgtest. One should probably add a
autopkgtest anyway.)


Regards,


Rene



Bug#787080: Bug#894119: libreoffice: Please add libreoffice-online to the debian repository.

2021-03-16 Thread Adi Kriegisch
Dear Rene,

thank you very much for the hard work you've put in packaging libreoffice
online. Starting from your salsa repo[1] I was able to successfully build
loolwsd and loleaflet packages with the libreoffice packages from
buster-backports. There were, however, some issues with the unit tests.
After trying to investigate some of the issues, I decided to skip the test
by adding an empty override_dh_auto_test target.

Is there any reason why you use loolwsd's init script to configure it
instead of setting the defaults in /etc/loolwsd/loolwsd.xml? With the
current init script this does not work.
May I suggest to use a simpler init script like this one:
8<-8<-8<-8<-8<-8<-8<-8<-
#!/bin/sh
# kFreeBSD do not accept scripts as interpreters, using #!/bin/sh and sourcing.
if [ true != "$INIT_D_SCRIPT_SOURCED" ] ; then
set "$0" "$@"; INIT_D_SCRIPT_SOURCED=true . /lib/init/init-d-script
fi
### BEGIN INIT INFO
# Provides:  loolwsd
# Required-Start:$remote_fs 
# Required-Stop: $remote_fs 
# Default-Start: 2 3 4 5
# Default-Stop:  0 1 6
# Short-Description: libreoffice online server
# Description:   libreoffice online server
### END INIT INFO

DESC="libreoffice online server" 
DAEMON=/usr/bin/loolwsd
DAEMON_ARGS="--daemon"
START_ARGS="--chuid lool --user lool"
->8->8->8->8->8->8->8->8

I very much hope, you're going to continue your excellent work and
libreoffice online hits the debian archive any time in a not too distant
future! ;-)

best regards,
Adi Kriegisch

[1] https://salsa.debian.org/libreoffice-team/libreoffice/libreoffice-online/


signature.asc
Description: PGP signature


Bug#787080: Bug#894119: libreoffice: Please add libreoffice-online to the debian repository.

2018-04-11 Thread Rene Engelhard
retitle 894119 RFP: libreoffice-online
reassign 894119 wnpp
forcemerge 787080 894119
thanks

On Mon, Mar 26, 2018 at 06:16:04PM +0300, kpp wrote:
> Package: libreoffice
> Version: 1:5.2.7-1+deb9u3
> Severity: wishlist

No, this is not a bug in LibreOffice itself. It's a wish for a new
package, which isn't even developed inside the LO "core" code and thus
wouldn't be built from here anyway.

And definitely not in stable in any case.

> Please add libreoffice-online to the debian. I suppose it is very useful
> feature.

Maybe, but you need consumers for it. Of which I know of nextclouds
richdocument stff but that one isn't packaged either. :)
A daemon and JS stuff for "nothing" doesn't really help, does it?

Also see https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=787080.
I have a building (with npm from nodejs package...) package, but I am not
succeeding getting it to work... It's all theory anyway given the npm
JS mess and that it 

Current packaging is at
https://salsa.debian.org/libreoffice-team/libreoffice/libreoffice-online,
though...

Regards,

Rene