Bug#798206: gnome-orca: Binding to report notifications does not work

[Mario Lang]

Jean-Philippe MENGUAL  writes:

> Package: gnome-orca
> Version: 3.16.2-1
> Severity: normal
>
> Dear Maintainer,
>
> *** Reporter, please consider answering these questions, where appropriate ***
>
>* What led up to the situation?
>
> I use orca 3.16 here, with MATE desktop.
>
>* What exactly did you do (or not do) that was effective (or
>  ineffective)?
>
> 1. ins-space
> 2. Create 3 bindings in Bindings tab:
> - ins-f8 for speaking previous notification message;
> - ins-f9 for speaking latest notif message
> - ins-f10 to have notif messages list
>
> 3. Save. 
> 4. On an IRC client in MATE, be highlighted by someone. O!ca reads the notif.
>
>* What was the outcome of this action?
>
> If you issue ins-f8 f9 f10, orca says: "not notification message"
>
>* What outcome did you expect instead?
>
> It should speak the latest message, at least.
>
> *** End of the template - remove these template lines ***
>
> Attached a patch which will likely be applied upst!eam.

Thanks for your report.

The patch attached is already applied upstream.

> Could you apply it to the Debian release?

The patch you sent does not apply to 3.16.2, which is what we have in
Debian unstable right now.
There was an early change during the 3.17 cycle (b1c3c11) which prevents
it from applying cleanly on top of 3.16.2.

> It fixes the problem. This feature is quite useful. The Debian sackage
> should ship it via patch before the next Orca release.

Yes, it is simple.  It would have been simpler (for me) if you actually
submitted a patch that applied cleanly to 3.16.2.
However, indirectly pointing at the corresponding upstream commit is
somewhat sufficient, I managed to manually rebase the patch via git.

[...]

> You could apply too for Jessie.

To make one thing clear, we do not randomly patch stable.
A patch to stable has to fix a serious security issue.
Random simple fixes are *never* going to be applied to stable in
Debian.  This is how things go in Debian.
The reason for this is simply, that even if you think you are sure, you
will accidentally introduce new bugs into the system distribution if you
apply fixes to it more or less at random.

-- 
CYa,
  ⡍⠁⠗⠊⠕


signature.asc
Description: PGP signature

Bug#798206: gnome-orca: Binding to report notifications does not work

[Jean-Philippe MENGUAL]

Package: gnome-orca
Version: 3.16.2-1
Severity: normal

Dear Maintainer,

*** Reporter, please consider answering these questions, where appropriate ***

   * What led up to the situation?

I use orca 3.16 here, with MATE desktop.


   * What exactly did you do (or not do) that was effective (or
 ineffective)?

1. ins-space
2. Create 3 bindings in Bindings tab:
- ins-f8 for speaking previous notification message;
- ins-f9 for speaking latest notif message
- ins-f10 to have notif messages list

3. Save. 
4. On an IRC client in MATE, be highlighted by someone. O!ca reads the notif.

   * What was the outcome of this action?

If you issue ins-f8 f9 f10, orca says: "not notification message"

   * What outcome did you expect instead?

It should speak the latest message, at least.

*** End of the template - remove these template lines ***

Attached a patch which will likely be applied upst!eam. Could you apply it to 
the Debian release?
It fixes the problem. This feature is quite useful. The Debian sackage should
ship it via patch before the next Orca release. All the more as it's a small
patch, I applied in 
/usr/lib/python3/dist-packages/orca/scripts/apps/notification-daemon/script.py
I also pasted it here:
http://sprunge.us/EbWJ


Minor change. Really it'd be nice to apply. You could apply too for Jessie.

Thanks

Regards,



-- System Information:
Debian Release: stretch/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.1.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages gnome-orca depends on:
ii  gir1.2-glib-2.01.44.0-1+b2
ii  gir1.2-gtk-3.0 3.16.6-1
ii  gir1.2-pango-1.0   1.36.8-3
ii  gir1.2-wnck-3.03.14.0-2
ii  gsettings-desktop-schemas  3.16.1-1
ii  python33.4.3-4
ii  python3-brlapi 5.2~20141018-5
ii  python3-cairo  1.10.0+dfsg-4+b1
ii  python3-gi 3.16.2-1
ii  python3-louis  2.6.2-2
ii  python3-pyatspi2.16.0+dfsg-1
ii  python3-speechd0.8-7
pn  python3:any
ii  speech-dispatcher  0.8-7

Versions of packages gnome-orca recommends:
ii  libgail-common  2.24.28-1
ii  xbrlapi 5.2~20141018-5

gnome-orca suggests no packages.

-- no debconf information
>From 648659be997efef806c9db6ff35fb27aa3e3d43c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20Vilmar=20Est=C3=A1cio=20de=20Souza?=
 
Date: Sun, 6 Sep 2015 00:30:59 -0300
Subject: [PATCH] Add save messages to notification-daemon script

---
 src/orca/scripts/apps/notification-daemon/script.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/orca/scripts/apps/notification-daemon/script.py b/src/orca/scripts/apps/notification-daemon/script.py
index ebe4a06..b9fbd79 100644
--- a/src/orca/scripts/apps/notification-daemon/script.py
+++ b/src/orca/scripts/apps/notification-daemon/script.py
@@ -30,7 +30,7 @@ import pyatspi
 import orca.messages as messages
 import orca.scripts.default as default
 import orca.speech as speech
-
+import orca.notification_messages as notification_messages
 
 
 #  #
@@ -48,3 +48,4 @@ class Script(default.Script):
 texts = [self.utilities.displayedText(acc) for acc in allLabels]
 text = '%s %s' % (messages.NOTIFICATION, ' '.join(texts))
 speech.speak(text, None, True)
+notification_messages.saveMessage(text)
-- 
2.5.1