Bug#802032: gazebo: Don't depend on robot-player-dev (libgazebo5-dev)

[Anton Gladky]

2015-11-10 0:15 GMT+01:00 Jose Luis Rivero :
> Oh, I promised to the player maintainer to help with this package as it
> has been quite used by the robotics community some years ago and I think
> that it has still some users (part of them from gazebo support).
>
> Looks like patches are floating around to fix the serious bugs. Would
> you mind if I import it to debian-science and patch the whole thing?

Yes, if you want to maintain player, please contact its maintainer and feel
free to move the package under debian-science after his agreement
Anyway, if gazebo is not using this package, it would be good to drop
it from its build-depends.

Cheers

Anton

Bug#802032: gazebo: Don't depend on robot-player-dev (libgazebo5-dev)

[Paul Gevers]

Hi all, (Original message obviously sent to the wrong list)

On Sat, 17 Oct 2015 07:32:15 +0200 Paul Gevers  wrote:
> I want to get rid of the player package in Debian in its current state. To
> achieve that I filled a request for the removal of player¹, which is correctly
> not processed yet. Your package libgazebo5-dev depends on one of its binary
> packages. As libgazebo5-dev is only a -dev package, you can safely remove the
> dependency. I checked that contrary to the changelog, the binaries build from
> gazebo don't actually build in player support, see the build log (amd64):
> 
> - -- checking for modules 'playercore>=3.0;playerc++;playerwkb'
> - --   package 'playercore>=3.0' not found
> - --   package 'playerc++' not found
> - --   package 'playerwkb' not found
> - --  Player not found, gazebo plugin for player will not be built.
> 
> and later:
> 
> - -- BUILD WARNINGS
> - --  OpenAL not found, audio support will be disabled.
> - --  DART not found, for dart physics engine option, please install 
> libdart-core4-dev.
> - --  Player not found, gazebo plugin for player will not be built.
> - --  Oculus Rift support will be disabled.
> - -- END BUILD WARNINGS
> 
> So I ask you to drop this dependency. The alternative is that you help the
> maintainer (should be in CC of this bug) of player to get the package in
> shape. It needs quite some love.
> 
> You can find my trivial debdiff patch attached. Just so you are aware, I am
> considering to NMU gazebo just to fix this issue if this is not handled in a
> timely manner. (This is not intended to sound hostile, I am just doing QA for
> Debian. I have no feeling whatsoever for either player of gazebo.)

> ¹ https://bugs.debian.org/801898

I see there is a new version of gazebo, but no response to my request to
drop the Recommends on robot-player-dev. I heard from Graham that maybe
not all people from debian-science are reading the
debian-science-maintainers mail list, so I post here now. Could we
please agree on the way how to make Debian slightly better (I propose to
remove player).

And for your knowledge, the maintainer of player agrees (off-line) that
player can be removed from Debian for now.

Paul





signature.asc
Description: OpenPGP digital signature

Bug#802032: gazebo: Don't depend on robot-player-dev (libgazebo5-dev)

[Anton Gladky]

Hi Peter,

2015-11-09 20:16 GMT+01:00 Paul Gevers :
> Could we please agree on the way how to make Debian slightly better (I 
> propose to
> remove player).

Sure, I can prepare such an upload. Jose, are you OK with that?

Anton

Bug#802032: gazebo: Don't depend on robot-player-dev (libgazebo5-dev)

[Paul Gevers]

Hi Jose

On 10-11-15 06:25, Anton Gladky wrote:
> 2015-11-10 0:15 GMT+01:00 Jose Luis Rivero :
> Anyway, if gazebo is not using this package, it would be good to drop
> it from its build-depends.

This is my opinion as well. As gazebo doesn't use player, please just
remove the dependency. After that, if you get the player package in
shape in time (I won't remove the moreinfo tag on the removal request
quickly) then you can just upload a new version of player. If it takes
too long, we can just remove it without further ado.

Paul



signature.asc
Description: OpenPGP digital signature

Bug#802032: gazebo: Don't depend on robot-player-dev (libgazebo5-dev)

[Jose Luis Rivero]

On 11/09/2015 08:22 PM, Anton Gladky wrote:
> Hi Peter,
> 
> 2015-11-09 20:16 GMT+01:00 Paul Gevers :
>> Could we please agree on the way how to make Debian slightly better (I 
>> propose to
>> remove player).
> 
> Sure, I can prepare such an upload. Jose, are you OK with that?
> 

Oh, I promised to the player maintainer to help with this package as it
has been quite used by the robotics community some years ago and I think
that it has still some users (part of them from gazebo support).

Looks like patches are floating around to fix the serious bugs. Would
you mind if I import it to debian-science and patch the whole thing?

Thanks.



-- 
Jose Luis Rivero 

Bug#802032: gazebo: Don't depend on robot-player-dev (libgazebo5-dev)

[Paul Gevers]

Hi all,

On Sat, 17 Oct 2015 07:32:15 +0200 Paul Gevers  wrote:
> I want to get rid of the player package in Debian in its current state. To
> achieve that I filled a request for the removal of player¹, which is correctly
> not processed yet. Your package libgazebo5-dev depends on one of its binary
> packages. As libgazebo5-dev is only a -dev package, you can safely remove the
> dependency. I checked that contrary to the changelog, the binaries build from
> gazebo don't actually build in player support, see the build log (amd64):
> 
> - -- checking for modules 'playercore>=3.0;playerc++;playerwkb'
> - --   package 'playercore>=3.0' not found
> - --   package 'playerc++' not found
> - --   package 'playerwkb' not found
> - --  Player not found, gazebo plugin for player will not be built.
> 
> and later:
> 
> - -- BUILD WARNINGS
> - --  OpenAL not found, audio support will be disabled.
> - --  DART not found, for dart physics engine option, please install 
> libdart-core4-dev.
> - --  Player not found, gazebo plugin for player will not be built.
> - --  Oculus Rift support will be disabled.
> - -- END BUILD WARNINGS
> 
> So I ask you to drop this dependency. The alternative is that you help the
> maintainer (should be in CC of this bug) of player to get the package in
> shape. It needs quite some love.
> 
> You can find my trivial debdiff patch attached. Just so you are aware, I am
> considering to NMU gazebo just to fix this issue if this is not handled in a
> timely manner. (This is not intended to sound hostile, I am just doing QA for
> Debian. I have no feeling whatsoever for either player of gazebo.)

> ¹ https://bugs.debian.org/801898

I see there is a new version of gazebo, but no response to my request to
drop the Recommends on robot-player-dev. I heard from Graham that maybe
not all people from debian-science are reading the
debian-science-maintainers mail list, so I post here now. Could we
please agree on the way how to make Debian slightly better (I propose to
remove player).

And for your knowledge, the maintainer of player agrees (off-line) that
player can be removed from Debian for now.

Paul



signature.asc
Description: OpenPGP digital signature

Bug#802032: gazebo: Don't depend on robot-player-dev (libgazebo5-dev)

[Paul Gevers]

Source: gazebo
Severity: normal
Tags: patch

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Hi Debian Science Maintainers,

I want to get rid of the player package in Debian in its current state. To
achieve that I filled a request for the removal of player¹, which is correctly
not processed yet. Your package libgazebo5-dev depends on one of its binary
packages. As libgazebo5-dev is only a -dev package, you can safely remove the
dependency. I checked that contrary to the changelog, the binaries build from
gazebo don't actually build in player support, see the build log (amd64):

- -- checking for modules 'playercore>=3.0;playerc++;playerwkb'
- --   package 'playercore>=3.0' not found
- --   package 'playerc++' not found
- --   package 'playerwkb' not found
- --Player not found, gazebo plugin for player will not be built.

and later:

- -- BUILD WARNINGS
- --OpenAL not found, audio support will be disabled.
- --DART not found, for dart physics engine option, please install 
libdart-core4-dev.
- --Player not found, gazebo plugin for player will not be built.
- --Oculus Rift support will be disabled.
- -- END BUILD WARNINGS

So I ask you to drop this dependency. The alternative is that you help the
maintainer (should be in CC of this bug) of player to get the package in
shape. It needs quite some love.

You can find my trivial debdiff patch attached. Just so you are aware, I am
considering to NMU gazebo just to fix this issue if this is not handled in a
timely manner. (This is not intended to sound hostile, I am just doing QA for
Debian. I have no feeling whatsoever for either player of gazebo.)

Paul
¹ https://bugs.debian.org/801898


- -- System Information:
Debian Release: 8.2
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable'), (60, 'unstable'), (50, 
'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.16.0-4-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

-BEGIN PGP SIGNATURE-
Version: GnuPG v1

iQEcBAEBCAAGBQJWId1WAAoJEJxcmesFvXUKkAoH/iZT5enmm35A6z9QkLiIeQ7D
lzq/GMLL7xMERehFJKvPWoVXFrPjhdEI4bQq+09BISK2wF2GCAHiRteg6ugnrCG+
IrBS2myVgC3TT4cTBMMcwdDFQfo62jcF1AInMQ13UWVT4nERZoZqIUpHx4rbSW3b
Oppc9grGY6t2sXo02n+0uSyD+xQHBqK3LZ+GPkJak7UdUM+NSLXK+gqCygdrzlbV
1wiBHw1LVQD/Le80wd284AfQP8sewAI0LVumJhLE/qn2bidWP7eV643+Vo+TVjkn
fZHJGbyR+S8tJrBLKZmeg5/tSB4df1ZGNcZfsQWJn4O1fTr2qGgpZyqdmSBhBBA=
=MJd3
-END PGP SIGNATURE-
diff --git a/debian/changelog b/debian/changelog
index 85c222d..7cd74cf 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,12 @@
+gazebo (5.0.1+dfsg-2.2) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Remove robot-player-dev dependency from libgazebo5-dev as player
+is about to be removed from Debian and gazebo doesn't use player
+anyways.
+
+ -- Paul Gevers   Sat, 17 Oct 2015 07:13:23 +0200
+
 gazebo (5.0.1+dfsg-2.1) unstable; urgency=medium
 
   * Non-maintainer upload.
diff --git a/debian/control b/debian/control
index 3b5d85e..d1ac7c2 100644
--- a/debian/control
+++ b/debian/control
@@ -126,7 +126,6 @@ Depends: libtbb-dev,
 	 libswscale-dev,
 	 libsdformat-dev (>= 2.1.0),
 	 libsimbody-dev,
-	 robot-player-dev,
 	 libgazebo5 (= ${binary:Version}),
 	 gazebo5-common (= ${source:Version}),
 	 gazebo5-plugin-base (= ${binary:Version}),