Bug#810968: [debian-mysql] Bug#810968: Bug#810968: mariadb-server-10.0: Logrotate exists 1 if a non-debian mysqld is running (e.g. containerized mysqld)

FYI: applied to MariaDB 10.0 https://github.com/MariaDB/server/commit/8942824a5304e23f765b88d07498786d80092843

Bug#810968: [debian-mysql] Bug#810968: Bug#810968: mariadb-server-10.0: Logrotate exists 1 if a non-debian mysqld is running (e.g. containerized mysqld)

Hi Lennart, On Tue, Mar 08, 2016 at 04:25:06PM +, Lennart Weller wrote: > March 8 2016 1:52 PM, "Sergey Vojtovich" wrote: > > I adjusted your patch a bit, it seem to work well for me. Could you please > > verify if you're fine with the attached version and it works for you

Bug#810968: [debian-mysql] Bug#810968: Bug#810968: mariadb-server-10.0: Logrotate exists 1 if a non-debian mysqld is running (e.g. containerized mysqld)

March 8 2016 1:52 PM, "Sergey Vojtovich" wrote: > I adjusted your patch a bit, it seem to work well for me. Could you please > verify if you're fine with the attached version and it works for you too? Well you basically dropped all the safe guards. But in the end its a

Bug#810968: [debian-mysql] Bug#810968: Bug#810968: mariadb-server-10.0: Logrotate exists 1 if a non-debian mysqld is running (e.g. containerized mysqld)

Hi Lennart, I adjusted your patch a bit, it seem to work well for me. Could you please verify if you're fine with the attached version and it works for you too? On Mon, Mar 07, 2016 at 04:35:43PM +0100, Lennart Weller wrote: > On Mon, Mar 07, 2016 at 06:37:49PM +0400, Sergey Vojtovich wrote: > >

Bug#810968: [debian-mysql] Bug#810968: Bug#810968: mariadb-server-10.0: Logrotate exists 1 if a non-debian mysqld is running (e.g. containerized mysqld)

On Mon, Mar 07, 2016 at 06:37:49PM +0400, Sergey Vojtovich wrote: > Existence of pid-file is a sure sign that there's mysqld running, the only > exception is mysqld crash. What do you think about skipping this check? > > I'd also suggest to turn things around and check for pid-file first and then

Bug#810968: [debian-mysql] Bug#810968: Bug#810968: mariadb-server-10.0: Logrotate exists 1 if a non-debian mysqld is running (e.g. containerized mysqld)

Lennart, On Mon, Mar 07, 2016 at 02:43:14PM +0100, Lennart Weller wrote: ...skip... > diff --git a/mariadb-server-10.0.mysql-server.logrotate.orig > b/mariadb-server-10.0.mysql-server.logrotate > index 52f1292..9a2050a 100644 > --- a/mariadb-server-10.0.mysql-server.logrotate.orig > +++

Bug#810968: [debian-mysql] Bug#810968: Bug#810968: mariadb-server-10.0: Logrotate exists 1 if a non-debian mysqld is running (e.g. containerized mysqld)

On Mon, Mar 07, 2016 at 04:15:54PM +0400, Sergey Vojtovich wrote: > > March 3 2016 9:35 PM, "Otto Kekäläinen" wrote: > I consider it lesser evil. You may use my_print_defaults to get > pid-file value. > > Worth to note that I don't see any value in executing "mysqladmin ping". I

Bug#810968: [debian-mysql] Bug#810968: Bug#810968: mariadb-server-10.0: Logrotate exists 1 if a non-debian mysqld is running (e.g. containerized mysqld)

March 3 2016 9:35 PM, "Otto Kekäläinen" wrote: > Hello Lennart! > > I asked core developers to review this and got this reply: > > It's probably alright for 10.0. But it's not completely suitable for 10.1. > As contributor mentioned himself that there's a problem with this

Bug#810968: [debian-mysql] Bug#810968: Bug#810968: mariadb-server-10.0: Logrotate exists 1 if a non-debian mysqld is running (e.g. containerized mysqld)

Hello Lennart! I asked core developers to review this and got this reply: It's probably alright for 10.0. But it's not completely suitable for 10.1. As contributor mentioned himself that there's a problem with this patch: "When mysqld is called without mysqld_safe". I'd rather simplify

Bug#810968: [debian-mysql] Bug#810968: Bug#810968: mariadb-server-10.0: Logrotate exists 1 if a non-debian mysqld is running (e.g. containerized mysqld)

Hey Otto, Sorry I totally forgot about this. Yes, I do have an updated patch. I actually found there to be some issues with containers which had embedded mysqld forked from the start script so I added an additional check to the 2) version. Following problems might exist in the future with this

Bug#810968: [debian-mysql] Bug#810968: Bug#810968: mariadb-server-10.0: Logrotate exists 1 if a non-debian mysqld is running (e.g. containerized mysqld)

Hello Lennart! Do you intend to make one more version of the patch so that it is perfect and it is safe for me to include it in the next upload? Thanks for your help! 2016-01-26 11:13 GMT+02:00 Otto Kekäläinen : >> 2) Check the parent process id being 1 >>In this case parent