Bug#813461: cqrlog: FTBFS: lcommon.pp(515,18) Error: (5038) identifier idents no member "family"

[peter green]

tags 813461 +patch
thanks

cqrlog fails to build from source in unstable/amd64:

Colin asked me to take a look at this.

Fixing the build failure is trivial enough, just a matter of avoiding 
some field aliases that iirc were considered deprecated for some time 
and have been removed in 3.0.0


A patch is attatched, note that I have not tested whether the resulting 
packages work. No intent to NMU.
diff -urN cqrlog-1.9.0/debian/patches/fpc-3.0 cqrlog-1.9.0.new/debian/patches/fpc-3.0
--- cqrlog-1.9.0/debian/patches/fpc-3.0	1970-01-01 00:00:00.0 +
+++ cqrlog-1.9.0.new/debian/patches/fpc-3.0	2016-03-01 01:51:42.0 +
@@ -0,0 +1,31 @@
+Description: Fix build with fpc 3.0
+ Some deprecated field name aliases were removed in fpc 3.0. Update the code
+ to use non-deprecated names.
+Author: Peter Michael Green 
+Bug-Debian: https://bugs.debian.org/813461
+
+Index: cqrlog-1.9.0.new/src/lnet/lib/lcommon.pp
+===
+--- cqrlog-1.9.0.new.orig/src/lnet/lib/lcommon.pp
 cqrlog-1.9.0.new/src/lnet/lib/lcommon.pp
+@@ -512,15 +512,15 @@ end;
+ procedure FillAddressInfo(var aAddrInfo: TLSocketAddress; const aFamily: sa_family_t;
+   const Address: string; const aPort: Word);
+ begin
+-  aAddrInfo.IPv4.family := aFamily;
+-  aAddrInfo.IPv4.Port := htons(aPort);
++  aAddrInfo.IPv4.sin_family := aFamily;
++  aAddrInfo.IPv4.sin_port := htons(aPort);
+ 
+   case aFamily of
+ LAF_INET  :
+   begin
+-aAddrInfo.IPv4.Addr := StrToNetAddr(Address);
+-if (Address <> LADDR_ANY) and (aAddrInfo.IPv4.Addr = 0) then
+-  aAddrInfo.IPv4.Addr := StrToNetAddr(GetHostIP(Address));
++aAddrInfo.IPv4.sin_addr.s_addr := StrToNetAddr(Address);
++if (Address <> LADDR_ANY) and (aAddrInfo.IPv4.sin_addr.s_addr = 0) then
++  aAddrInfo.IPv4.sin_addr.s_addr := StrToNetAddr(GetHostIP(Address));
+   end;
+ LAF_INET6 :
+   begin
diff -urN cqrlog-1.9.0/debian/patches/series cqrlog-1.9.0.new/debian/patches/series
--- cqrlog-1.9.0/debian/patches/series	2015-09-22 17:59:53.0 +
+++ cqrlog-1.9.0.new/debian/patches/series	2016-02-29 23:13:15.0 +
@@ -1,3 +1,4 @@
 makefile-no-homedir-use
 desktop-keywords
 apparmor.patch
+fpc-3.0

Bug#813461: cqrlog: FTBFS: lcommon.pp(515,18) Error: (5038) identifier idents no member "family"

[Petr Hlozek]

This bug is caused by new fpc version 3.0. I'll fix it in next CQRLOG release.

-- 
http://HamQTH.com/ok2cqr
http://ok2cqr.com
http://cqrlog.com

Bug#813461: cqrlog: FTBFS: lcommon.pp(515,18) Error: (5038) identifier idents no member "family"

[Chris Lamb]

Source: cqrlog
Version: 1.9.0-5
Severity: serious
Justification: fails to build from source
User: reproducible-bui...@lists.alioth.debian.org
Usertags: ftbfs
X-Debbugs-Cc: reproducible-bui...@lists.alioth.debian.org

Dear Maintainer,

cqrlog fails to build from source in unstable/amd64:

  [..]

  (3104) Compiling ./lnet/lib/lcommon.pp
  100 170.379/179.712 Kb Used
  200 170.448/179.712 Kb Used
  300 170.448/179.712 Kb Used
  400 170.580/179.712 Kb Used
  500 170.847/179.712 Kb Used
  
/home/lamby/temp/cdt.20160202094813.oXWOfLxasg/cqrlog-1.9.0/src/./lnet/lib/lcommon.pp(515,18)
 Error: (5038) identifier idents no member "family"
  
/home/lamby/temp/cdt.20160202094813.oXWOfLxasg/cqrlog-1.9.0/src/./lnet/lib/lcommon.pp(516,18)
 Error: (5038) identifier idents no member "Port"
  
/home/lamby/temp/cdt.20160202094813.oXWOfLxasg/cqrlog-1.9.0/src/./lnet/lib/lcommon.pp(521,24)
 Error: (5038) identifier idents no member "Addr"
  
/home/lamby/temp/cdt.20160202094813.oXWOfLxasg/cqrlog-1.9.0/src/./lnet/lib/lcommon.pp(522,55)
 Error: (5038) identifier idents no member "Addr"
  
/home/lamby/temp/cdt.20160202094813.oXWOfLxasg/cqrlog-1.9.0/src/./lnet/lib/lcommon.pp(523,26)
 Error: (5038) identifier idents no member "Addr"
  lcommon.pp(537) Fatal: (10026) There were 5 errors compiling module, stopping
  Fatal: (1018) Compilation aborted
  Error: /usr/bin/ppcx64 returned an error exitcode
  Compile Project, Target: cqrlog: stopped with exit code 256
  [TCompiler.Compile] end
  ERROR: failed compiling of project 
/home/lamby/temp/cdt.20160202094813.oXWOfLxasg/cqrlog-1.9.0/src/cqrlog.lpi
  Makefile:9: recipe for target 'cqrlog' failed
  make[1]: *** [cqrlog] Error 2
  make[1]: Leaving directory 
'/home/lamby/temp/cdt.20160202094813.oXWOfLxasg/cqrlog-1.9.0'
  dh_auto_build: make -j1 returned exit code 2
  debian/rules:13: recipe for target 'build' failed
  make: *** [build] Error 2

  [..]

The full build log is attached.


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-


cqrlog.1.9.0-5.unstable.amd64.log.txt.gz
Description: Binary data