Bug#817005: RFS: aseqjoy/0.0.1-1 [ITP]

[Fernando Toledo]

El 10/05/16 a las 17:22, Gianfranco Costamagna escribió:

> 
> can you please fix the copyright?
> (I can also look at a "lintian-problematic" file and tell you what is wrong 
> in that case,
> otherwise my answer is too generic I admit)
> 
> thanks!
> 
> Gianfranco
> 
fixed, uploaded again and lintian happy!
;)

-- 
Fernando Toledo
Dock Sud BBS
http://bbs.docksud.com.ar
telnet://bbs.docksud.com.ar

Bug#817005: RFS: aseqjoy/0.0.1-1 [ITP]

[Gianfranco Costamagna]

Hi,

>https://mentors.debian.net/debian/pool/main/a/aseqjoy/aseqjoy_0.0.2-1.dsc


>I just upload to mentors.


wonderful!
>If use Files: * (for the upstream) and Files: debian/* (for mantainer)
>and both have same license this raise the lintian warning.


You shouldn't have any issue by doing
Files: *
Copyright: upstream
License: foo

Files: debian/*
Copyright: you
License: foo

License: foo


common errors are:
- you put debian before the "*" one
(the order *matters* here, from the most common to the particular license)
- you put the license text twice, just put it at the end and mention it on the 
specific
sections.

can you please fix the copyright?
(I can also look at a "lintian-problematic" file and tell you what is wrong in 
that case,
otherwise my answer is too generic I admit)

thanks!

Gianfranco

Bug#817005: RFS: aseqjoy/0.0.1-1 [ITP]

[Fernando Toledo]

El 09/05/16 a las 12:10, Gianfranco Costamagna escribió:
> yes, thanks Alexander for your effort, I personally don't like restricting 
> licenses,
> specially when they are just an honest upstream mistake!
> 
> Gianfranco
> 
> 
Hello all!

https://mentors.debian.net/debian/pool/main/a/aseqjoy/aseqjoy_0.0.2-1.dsc

I just upload to mentors.

Note: I fix the lintian
https://lintian.debian.org/tags/dep5-copyright-license-name-not-unique.html
warning using this copyright file format:



Files: *
Copyright: 2010 Alexander Koenig 
   2016 Fernando Toledo 
License: GPL-2+
 This program is free software; you can redistribute it
 and/or modify it under the terms of the GNU General Public
 License as published by the Free Software Foundation; either
 version 2 of the License, or (at your option) any later
 version.
 .
 This program is distributed in the hope that it will be
 useful, but WITHOUT ANY WARRANTY; without even the implied
 warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR
 PURPOSE.  See the GNU General Public License for more
 details.


Is correct?

I think that may confuse to that i are upstream author using Files: *

If use Files: * (for the upstream) and Files: debian/* (for mantainer)
and both have same license this raise the lintian warning.

If my patches have same license. Is it the better way to generate the
copyright file?

Thanks!


-- 
Fernando Toledo
Dock Sud BBS
http://bbs.docksud.com.ar
telnet://bbs.docksud.com.ar

Bug#817005: RFS: aseqjoy/0.0.1-1 [ITP]

[Gianfranco Costamagna]

yes, thanks Alexander for your effort, I personally don't like restricting 
licenses,
specially when they are just an honest upstream mistake!

Gianfranco





Il Lunedì 9 Maggio 2016 16:59, Fernando Toledo  ha 
scritto:
El 07/05/16 a las 08:31, Alexander Koenig escribió:

> On Fri, May 06, 2016, Gianfranco Costamagna wrote:
> <..>
>> I would appreciate however a new tarball, because I don't like having to 
>> tell ftpmasters
>> where to look in the mail list for the license change.
> 
> OK, to settle this I created a new aseqjoy release, that should remove all 
> license
> ambiguities.
> 
> http://terminatorx.org/files/aseqjoy-0.0.2.tar.gz
> 
> Hope this helps,
> Regards,
> Alex
> 
Great news! thanks Alexander!

I will build the package from that tarball and upload to mentors ASAP!

Saludos!

-- 
Fernando Toledo
Dock Sud BBS
http://bbs.docksud.com.ar
telnet://bbs.docksud.com.ar

Bug#817005: RFS: aseqjoy/0.0.1-1 [ITP]

[Fernando Toledo]

El 07/05/16 a las 08:31, Alexander Koenig escribió:
> On Fri, May 06, 2016, Gianfranco Costamagna wrote:
> <..>
>> I would appreciate however a new tarball, because I don't like having to 
>> tell ftpmasters
>> where to look in the mail list for the license change.
> 
> OK, to settle this I created a new aseqjoy release, that should remove all 
> license
> ambiguities.
> 
> http://terminatorx.org/files/aseqjoy-0.0.2.tar.gz
> 
> Hope this helps,
> Regards,
> Alex
> 
Great news! thanks Alexander!

I will build the package from that tarball and upload to mentors ASAP!

Saludos!

-- 
Fernando Toledo
Dock Sud BBS
http://bbs.docksud.com.ar
telnet://bbs.docksud.com.ar

Bug#817005: RFS: aseqjoy/0.0.1-1 [ITP]

[Alexander Koenig]

On Fri, May 06, 2016, Gianfranco Costamagna wrote:
<..>
> I would appreciate however a new tarball, because I don't like having to tell 
> ftpmasters
> where to look in the mail list for the license change.

OK, to settle this I created a new aseqjoy release, that should remove all 
license
ambiguities.

http://terminatorx.org/files/aseqjoy-0.0.2.tar.gz

Hope this helps,
Regards,
Alex
-- 
http://lisas.de/~alex

Bug#817005: RFS: aseqjoy/0.0.1-1 [ITP]

[Gianfranco Costamagna]

Hi Adam,



>What's the problem?


none, you are right!
I read again your previous mail, and yes, there is no conflict assuming we use 
GPL2 only.

I would appreciate however a new tarball, because I don't like having to tell 
ftpmasters
where to look in the mail list for the license change.

Anyway, Fernando, please tell me when you want a new check :)

cheers,

G.

Bug#817005: RFS: aseqjoy/0.0.1-1 [ITP]

[Adam Borowski]

On Fri, May 06, 2016 at 09:55:47AM +, Gianfranco Costamagna wrote:
> unfortunately I'm not sure this is enough for ftpmasters...
> 
> I'm afraid we need an official tarball with the fixed licenses, otherwise
> they won't be coherent license-wise.
> 
> this seems to be a blocker for now.

What's the problem?

1. A statement from the copyright holder is enough.  The license doesn't
need to be in the tarball -- Fernando can include the statement in
debian/copyright.

2. Even without the clarification, the only thing the old licenses forbid
is putting additions (such as the packaging) under GPL3 or some other
license not compatible with GPL2-only.

3. Other than compatibility with other licenses, no one really cares about
confusion wrt GPL2 vs GPL2+.  They don't conflict, all we lose is the
permission to use the code under a higher version of GPL.  As long as
debian/copyright assumes the worse option, I don't think any ftpmaster would
reject.

(Points 2. and 3. being moot now that Alexander, the copyright holder,
spoke.)

-- 
A tit a day keeps the vet away.

Bug#817005: RFS: aseqjoy/0.0.1-1 [ITP]

[Gianfranco Costamagna]

Hi Alexander,

unfortunately I'm not sure this is enough for ftpmasters...

I'm afraid we need an official tarball with the fixed licenses, otherwise
they won't be coherent license-wise.

this seems to be a blocker for now.

g.





Il Lunedì 2 Maggio 2016 21:27, Alexander Koenig  ha scritto:
Hi there,

the release is pretty dated; for sure I had no intentions to limit 
aseqjoy to strict GPL-V2 so you can consider aseqjoy-0.0.1 to be
GPL-V2+. This applies to all copyrightable files, including the man
page.

Thanks,
Alex

Bug#817005: RFS: aseqjoy/0.0.1-1 [ITP]

[Alexander Koenig]

Hi there,

the release is pretty dated; for sure I had no intentions to limit 
aseqjoy to strict GPL-V2 so you can consider aseqjoy-0.0.1 to be
GPL-V2+. This applies to all copyrightable files, including the man
page.

Thanks,
Alex

Bug#817005: RFS: aseqjoy/0.0.1-1 [ITP]

[Adam Borowski]

On Fri, Apr 29, 2016 at 09:31:50PM -0300, Fernando Toledo wrote:
> El 29/04/16 a las 18:31, Adam Borowski escribió:
> > On Fri, Apr 29, 2016 at 08:45:27PM +, Gianfranco Costamagna wrote:
> >> licensecheck *
> >> shows the license of some files as GPL-2+ not GPL-2
> > 
> > It looks like there's a mismatch:
> > 
> > README says:
> > # Copyright 2003 by Alexander K.nig - a...@lisas.de
> > # License: GPL V2 - see the file COPYING
> > (COPYING is the text of GPL-2)
> > 
> > but, aseqjoy.c says:
> > # or (at your option) any later version.
> > 
> > Too bad, while it's the only C source, there's one more copyrightable file,
> > aseqjoy.1.in, which doesn't embed a license statement and thus is covered by
> > the README.
> > 
> > So unless you contact the author or rewrite the manpage, the effective
> > license is GPL-2 only.
> >
> 
> if i understand, if i change the debian/* to GPL-2+ will solved only the
> patches issues? and still have problem with the upstream man file?
> my own patch just is trivial and solve spell lintian warning only.

GPL-2 is compatible with GPL-2+, so that's enough.

> i just send a email to the upstream author with this comments also.
> will need to release a new tarball with this changes?

Clarifying the license would be nice, but is not required: while it's not
sure what the author meant, there is one safe option: assuming GPL-2.
Of course, that means you can't combine it with GPL-3 patches or packaging.

Unless you hear back from the author soon, I'd recommend using GPL-2+ for
the packaging.  That's compatible with GPL-2, GPL-3, GPL-3+, or even future
GPL-4 or GPL-65535.

-- 
A tit a day keeps the vet away.

Bug#817005: RFS: aseqjoy/0.0.1-1 [ITP]

[Fernando Toledo]

El 29/04/16 a las 18:31, Adam Borowski escribió:
> On Fri, Apr 29, 2016 at 08:45:27PM +, Gianfranco Costamagna wrote:
>>> Fixed. Is possible to have upstream => gpl2 and debian/* => gpl3, true?
>>
>> this means that it will be impossible to forward patches upstream without 
>> manually
>> relicensing them.
>>
>> I personally don't prefer, because only the author of each patch will be 
>> able to forward
>> it upstream.
> 
> It's worse: as the package is built from sources under mutually conflicting
> licenses, it is indistributable.
> 
> As both the packaging and the only patch come exclusively from you, I'd
> simply change the license for debian/* to GPL-2+ (but, see below).
> 
>> licensecheck *
>> shows the license of some files as GPL-2+ not GPL-2
> 
> It looks like there's a mismatch:
> 
> README says:
> # Copyright 2003 by Alexander K.nig - a...@lisas.de
> # License: GPL V2 - see the file COPYING
> (COPYING is the text of GPL-2)
> 
> but, aseqjoy.c says:
> # or (at your option) any later version.
> 
> Too bad, while it's the only C source, there's one more copyrightable file,
> aseqjoy.1.in, which doesn't embed a license statement and thus is covered by
> the README.
> 
> So unless you contact the author or rewrite the manpage, the effective
> license is GPL-2 only.
>
hi both, thanks to help me.

if i understand, if i change the debian/* to GPL-2+ will solved only the
patches issues? and still have problem with the upstream man file?
my own patch just is trivial and solve spell lintian warning only.

i just send a email to the upstream author with this comments also.
will need to release a new tarball with this changes?

Thanks.


-- 
Fernando Toledo
Dock Sud BBS
http://bbs.docksud.com.ar
telnet://bbs.docksud.com.ar

Bug#817005: RFS: aseqjoy/0.0.1-1 [ITP]

[Adam Borowski]

On Fri, Apr 29, 2016 at 08:45:27PM +, Gianfranco Costamagna wrote:
> >Fixed. Is possible to have upstream => gpl2 and debian/* => gpl3, true?
> 
> this means that it will be impossible to forward patches upstream without 
> manually
> relicensing them.
> 
> I personally don't prefer, because only the author of each patch will be able 
> to forward
> it upstream.

It's worse: as the package is built from sources under mutually conflicting
licenses, it is indistributable.

As both the packaging and the only patch come exclusively from you, I'd
simply change the license for debian/* to GPL-2+ (but, see below).

> licensecheck *
> shows the license of some files as GPL-2+ not GPL-2

It looks like there's a mismatch:

README says:
# Copyright 2003 by Alexander K.nig - a...@lisas.de
# License: GPL V2 - see the file COPYING
(COPYING is the text of GPL-2)

but, aseqjoy.c says:
# or (at your option) any later version.

Too bad, while it's the only C source, there's one more copyrightable file,
aseqjoy.1.in, which doesn't embed a license statement and thus is covered by
the README.

So unless you contact the author or rewrite the manpage, the effective
license is GPL-2 only.

-- 
A tit a day keeps the vet away.

Bug#817005: RFS: aseqjoy/0.0.1-1 [ITP]

[Gianfranco Costamagna]

Hi,
sorry for the lag


>Fixed. Is possible to have upstream => gpl2 and debian/* => gpl3, true?



this means that it will be impossible to forward patches upstream without 
manually
relicensing them.

I personally don't prefer, because only the author of each patch will be able 
to forward
it upstream.

>> Standards-Version: 3.9.6 --> 3.9.7 now
>
>Fixed.


sorry, 3.9.8 now :)

>Thanks for your review, i just upload to mentors with these fixes.


licensecheck *
shows the license of some files as GPL-2+ not GPL-2

please check licenses carefully, otherwise the package will be rejected by 
ftpmasters.

cheers,

G.

Bug#817005: RFS: aseqjoy/0.0.1-1 [ITP]

[Fernando Toledo]

El 06/04/16 a las 05:24, Gianfranco Costamagna escribió:
> control: owner -1 !
> control: tags -1 moreinfo
> 
> Hi, lets review:
> 
> check-all-the-things review:
> Please add some upstream metadata: https://wiki.debian.org/UpstreamMetadata
> 
>
Added! (i'm not sure if need i to add more fields.)

> 
> debian/copyright: please use the same upstream license, and for Debian 
> packaging 
> 
> LGPL-2.1 seems unfeasible anyway (I think I read that LGPL is for libraries)

Fixed. Is possible to have upstream => gpl2 and debian/* => gpl3, true?
> 
> Standards-Version: 3.9.6 --> 3.9.7 now

Fixed.

> 
> please run autoreconf.
> (dh --with autoreconf, and a dependency on control file)
> 

Fixed.

> 
> the other stuff LGTM, but I didn't run lintian and a build yet
> 
> (I'll do when you fix the above)
> 
> cheers,
> 
> G.
> 

Thanks for your review, i just upload to mentors with these fixes.

Saludos!

-- 
Fernando Toledo
Dock Sud BBS
http://bbs.docksud.com.ar
telnet://bbs.docksud.com.ar

Bug#817005: RFS: aseqjoy/0.0.1-1 [ITP]

[Gianfranco Costamagna]

control: owner -1 !
control: tags -1 moreinfo

Hi, lets review:

check-all-the-things review:
Please add some upstream metadata: https://wiki.debian.org/UpstreamMetadata



debian/copyright: please use the same upstream license, and for Debian 
packaging 

LGPL-2.1 seems unfeasible anyway (I think I read that LGPL is for libraries)

Standards-Version: 3.9.6 --> 3.9.7 now

please run autoreconf.
(dh --with autoreconf, and a dependency on control file)


the other stuff LGTM, but I didn't run lintian and a build yet

(I'll do when you fix the above)

cheers,

G.


Il Lunedì 7 Marzo 2016 2:30, Fernando Toledo  ha 
scritto:
Package: sponsorship-requests
Severity: normal

  Dear mentors,

  I am looking for a sponsor for my package "aseqjoy"

* Package name: aseqjoy
   Version : 0.0.1-1
   Upstream Author : Alexander Koenig 
* URL : https://terminatorx.org/addons
* License : GPL-2
   Section : sound

  It builds those binary packages:

aseqjoy- Joystick to ALSA MIDI Sequencer Converter

  To access further information about this package, please visit the
following URL:

  http://mentors.debian.net/package/aseqjoy


  Alternatively, one can download the package with dget using this command:

dget -x
http://mentors.debian.net/debian/pool/main/a/aseqjoy/aseqjoy_0.0.1-1.dsc

  More information about aseqjoy can be obtained from
https://terminatorx.org/addons

  Changes since the last upload:

  fixes lintian warnings and try to hardening


thanks!

-- 
Fernando Toledo
Dock Sud BBS
http://bbs.docksud.com.ar
telnet://bbs.docksud.com.ar

Bug#817005: RFS: aseqjoy/0.0.1-1 [ITP]

[Fernando Toledo]

Package: sponsorship-requests
Severity: normal

  Dear mentors,

  I am looking for a sponsor for my package "aseqjoy"

 * Package name: aseqjoy
   Version : 0.0.1-1
   Upstream Author : Alexander Koenig 
 * URL : https://terminatorx.org/addons
 * License : GPL-2
   Section : sound

  It builds those binary packages:

aseqjoy- Joystick to ALSA MIDI Sequencer Converter

  To access further information about this package, please visit the
following URL:

  http://mentors.debian.net/package/aseqjoy


  Alternatively, one can download the package with dget using this command:

dget -x
http://mentors.debian.net/debian/pool/main/a/aseqjoy/aseqjoy_0.0.1-1.dsc

  More information about aseqjoy can be obtained from
https://terminatorx.org/addons

  Changes since the last upload:

  fixes lintian warnings and try to hardening


thanks!

-- 
Fernando Toledo
Dock Sud BBS
http://bbs.docksud.com.ar
telnet://bbs.docksud.com.ar