Bug#819282: wheezy-pu: package openldap/2.4.31-2+deb7u2

[Adam D. Barratt]

Control: tags -1 + pending

On Tue, 2016-05-03 at 07:31 -0700, Ryan Tandy wrote:
> On Sun, May 01, 2016 at 03:07:38PM -0700, Ryan Tandy wrote:
> >On Sun, May 01, 2016 at 10:27:12PM +0100, Adam D. Barratt wrote:
> >>Any news on the upload?
> >
> >None from me. Awaiting a response from my sponsor (CCed).
> 
> The package has been uploaded now. Thanks, Luca!

Flagged for acceptance.

Regards,

Adam

Bug#819282: wheezy-pu: package openldap/2.4.31-2+deb7u2

[Luca BRUNO]

On Tuesday, May 03, 2016 07:31:29 AM Ryan Tandy wrote:
> On Sun, May 01, 2016 at 03:07:38PM -0700, Ryan Tandy wrote:
> >On Sun, May 01, 2016 at 10:27:12PM +0100, Adam D. Barratt wrote:
> >>Any news on the upload?
> >
> >None from me. Awaiting a response from my sponsor (CCed).
> 
> The package has been uploaded now. Thanks, Luca!

This was sitting in my pending queue for some time, sorry for the delay :(

Ciao, Luca

-- 
 .''`.  ** Debian GNU/Linux **  | Luca Bruno (kaeso)
: :'  :   The Universal O.S.| lucab (AT) debian.org
`. `'`  | GPG: 0xBB1A3A854F3BBEBF
  `- http://www.debian.org  | Debian GNU/Linux Developer


signature.asc
Description: This is a digitally signed message part.

Bug#819282: wheezy-pu: package openldap/2.4.31-2+deb7u2

[Ryan Tandy]

On Sun, May 01, 2016 at 03:07:38PM -0700, Ryan Tandy wrote:

On Sun, May 01, 2016 at 10:27:12PM +0100, Adam D. Barratt wrote:

Any news on the upload?


None from me. Awaiting a response from my sponsor (CCed).


The package has been uploaded now. Thanks, Luca!

Bug#819282: wheezy-pu: package openldap/2.4.31-2+deb7u2

[Ryan Tandy]

On Sun, May 01, 2016 at 10:27:12PM +0100, Adam D. Barratt wrote:

Any news on the upload?


None from me. Awaiting a response from my sponsor (CCed).

Bug#819282: wheezy-pu: package openldap/2.4.31-2+deb7u2

[Adam D. Barratt]

On Sun, 2016-04-17 at 21:49 +0100, Adam D. Barratt wrote:
> Control: tags -1 -moreinfo +confirmed
> 
> On Sun, 2016-04-17 at 13:22 -0700, Ryan Tandy wrote:
> > On Wed, Apr 13, 2016 at 09:30:13PM +0100, Adam D. Barratt wrote:
> > >Does a significant portion of the testsuite fail, or only a small part?
> > 
> > Exactly one third of it: the same suite is run once for each of the 
> > backends built, namely bdb, hdb, and mdb. The page size issue renders mdb 
> > totally non-functional under the newer kernel.
> > 
> > >If the latter, is it possible to only disable the affected tests?
> > 
> > Actually, yes. Improved debdiff below; and sorry for not thinking of this 
> > myself.
> 
> Thanks; that looks fine to me.

Any news on the upload?

Regards,

Adam

Bug#819282: wheezy-pu: package openldap/2.4.31-2+deb7u2

[Adam D. Barratt]

Control: tags -1 -moreinfo +confirmed

On Sun, 2016-04-17 at 13:22 -0700, Ryan Tandy wrote:
> On Wed, Apr 13, 2016 at 09:30:13PM +0100, Adam D. Barratt wrote:
> >Does a significant portion of the testsuite fail, or only a small part?
> 
> Exactly one third of it: the same suite is run once for each of the backends 
> built, namely bdb, hdb, and mdb. The page size issue renders mdb totally 
> non-functional under the newer kernel.
> 
> >If the latter, is it possible to only disable the affected tests?
> 
> Actually, yes. Improved debdiff below; and sorry for not thinking of this 
> myself.

Thanks; that looks fine to me.

Regards,

Adam

Bug#819282: wheezy-pu: package openldap/2.4.31-2+deb7u2

[Ryan Tandy]

On Wed, Apr 13, 2016 at 09:30:13PM +0100, Adam D. Barratt wrote:

Does a significant portion of the testsuite fail, or only a small part?


Exactly one third of it: the same suite is run once for each of the backends 
built, namely bdb, hdb, and mdb. The page size issue renders mdb totally 
non-functional under the newer kernel.


If the latter, is it possible to only disable the affected tests?


Actually, yes. Improved debdiff below; and sorry for not thinking of this 
myself.

(The diff doesn't have as much context as I'd like: the debian/rules addition 
is just appended to the end of the file.)

As before:
- built locally on amd64, verified all three test suites were run
- built on the powerpc porterbox (partch), verified bdb and hdb test suites 
were run but not mdb
- tested amd64 binaries in a clean wheezy chroot
- tested powerpc binaries in a qemu VM running wheezy (all backends)

thanks,
Ryan
diff -u openldap-2.4.31/debian/rules openldap-2.4.31/debian/rules
--- openldap-2.4.31/debian/rules
+++ openldap-2.4.31/debian/rules
@@ -174,0 +175,6 @@
+
+# Avoid running back-mdb tests on ppc64 builders
+ifeq ($(DEB_HOST_ARCH),powerpc)
+override_dh_auto_test:
+   dh_auto_test -- BUILD_MDB=no
+endif
diff -u openldap-2.4.31/debian/changelog openldap-2.4.31/debian/changelog
--- openldap-2.4.31/debian/changelog
+++ openldap-2.4.31/debian/changelog
@@ -1,3 +1,11 @@
+openldap (2.4.31-2+deb7u2) wheezy; urgency=medium
+
+  * Disable the back-mdb test suite on powerpc to work around back-mdb tests
+failing on buildds running the jessie ppc64 kernel, which uses 64KB pages.
+(ITS#7713)
+
+ -- Ryan Tandy   Thu, 14 Apr 2016 20:55:33 -0700
+
 openldap (2.4.31-2+deb7u1) wheezy-security; urgency=high
 
   * Non-maintainer upload by the Security Team.

Bug#819282: wheezy-pu: package openldap/2.4.31-2+deb7u2

[Adam D. Barratt]

Control: tags -1 + moreinfo

On Fri, 2016-03-25 at 18:25 -0700, Ryan Tandy wrote:
> The last update of openldap in wheezy-security has never built on 
> powerpc. I got access to the porterbox and found that the ppc64 kernel 
> in jessie (presumably the buildds run the same kernel) uses a 64KB page 
> size, while the MDB backend in wheezy only works with 4KB pages.
> 
> This limitation has been resolved [ITS#7713] in jessie, but the changes 
> are not trivial to backport, and I'm very concerned about regressing all 
> arches if I were to make a mistake. Therefore I'm proposing that we 
> disable the test suite on powerpc so that the package can build.

Does a significant portion of the testsuite fail, or only a small part?
If the latter, is it possible to only disable the affected tests?

Regards,

Adam

Bug#819282: wheezy-pu: package openldap/2.4.31-2+deb7u2

[Ryan Tandy]

Package: release.debian.org
Severity: normal
Tags: wheezy
User: release.debian@packages.debian.org
Usertags: pu

Hi debian-release,

The last update of openldap in wheezy-security has never built on 
powerpc. I got access to the porterbox and found that the ppc64 kernel 
in jessie (presumably the buildds run the same kernel) uses a 64KB page 
size, while the MDB backend in wheezy only works with 4KB pages.

This limitation has been resolved [ITS#7713] in jessie, but the changes 
are not trivial to backport, and I'm very concerned about regressing all 
arches if I were to make a mistake. Therefore I'm proposing that we 
disable the test suite on powerpc so that the package can build.

I have built the proposed package on wheezy under qemu-system-ppc and 
run the entire test suite to ensure it passes. I also built it on the 
powerpc porterbox, installed the binaries on the qemu VM, and performed 
some additional manual testing. Of course I've also done my usual 
pre-upload testing (on amd64, in a clean wheezy chroot).

Would you consider allowing this change into wheezy?

[ITS#7713]: http://www.openldap.org/its/?findid=7713

-- System Information:
Debian Release: 8.3
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'proposed-updates'), (500, 
'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.3.0-0.bpo.1-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
diff -u openldap-2.4.31/debian/rules openldap-2.4.31/debian/rules
--- openldap-2.4.31/debian/rules
+++ openldap-2.4.31/debian/rules
@@ -7,6 +7,12 @@
 export DEB_CFLAGS_MAINT_APPEND := -Wall -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE
 export DEB_BUILD_MAINT_OPTIONS := hardening=+pie,+bindnow
 
+# Avoid running back-mdb tests on ppc64 builders
+DEB_HOST_ARCH ?= $(shell dpkg-architecture -qDEB_HOST_ARCH)
+ifeq ($(DEB_HOST_ARCH),powerpc)
+	export DEB_BUILD_OPTIONS += nocheck
+endif
+
 # Workaround for bad glibc behavior when resolving localhost
 export RESOLV_MULTI = off
 
diff -u openldap-2.4.31/debian/changelog openldap-2.4.31/debian/changelog
--- openldap-2.4.31/debian/changelog
+++ openldap-2.4.31/debian/changelog
@@ -1,3 +1,10 @@
+openldap (2.4.31-2+deb7u2) wheezy; urgency=medium
+
+  * Disable the test suite on powerpc to work around back-mdb tests failing on 
+buildds running the jessie ppc64 kernel, which uses 64KB pages. (ITS#7713)
+
+ -- Ryan Tandy   Fri, 25 Mar 2016 11:45:18 -0700
+
 openldap (2.4.31-2+deb7u1) wheezy-security; urgency=high
 
   * Non-maintainer upload by the Security Team.