Bug#819460: lintian: duplicate-updaterc.d-calls-in-postinst false positive
Hi Richard, > FYI, I also had to silence a duplicate-updaterc.d-calls-in-postinst > false positive in ddclient. The two calls to update-rc.d are in the two > branches of an 'if' statement, so it is not actually called twice. > > See lines 139 and 149 of: > https://salsa.debian.org/debian/ddclient/-/blob/debian/3.9.1-2/debian/postinst#L139 > > Commit that disabled the lintian check: > https://salsa.debian.org/debian/ddclient/-/commit/b65a60e072334f0cee52b41ed4b254bce0d02bad Glancing at this quickly, we now have: update-rc.d ddclient defaults >/dev/null invoke-rc.d ddclient start || exit 1 … yet we should be skipping the first due to: next unless /^(?:.+;|^\s*system[\s\(\']+)?\s*update-rc\.d\s+ So maybe we can fix this one. Can't immediately see why this is not working. Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org chris-lamb.co.uk `-
Bug#819460: lintian: duplicate-updaterc.d-calls-in-postinst false positive
FYI, I also had to silence a duplicate-updaterc.d-calls-in-postinst false positive in ddclient. The two calls to update-rc.d are in the two branches of an 'if' statement, so it is not actually called twice. See lines 139 and 149 of: https://salsa.debian.org/debian/ddclient/-/blob/debian/3.9.1-2/debian/postinst#L139 Commit that disabled the lintian check: https://salsa.debian.org/debian/ddclient/-/commit/b65a60e072334f0cee52b41ed4b254bce0d02bad
Bug#819460: lintian: duplicate-updaterc.d-calls-in-postinst false positive
tags 819460 + moreinfo thanks Chris Lamb wrote: > > lintian: duplicate-updaterc.d-calls-in-postinst false positive > > Thank you for your bug report. I'm struggling to think how Lintian > might avoid this kind of false positive; looking at other packages > that override this tag there is no consistent pattern that I can see. > > Thus, the resolution here might simply be "please override" - you > clearly know what you are doing here. :) Gentle ping on this? :) Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `-
Bug#819460: lintian: duplicate-updaterc.d-calls-in-postinst false positive
Hi Stefan, > lintian: duplicate-updaterc.d-calls-in-postinst false positive Thank you for your bug report. I'm struggling to think how Lintian might avoid this kind of false positive; looking at other packages that override this tag there is no consistent pattern that I can see. Thus, the resolution here might simply be "please override" - you clearly know what you are doing here. :) Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `-
Bug#819460: lintian: duplicate-updaterc.d-calls-in-postinst false positive
Package: lintian Version: 2.5.42.1 Severity: normal I have a package that ships an init script that is by default disabled but may be enabled during update depending on the system configuration. This requires one 'update-rc.d defaults' to add the symlinks and possibly another 'update-rc.d enable' call to enable the service. Lintian complains to this with duplicate-updaterc.d-calls-in-postinst. Source of the postinst is at http://anonscm.debian.org/cgit/pkg-apache/apache2.git/diff/debian/apache2.postinst?id=c77bac3538cca116d4d31d0f085f7bf00e4f3705 -- System Information: Debian Release: stretch/sid APT prefers unstable APT policy: (500, 'unstable'), (1, 'experimental') Architecture: amd64 (x86_64) Foreign Architectures: armhf Kernel: Linux 4.4.0-1-amd64 (SMP w/8 CPU cores) Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) Versions of packages lintian depends on: ii binutils 2.26-8 ii bzip2 1.0.6-8 ii diffstat 1.61-1 ii file 1:5.25-2 ii gettext 0.19.7-2 ii hardening-includes2.8+nmu2 ii intltool-debian 0.35.0+20060710.4 ii libapt-pkg-perl 0.1.29+b5 ii libarchive-zip-perl 1.56-2 ii libclass-accessor-perl0.34-1 ii libclone-perl 0.38-1+b1 ii libdata-alias-perl1.20-1+b1 ii libdpkg-perl 1.18.4 ii libemail-valid-perl 1.198-1 ii libfile-basedir-perl 0.07-1 ii libipc-run-perl 0.94-1 ii liblist-moreutils-perl0.413-1+b1 ii libparse-debianchangelog-perl 1.2.0-8 ii libperl5.22 [libdigest-sha-perl] 5.22.1-9 ii libtext-levenshtein-perl 0.13-1 ii libtimedate-perl 2.3000-2 ii liburi-perl 1.71-1 ii libyaml-libyaml-perl 0.41-6+b1 ii man-db2.7.5-1 ii patchutils0.3.4-1 ii perl 5.22.1-9 ii t1utils 1.39-2 ii xz-utils 5.1.1alpha+20120614-2.1 Versions of packages lintian recommends: ii dpkg 1.18.4 ii libautodie-perl 2.29-2 ii libperlio-gzip-perl 0.19-1+b1 ii perl 5.22.1-9 ii perl-modules-5.22 [libautodie-perl] 5.22.1-9 Versions of packages lintian suggests: pn binutils-multiarch ii dpkg-dev 1.18.4 ii libhtml-parser-perl3.72-1 ii libtext-template-perl 1.46-1 -- no debconf information
