Bug#821397: sway 1.0-rc1

2019-02-13 Thread Birger Schacht
hi On 2/9/19 7:25 PM, Birger Schacht wrote: >>> There are new lintian warnings: >>> >>> I: sway: file-references-package-build-path usr/bin/sway >>> [...] >>> I think this refers to the occurrence of strings like: >>> ../sway/commands/exec.c >>> in the binaries. This is a relative path and the lin

Bug#821397: sway 1.0-rc1

2019-02-10 Thread Sean Whitton
Hello, On Sun 10 Feb 2019 at 09:51AM +01, Birger Schacht wrote: > On 2/9/19 9:21 PM, Sean Whitton wrote: >> Birger, could you add a comment in d/control, saying that the versioned >> dependency is just a workaround to help users of Debian experimental >> avoid a broken window manager, and in the

Bug#821397: sway 1.0-rc1

2019-02-10 Thread Mattia Rizzolo
On Sat, Feb 09, 2019 at 05:15:02PM -0700, Sean Whitton wrote: > I don't think we should allow problems with wlroots in experimental to > block getting sway through NEW and into experimental, although we'd want > to hold off moving sway to unstable until the wlroots situation is > resolved. So, I s

Bug#821397: sway 1.0-rc1

2019-02-10 Thread Birger Schacht
Hi, On 2/9/19 10:12 PM, Mattia Rizzolo wrote: > On Sat, Feb 09, 2019 at 09:30:43PM +0100, Mattia Rizzolo wrote: >> I'm thinking, it means 0.3-1 broke over 0.2-1, and that is a bug that >> I'd be filing as serious if I found it myself. >> Happy to properly check, since this is a simple library I sh

Bug#821397: sway 1.0-rc1

2019-02-10 Thread Birger Schacht
Hi, On 2/9/19 9:21 PM, Sean Whitton wrote: > Birger, could you add a comment in d/control, saying that the versioned > dependency is just a workaround to help users of Debian experimental > avoid a broken window manager, and in the future it will be removed in > favour of relying on dpkg-shlibdeps

Bug#821397: sway 1.0-rc1

2019-02-09 Thread Sean Whitton
Hello Berger, Mattia, On Sat 09 Feb 2019 at 09:30PM +01, Mattia Rizzolo wrote: > On Sat, Feb 09, 2019 at 01:21:36PM -0700, Sean Whitton wrote: >> wlroots is only in experimental and is pre-1.0, however. So we probably >> shouldn't demand proper transitions from its maintainers. > > This is not a

Bug#821397: sway 1.0-rc1

2019-02-09 Thread Mattia Rizzolo
On Sat, Feb 09, 2019 at 09:30:43PM +0100, Mattia Rizzolo wrote: > I'm thinking, it means 0.3-1 broke over 0.2-1, and that is a bug that > I'd be filing as serious if I found it myself. > Happy to properly check, since this is a simple library I should find > the time for this. Looking, this looked

Bug#821397: sway 1.0-rc1

2019-02-09 Thread Birger Schacht
Hi, On 2/9/19 8:55 PM, Sean Whitton wrote: > Hello Birger, > > On Sat 09 Feb 2019 at 07:25PM +01, Birger Schacht wrote: > * Make versioned run dependency on libwlroots0 explicit >>> >>> Please explain (either in the changelog or with a comment in d/control) >>> why this is needed -- it's

Bug#821397: sway 1.0-rc1

2019-02-09 Thread Mattia Rizzolo
On Sat, Feb 09, 2019 at 01:21:36PM -0700, Sean Whitton wrote: > wlroots is only in experimental and is pre-1.0, however. So we probably > shouldn't demand proper transitions from its maintainers. This is not about transitions though. It's about being sure wlroots maintainer know what it means to

Bug#821397: sway 1.0-rc1

2019-02-09 Thread Sean Whitton
Hello, On Sat 09 Feb 2019 at 09:07PM +01, Mattia Rizzolo wrote: > Then it's a bug in libwlroots, that did not bump shlibs when adding > symbols, or it has a broken .symbols file. > And it's a quite serious one at that, if it's really that, showcasing > why maintaining shared libraries is not an e

Bug#821397: sway 1.0-rc1

2019-02-09 Thread Mattia Rizzolo
On Sat, Feb 09, 2019 at 12:55:50PM -0700, Sean Whitton wrote: > Hello Birger, > > On Sat 09 Feb 2019 at 07:25PM +01, Birger Schacht wrote: > > >>> * Make versioned run dependency on libwlroots0 explicit > >> > >> Please explain (either in the changelog or with a comment in d/control) > >> why t

Bug#821397: sway 1.0-rc1

2019-02-09 Thread Sean Whitton
Hello Birger, On Sat 09 Feb 2019 at 07:25PM +01, Birger Schacht wrote: >>> * Make versioned run dependency on libwlroots0 explicit >> >> Please explain (either in the changelog or with a comment in d/control) >> why this is needed -- it's unusual not to be able to rely on >> dpkg-shlibdeps doin

Bug#821397: sway 1.0-rc1

2019-02-09 Thread Birger Schacht
Hi, thanks for the detailed review, that was very helpful! On 2/9/19 6:50 PM, Sean Whitton wrote: >> Changes since beta2: >> * New upstream release >> * Remove swaylock and swayidle: they are now separate packages >> * Clean up d/sway.install > > "Cleaning up" suggests only deleting lines,

Bug#821397: sway 1.0-rc1

2019-02-09 Thread Sean Whitton
Hello Birger, On Sat 09 Feb 2019 at 01:42PM +01, Birger Schacht wrote: > i've updated the package to 1.0-rc1 and pushed to the git repo. Thank you for working on this! For my own reference: this e-mail reviews edcdf846db12a6dc7495caea02bad2faa30586fb. > Changes since beta2: > * New upstream

Bug#821397: sway 1.0-rc1

2019-02-09 Thread Birger Schacht
hi, On 2/6/19 1:09 AM, Sean Whitton wrote: > Hello Birger, > > There is a new release of sway out, and it moves swayidle and swaylock > into separate source packages. > > Those are all going to have to pass through NEW. Do you have time to > prepare separate source packages for all these? We m

Bug#821397: sway 1.0-rc1

2019-02-05 Thread Birger Schacht
Hi! On 2/6/19 1:11 AM, Sean Whitton wrote: > Hello, > > On Tue 05 Feb 2019 at 05:09PM -07, Sean Whitton wrote: > >> There is a new release of sway out, and it moves swayidle and swaylock >> into separate source packages. >> >> Those are all going to have to pass through NEW. Do you have time to

Bug#821397: sway 1.0-rc1

2019-02-05 Thread Sean Whitton
Hello, On Tue 05 Feb 2019 at 05:09PM -07, Sean Whitton wrote: > There is a new release of sway out, and it moves swayidle and swaylock > into separate source packages. > > Those are all going to have to pass through NEW. Do you have time to > prepare separate source packages for all these? We m

Bug#821397: sway 1.0-rc1

2019-02-05 Thread Sean Whitton
Hello Birger, There is a new release of sway out, and it moves swayidle and swaylock into separate source packages. Those are all going to have to pass through NEW. Do you have time to prepare separate source packages for all these? We might as well do it now rather than later. -- Sean Whitto