Bug#824611: Nagstamon bug

2016-05-19 Thread Dmitry Shachnev
Control: reassign -1 nagstamon 1.0.1-1

Hi Florian,

On Wed, May 18, 2016 at 04:13:46PM +0200, Florian Bruhin wrote:
> This is actually a bug in Nagstamon, discovered by PyQt getting
> stricter about correct @pyqtSlot signatures.

Thanks for tracking down this issue, I am reassigning the bug accordingly.

--
Dmitry Shachnev


signature.asc
Description: PGP signature


Bug#824611: Nagstamon bug

2016-05-18 Thread Florian Bruhin
This is actually a bug in Nagstamon, discovered by PyQt getting
stricter about correct @pyqtSlot signatures.

I'm guessing you don't see this with other platforms because you're
running Qt 5.6 but not PyQt 5.6 there, which is where this behaviour
was added:

https://www.riverbankcomputing.com/static/Downloads/PyQt5/ChangeLog
(d58baf1a1473, "Connecting to a decorated method will now fail without
a compatible signature.")

Nagstamon has a slot decorated with @pyqtSlot(str, bool) and connects
it to a str/QString signal:

https://github.com/HenriWahl/Nagstamon/blob/master/Nagstamon/QUI/__init__.py#L3925
https://github.com/HenriWahl/Nagstamon/blob/master/Nagstamon/QUI/__init__.py#L3904-L3905

This was silently ignored in PyQt < 5.6 and is an error with 5.6.

Nagstamon's authors should add a @pyqtSlot(str) decoration to that
slot and also fix other slots with the same issue as necessary.

Florian

-- 
http://www.the-compiler.org | m...@the-compiler.org (Mail/XMPP)
   GPG: 916E B0C8 FD55 A072 | http://the-compiler.org/pubkey.asc
 I love long mails! | http://email.is-not-s.ms/


signature.asc
Description: Digital signature