Bug#830750: photofloat: traceback on run

[Antoine Beaupré]

Control: severity -1 grave

On 2016-07-11 00:38:38, Mark Eichin wrote:
> (It looks like that's followed by release discussion, but just thought
> I'd still add the "doesn't work out of the box" data point.)

Right - PhotoFloat is in pretty bad shape, both in and outside
Debian. There has been only two commits in 2016 and very little activity
in the last 5 years. Patches on the mailing list have been constantly
dropped to the floor, and this one is no exception.

As a Debian maintainer, I have tried to merge some of those patches,
effectively making the Debian package a fork of the upstream package -
but at this point I am questioning that approach. If I make a fork, I
will make a proper one, outside of Debian with contributors and activity
and everything.

I am not sure I have the energy right now, unfortunately. Friends have
moved on to Owncloud for hosting their pictures, and I am more than
hesitant in trying out the new "float app" that Jason wrote for
PhotoFloat myself which is supposed to answer some use cases
(authentication) yet doesn't address patches that have been lying around
the mailing lists for ever (e.g. video support).

TL;DR: I would be very happy to update the Debian package to follow an
up-to-date and functional fork somewhere.

A.

-- 
One of the things the Web teaches us is that everything is connected
(hyperlinks) and we all should work together (standards). Too often
school teaches us that everything is separate (many different
'subjects') and that we should all work alone.  - Aaron Swartz

Bug#830750: photofloat: traceback on run

[Mark Eichin]

Package: photofloat
Version: 0~20120917+dfsg-3
Severity: normal

Tried a run based on the instructions in /usr/share/doc/photofloat/README.Debian

$ mkdir photo
$ cd photo
$ mkdir albums cache
$ ln -s /usr/share/photofloat/web/* .
$ mkdir albums/flickr
$ ln $(kpa-grep --tag flickr) albums/flickr/
$ photofloat albums cache

2016-07-10T20:36:15.950083   |  |--[thumbing]  img_418-0601.jpg -> 1024px
2016-07-10T20:36:16.907571   |--[caching]   flickr
Traceback (most recent call last):
  File "/usr/bin/photofloat", line 21, in 
main()
  File "/usr/bin/photofloat", line 15, in main
TreeWalker(sys.argv[1], sys.argv[2])
  File "/usr/share/photofloat/scanner/TreeWalker.py", line 16, in __init__
self.walk(self.album_path)
  File "/usr/share/photofloat/scanner/TreeWalker.py", line 55, in walk
album.add_album(self.walk(entry))
  File "/usr/share/photofloat/scanner/TreeWalker.py", line 76, in walk
album.cache(self.cache_path)
  File "/usr/share/photofloat/scanner/PhotoAlbum.py", line 68, in cache
self._sort()
  File "/usr/share/photofloat/scanner/PhotoAlbum.py", line 51, in _sort
self._photos.sort()
  File "/usr/share/photofloat/scanner/PhotoAlbum.py", line 318, in __cmp__
date_compare = cmp(self.date, other.date)
TypeError: can't compare datetime.datetime to unicode

Running it again is faster (presumably it's not regenerating the cached
thumbnails, though it still prints all of the names) and ends with the
same traceback.

This appears to have been mentioned, but not responded to, elsewhere:
https://lists.zx2c4.com/pipermail/photofloat/2013-November/28.html
https://lists.zx2c4.com/pipermail/photofloat/2014-January/29.html

with a possible patch:
https://lists.zx2c4.com/pipermail/photofloat/2014-February/42.html
http://lists.zx2c4.com/pipermail/photofloat/attachments/20140207/f14817be/attachment.patch

(It looks like that's followed by release discussion, but just thought
I'd still add the "doesn't work out of the box" data point.)

-- System Information:
Debian Release: 8.5
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.16.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL 
set to en_US.UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)

Versions of packages photofloat depends on:
ii  lmodern 2.004.4-5
ii  python-imaging  2.6.1-2+deb8u2
ii  python  2.7.9-1

Versions of packages photofloat recommends:
ii  libjs-jquery 1.7.2+dfsg-3.2
ii  libjs-jquery-mousewheel  10-1

Versions of packages photofloat suggests:
pn  libapache2-mod-php5 | php5-fpm | php5-cgi  
ii  nginx-light [nginx]1.6.2-5+deb8u2+b1

-- no debconf information