Bug#836903: RFS: qevercloud/3.0.2+ds-1 [ITP] -- Unofficial Evernote Cloud API library for Qt

2016-10-13 Thread Sean Whitton
control: tag -1 + confirmed - moreinfo control: noowner -1 Hello, I'm going away for the weekend, so I'm marking this as confirmed as the only remaining issue is extremely minor (see below). I think that commit 240db346c4abfd3d6ccb1c9db36c7880db289f6a is ready for upload to Debian, though it

Bug#836903: RFS: qevercloud/3.0.2+ds-1 [ITP] -- Unofficial Evernote Cloud API library for Qt

2016-10-13 Thread Boyuan Yang
Hello Sean, 2016-10-12 21:49 GMT+08:00 Sean Whitton : > I suggest: > > 1) override the jquery warning, with a comment pointing to README.jquery > (there is a special format for lintian override comments) I am not quite sure about what the special format for lintian

Bug#836903: RFS: qevercloud/3.0.2+ds-1 [ITP] -- Unofficial Evernote Cloud API library for Qt

2016-10-12 Thread Sean Whitton
Hello Boyuan, On Wed, Oct 12, 2016 at 11:03:43AM +0800, Boyuan Yang wrote: > 2016-10-12 10:43 GMT+08:00 Sean Whitton : > > Have you read /usr/share/doc/doxygen/README.jquery? > > > > I think you shouldn't be symlinking jquery. > > Wow, I did not read it before since I

Bug#836903: RFS: qevercloud/3.0.2+ds-1 [ITP] -- Unofficial Evernote Cloud API library for Qt

2016-10-11 Thread Boyuan Yang
Hello Sean, 2016-10-12 10:43 GMT+08:00 Sean Whitton : > Hello Boyuan, > > Have you read /usr/share/doc/doxygen/README.jquery? > > I think you shouldn't be symlinking jquery. Wow, I did not read it before since I trusted lintian :p Looks like it is kind of disagreement

Bug#836903: RFS: qevercloud/3.0.2+ds-1 [ITP] -- Unofficial Evernote Cloud API library for Qt

2016-10-11 Thread Sean Whitton
Hello Boyuan, On Tue, Oct 11, 2016 at 07:43:18PM -0700, Sean Whitton wrote: > Have you read /usr/share/doc/doxygen/README.jquery? > > I think you shouldn't be symlinking jquery. It would probably be good to use dh_oxygen, too. -- Sean Whitton signature.asc Description: PGP signature

Bug#836903: RFS: qevercloud/3.0.2+ds-1 [ITP] -- Unofficial Evernote Cloud API library for Qt

2016-10-11 Thread Sean Whitton
Hello Boyuan, Have you read /usr/share/doc/doxygen/README.jquery? I think you shouldn't be symlinking jquery. On Sun, Oct 09, 2016 at 07:19:43PM +0800, Boyuan Yang wrote: > I made a small investigation on my own Debian testing. doing > `file /usr/lib/x86_64-linux-gnu/*.so` would return some

Bug#836903: RFS: qevercloud/3.0.2+ds-1 [ITP] -- Unofficial Evernote Cloud API library for Qt

2016-10-09 Thread Boyuan Yang
Hello Sean, 2016-10-09 8:36 GMT+08:00 Sean Whitton : > Hello Boyuan, > >> Added a patch to disable the instructions about PDFs in Doxyfile. > > Upstream has made a new release 3.0.3 incorporating a fix o/ > > Could you try building the docs with this new release, please?

Bug#836903: RFS: qevercloud/3.0.2+ds-1 [ITP] -- Unofficial Evernote Cloud API library for Qt

2016-10-08 Thread Sean Whitton
Hello Boyuan, On Fri, Oct 07, 2016 at 02:42:05PM +0800, Boyuan Yang wrote: > Sorry for being late. I was having a holiday and turned to something else > in the past few days :p No worries -- so long as we don't miss the stretch freeze! > > 1. You dropped --parallel from d/rules without

Bug#836903: RFS: qevercloud/3.0.2+ds-1 [ITP] -- Unofficial Evernote Cloud API library for Qt

2016-10-07 Thread Boyuan Yang
Hello Sean, Sorry for being late. I was having a holiday and turned to something else in the past few days :p 2016-09-22 10:33 GMT+08:00 Sean Whitton : > Hello Boyuan, > > A few new things: > > 1. You dropped --parallel from d/rules without explaining why in the commit

Bug#836903: RFS: qevercloud/3.0.2+ds-1 [ITP] -- Unofficial Evernote Cloud API library for Qt

2016-09-24 Thread Sean Whitton
Hello Boyuan, One more thing -- the .so should be installed as libqt?evercloud.so.3.0.0, with a symlink from libqt?evercloud.so.3. See ch. 8 of Debian policy for an explanation of this practice. Thanks! -- Sean Whitton signature.asc Description: PGP signature

Bug#836903: RFS: qevercloud/3.0.2+ds-1 [ITP] -- Unofficial Evernote Cloud API library for Qt

2016-09-21 Thread Sean Whitton
Hello Boyuan, A few new things: 1. You dropped --parallel from d/rules without explaining why in the commit message. Does it break the build? Certainly not essential, but it's nice to enable it since our buildds are so overworked. 2. Some grammatical errors in package descriptions:

Bug#836903: RFS: qevercloud/3.0.2+ds-1 [ITP] -- Unofficial Evernote Cloud API library for Qt

2016-09-20 Thread Boyuan Yang
Hello, 2016-09-17 22:31 GMT+08:00 Sean Whitton : > The packaging is in great shape. Here's a review for you. [...] FYI, I made a small update after last update, which is to fix the d/control file to raise the debhelper dependency from 9 to 10. The GitHub repository

Bug#836903: RFS: qevercloud/3.0.2+ds-1 [ITP] -- Unofficial Evernote Cloud API library for Qt

2016-09-18 Thread Boyuan Yang
Hello, 2016-09-17 22:31 GMT+08:00 Sean Whitton : > Hello Boyuan, > > On Wed, Sep 14, 2016 at 12:23:48PM +0800, Boyuan Yang wrote: >> Yes, they are up-to-date now. The package on debian-mentors is also >> updated. > > The packaging is in great shape. Here's a review for

Bug#836903: RFS: qevercloud/3.0.2+ds-1 [ITP] -- Unofficial Evernote Cloud API library for Qt

2016-09-17 Thread Sean Whitton
Hello Boyuan, On Wed, Sep 14, 2016 at 12:23:48PM +0800, Boyuan Yang wrote: > Yes, they are up-to-date now. The package on debian-mentors is also > updated. The packaging is in great shape. Here's a review for you. Must-fixes: --- 1. The changelog entry won't close the ITP unless you

Bug#836903: RFS: qevercloud/3.0.2+ds-1 [ITP] -- Unofficial Evernote Cloud API library for Qt

2016-09-15 Thread Sean Whitton
Hello Boyuan, On Wed, Sep 14, 2016 at 12:23:48PM +0800, Boyuan Yang wrote: > Yes, they are up-to-date now. The package on debian-mentors is also > updated. Thanks. I'll get to this by Saturday at the latest. -- Sean Whitton signature.asc Description: PGP signature

Bug#836903: RFS: qevercloud/3.0.2+ds-1 [ITP] -- Unofficial Evernote Cloud API library for Qt

2016-09-13 Thread Boyuan Yang
Hello, 2016-09-12 21:34 GMT+08:00 Sean Whitton : > Dear Boyuan, > > On Sun, Sep 11, 2016 at 08:48:15AM +0800, Boyuan Yang wrote: >> > - status of lemon parser currently unclear >> >> This is fixed in the RFS of qevercloud before already. Of course we are >> using the

Bug#836903: RFS: qevercloud/3.0.2+ds-1 [ITP] -- Unofficial Evernote Cloud API library for Qt

2016-09-12 Thread Sean Whitton
Dear Boyuan, On Sun, Sep 11, 2016 at 08:48:15AM +0800, Boyuan Yang wrote: > > - status of lemon parser currently unclear > > This is fixed in the RFS of qevercloud before already. Of course we are > using the lemon parser from Debian. The bundled source code of lemon > is discarded in the source

Bug#836903: RFS: qevercloud/3.0.2+ds-1 [ITP] -- Unofficial Evernote Cloud API library for Qt

2016-09-10 Thread Boyuan Yang
Hi Sean, 2016-09-11 5:46 GMT+08:00 Sean Whitton : > In that GitHub thread, there is mention of a parsing tool called > 'lemon'. Dmitry suggests packaging that separately, but you say it's > not necessary. Could you explain why? Where can I find out about that > tool?

Bug#836903: RFS: qevercloud/3.0.2+ds-1 [ITP] -- Unofficial Evernote Cloud API library for Qt

2016-09-10 Thread Sean Whitton
Dear Boyuan, Dmitry, On Thu, Sep 08, 2016 at 12:52:29PM +0300, Dmitry Ivanov wrote: > I am the upstream developer of QEverCloud library. Sorry for the > interference, I'd just like to clarify a bit what QEverCloudGenerator > is and how it is intended to work. Please don't apologise -- there's a

Bug#836903: RFS: qevercloud/3.0.2+ds-1 [ITP] -- Unofficial Evernote Cloud API library for Qt

2016-09-08 Thread Dmitry Ivanov
Hello, I am the upstream developer of QEverCloud library. Sorry for the interference, I'd just like to clarify a bit what QEverCloudGenerator is and how it is intended to work. Let me start from a brief description of how Thrift IDL - interface definition language - works. It is a

Bug#836903: RFS: qevercloud/3.0.2+ds-1 [ITP] -- Unofficial Evernote Cloud API library for Qt

2016-09-07 Thread Boyuan Yang
2016-09-08 0:52 GMT+08:00 Sean Whitton : > The issue is that then we then have multiple copies of the thrift files > in Debian: a copy in each source package that needs them, either for > regeneration or in debian/missing-sources/. > > Suppose there is an Evernote

Bug#836903: RFS: qevercloud/3.0.2+ds-1 [ITP] -- Unofficial Evernote Cloud API library for Qt

2016-09-07 Thread Sean Whitton
Dear Boyuan, On Thu, Sep 08, 2016 at 12:14:53AM +0800, Boyuan Yang wrote: > > Are there/could there be other libraries that use code generated from > > the Evernote thrift files? For example, bindings for another language > > (python, haskell, perl)? If so, the Evernote thrift files should be

Bug#836903: RFS: qevercloud/3.0.2+ds-1 [ITP] -- Unofficial Evernote Cloud API library for Qt

2016-09-07 Thread Boyuan Yang
Hello, 2016-09-07 23:15 GMT+08:00 Sean Whitton : > control: owner -1 ! > control: tag -1 +moreinfo > > Dear Boyuan, > > Thanks for this! Before I do a proper review let's talk about the > source code/repacking situation. > > Are there/could there be other libraries that

Bug#836903: RFS: qevercloud/3.0.2+ds-1 [ITP] -- Unofficial Evernote Cloud API library for Qt

2016-09-07 Thread Sean Whitton
control: owner -1 ! control: tag -1 +moreinfo Dear Boyuan, Thanks for this! Before I do a proper review let's talk about the source code/repacking situation. Are there/could there be other libraries that use code generated from the Evernote thrift files? For example, bindings for another

Bug#836903: RFS: qevercloud/3.0.2+ds-1 [ITP] -- Unofficial Evernote Cloud API library for Qt

2016-09-06 Thread Boyuan Yang
Package: sponsorship-requests Severity: wishlist Dear mentors, I am looking for a sponsor for my package "qevercloud" * Package name: qevercloud Version : 3.0.2+ds-1 Upstream Author : Dmitry Ivanov * URL :