Bug#846222: [Pkg-xfce-devel] Bug#846222: x11-common: Please provide a default xsession in /usr/share/xsessions

[Yves-Alexis Perez]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On Fri, 2019-01-04 at 12:33 -0300, Maximiliano Curia wrote:
> I can only speak for the sddm's Xsession which is a wrapper arround Debian's 
> /etc/X11/Xsession,

I think if there are improvement to be made, they should go to
/etc/X11/Xsession in order to benefit everyone.

But:
>  what it does is to try to set the corresponding shell 
> environment by loading the user profile files.

Shell environment is enviroment for the shell, not for other stuff.
Especially, .profile is for bash, not for graphical applications.

> The sourced profiles take care of things like adding /usr/games to the PATH, 
> which was loudly asked by our users when the wrapper wasn't present.

If people are missing environment variables on their session, the right way to
do it is to add them to .xsessionrc. See also environment.d(5) for more global
ways.

Also, for LightDM, we updated the code so the default PATH matches Debian
expectations: 
https://sources.debian.org/src/lightdm/1.26.0-3/debian/patches/01_set-default-path.patch/

Regards,
- -- 
Yves-Alexis
-BEGIN PGP SIGNATURE-

iQEzBAEBCAAdFiEE8vi34Qgfo83x35gF3rYcyPpXRFsFAlwvh6gACgkQ3rYcyPpX
RFvjeAf9ENgBnGeVtG7VftFZf97in7z/C0KhwDvtSplTLknozG7liQUUwD9hwL93
bciWX4+9oexIIx10t8KiZyhUeUT9PhV2xsNp689MEEyg6mZY795aZ7zfjMPsEQJz
/yYYra8yvsrdtfe0NgIl//H/NWUrgddvE8ogYi0scZ1fSaUAvKAr78dmPwPBNNQw
p9UMgoymv2mIs2n9G0SZmV+UV96a4xYJ9PV+CtAFkv4Zl3V+qXgT3058lXiD/Wqc
dybOsZ1Zw2q1/i0qZw9SScxTmF7tYRD51hDypuaz0ZwbtCmRJUzIZykkWvhHdcYA
7XMGOWcaozm0PAjaQ5QWfXeDMy/F3g==
=PRpx
-END PGP SIGNATURE-

Bug#846222: [Pkg-xfce-devel] Bug#846222: x11-common: Please provide a default xsession in /usr/share/xsessions

[Maximiliano Curia]

¡Hola Michael!

El 2017-11-06 a las 13:31 +0100, Michael Biebl escribió:

Another issue I noticed:
gdm3 uses /etc/gdm3/Xsession
sddm uses /etc/sddm/Xsession
lightdm uses /etc/X11/Xsession



to start this special default session.



I wonder if there would be potential for unification (i.e. all affected
display managers using the Xsession script from x11-common) or does
someone know why it could be beneficial to keep separate Xsession
scripts per display manager?


I can only speak for the sddm's Xsession which is a wrapper arround Debian's 
/etc/X11/Xsession, what it does is to try to set the corresponding shell 
environment by loading the user profile files.


For example the bash part reads:
   [ -z "$BASH" ] && exec $SHELL $0 "$@"
   set +o posix
   [ -f /etc/profile ] && . /etc/profile
   if [ -f $HOME/.bash_profile ]; then
 . $HOME/.bash_profile
   elif [ -f $HOME/.bash_login ]; then
 . $HOME/.bash_login
   elif [ -f $HOME/.profile ]; then
 . $HOME/.profile
   fi

The sourced profiles take care of things like adding /usr/games to the PATH, 
which was loudly asked by our users when the wrapper wasn't present.


Happy hacking,
--
"Fighting patents one by one will never eliminate the danger of software 
patents, any more than swatting mosquitoes will eliminate malaria."

-- Richard M. Stallman
Saludos /\/\ /\ >< `/


signature.asc
Description: PGP signature

Bug#846222: [Pkg-xfce-devel] Bug#846222: x11-common: Please provide a default xsession in /usr/share/xsessions

[Michael Biebl]

Another issue I noticed:
gdm3 uses /etc/gdm3/Xsession
sddm uses /etc/sddm/Xsession
lightdm uses /etc/X11/Xsession

to start this special default session.

I wonder if there would be potential for unification (i.e. all affected
display managers using the Xsession script from x11-common) or does
someone know why it could be beneficial to keep separate Xsession
scripts per display manager?

Michael


-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?



signature.asc
Description: OpenPGP digital signature

Bug#846222: [Pkg-xfce-devel] Bug#846222: x11-common: Please provide a default xsession in /usr/share/xsessions

[Michael Biebl]

Am 06.11.2017 um 00:32 schrieb Michael Biebl:
> On Tue, 29 Nov 2016 12:07:26 +0100 Yves-Alexis Perez 

>> If other DM have the same behavior as LightDM, I guess it's a good idea
>> indeed, although I'm wondering if it can have side effects.

[..]

> I would prefer though, if that xsession.desktop file is *not* provided
> by x11-common, as some desktop environments might actually choose not
> wanting to have such an entry in the display manager menu, and
> x11-common is not really uninstallable.
> So a separate binary package seems like the most flexible approach to me.
> 
> lightdm's /usr/share/xsessions/lightdm-xsession.desktop file might be a
> good basis for such a package.

Another reason why it might be a good idea to ship that as a package
separate from x11-common is, that as you mentioned, not all display
manager might support that ExecStart=default feature.
Only those that do could decide to add a Recommend or Depends on that
new xsession-default package.

If there is some agreement on this, I could prepare a patch for src:xorg
which adds such a new xsession-default package. I think src:xorg would
be the right source package for building such a package.


Michael


-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?



signature.asc
Description: OpenPGP digital signature

Bug#846222: [Pkg-xfce-devel] Bug#846222: x11-common: Please provide a default xsession in /usr/share/xsessions

[Michael Biebl]

Hi

On Tue, 29 Nov 2016 12:07:26 +0100 Yves-Alexis Perez 
wrote:
> On Tue, 2016-11-29 at 11:52 +0100, Maximiliano Curia wrote:
> > Thanks to the #845948 report against sddm, we noticed that the "Default 
> > Xsession" xsession desktop file is being provided by the lightdm display 
> > manager (in the /usr/share/xsessions/lightdm-xsession.desktop file). And 
> > since: 
> > 
> >  - This xsession file is useful for other display managers, such as sddm, 
> > that
> >    uses the /usr/share/xsessions/*.desktop to allow the users to choose 
> > their
> >    preferred sessions.
> > 
> >  - This ends up calling /etc/X11/Xsession default which is the only way to 
> > use
> >    the user's ~/.xsession file
> > 
> >  - The script that processes the "default" parameter
> >    (/etc/X11/Xsession.d/20x11-common_process-args) as a special case is
> >    provided by the x11-common package.
> > 
> > I believe, it would be better to this file in the x11-common package 
> > (renamed 
> > as
> > /usr/share/xsessions/user-xsession.desktop or 
> > /usr/share/xsessions/default-xsession.desktop).
> 
> If other DM have the same behavior as LightDM, I guess it's a good idea
> indeed, although I'm wondering if it can have side effects.
> 
> In any case, keep me in the loop so I can remove the file from LightDM when
> needed :)

Fwiw, we just discussed today to drop
/usr/share/gdm/BuiltInSessions/default.desktop from gdm3 as well
(which starts Xsession).

It would be nice if such a xsession.desktop file would be provided by a
common package, which invididual desktop environments can depend on, if
they want. This would have the benefit, that we would have no
duplication in all the different display manager.

I would prefer though, if that xsession.desktop file is *not* provided
by x11-common, as some desktop environments might actually choose not
wanting to have such an entry in the display manager menu, and
x11-common is not really uninstallable.
So a separate binary package seems like the most flexible approach to me.

lightdm's /usr/share/xsessions/lightdm-xsession.desktop file might be a
good basis for such a package.

Regards,
Michael

-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?



signature.asc
Description: OpenPGP digital signature

Bug#846222: [Pkg-xfce-devel] Bug#846222: x11-common: Please provide a default xsession in /usr/share/xsessions

[Yves-Alexis Perez]

On Tue, 2016-11-29 at 11:52 +0100, Maximiliano Curia wrote:
> Hi,
> 
> Thanks to the #845948 report against sddm, we noticed that the "Default 
> Xsession" xsession desktop file is being provided by the lightdm display 
> manager (in the /usr/share/xsessions/lightdm-xsession.desktop file). And 
> since: 
> 
>  - This xsession file is useful for other display managers, such as sddm, that
>    uses the /usr/share/xsessions/*.desktop to allow the users to choose their
>    preferred sessions.
> 
>  - This ends up calling /etc/X11/Xsession default which is the only way to use
>    the user's ~/.xsession file
> 
>  - The script that processes the "default" parameter
>    (/etc/X11/Xsession.d/20x11-common_process-args) as a special case is
>    provided by the x11-common package.
> 
> I believe, it would be better to this file in the x11-common package (renamed 
> as
> /usr/share/xsessions/user-xsession.desktop or 
> /usr/share/xsessions/default-xsession.desktop).

If other DM have the same behavior as LightDM, I guess it's a good idea
indeed, although I'm wondering if it can have side effects.

In any case, keep me in the loop so I can remove the file from LightDM when
needed :)

Regards,
-- 
Yves-Alexis

signature.asc
Description: This is a digitally signed message part