Bug#846312: vim package fails to build with missing man files

[James McCoy]

On Sun, Dec 04, 2016 at 11:07:28PM +, David Barnett wrote:
> Turns out the problem was that I was building with make 3.81, which doesn't
> support the trailing "=" syntax in "define VAR =" (and for some reason 
> silently
> ignores the whole block?).

Thanks for tracking that down!  I didn't realize that was something new
to 3.81.  It's the first time I've used the "define" construct.

> Just deleting that one = sign makes everything work
> for me. Would it be okay to remove that and maintain 3.81 compatibility just a
> little longer?

I'd be perfectly fine with changing that. :)

Cheers,
-- 
James
GPG Key: 4096R/91BF BF4D 6956 BD5D F7B7  2D23 DFE6 91AE 331B A3DB

Bug#846312: vim package fails to build with missing man files

[David Barnett]

Turns out the problem was that I was building with make 3.81, which doesn't
support the trailing "=" syntax in "define VAR =" (and for some reason
silently ignores the whole block?). Just deleting that one = sign makes
everything work for me. Would it be okay to remove that and maintain 3.81
compatibility just a little longer?

BTW, as far as the strange "debian/tmp/debian/tmp" path, my workaround has
nothing to do with the dh_install step that was failing on those paths, so
I believe the path is fishy but unrelated to this particular issue.

David

On Sat, Dec 3, 2016 at 6:17 PM David Barnett 
wrote:

> I did notice the apparent duplication in the path, but I'm not seeing any
> evidence that any commands in a define'd variables like that get executed,
> e.g. if I change them to "echo blah", "/bin/false", or a bunch of
> non-syntactically-valid gibberish.
>
> David
>
> On Fri, Dec 2, 2016 at 7:28 PM James McCoy  wrote:
>
> That implies that $(DESTDIR) is being set to debian/tmp/debian/tmp.
> $(DESTDIR) is set by the line:
>
> install-stamp-indep: DESTDIR=$(CURDIR)/debian/tmp
>
> so is $(CURDIR) somehow debian/tmp when install-stamp-indep is run?
>
> > The issue here seems to be that the munge-man-directories helper in
> debian/
> > rules is not getting invoked, those directory moves are skipped, and
> there is
> > no man/ru/ directory at the expected path (only man/ru.UTF-8/ and
> man/ru.KOI8-R
> > /, which never got moved/deleted).
>
> I'm not sure that's actually the case.  It seems to be related to the
> above problem.  It's odd that you're encountering this but it's not
> being hit elsewhere.
>
> Is it somehow being evaluated twice or $(CURDIR) being carried over into
> the sub-make which then expands?
>
> Cheers,
> --
> James
> GPG Key: 4096R/91BF BF4D 6956 BD5D F7B7  2D23 DFE6 91AE 331B A3DB
>
>

Bug#846312: vim package fails to build with missing man files

[David Barnett]

I did notice the apparent duplication in the path, but I'm not seeing any
evidence that any commands in a define'd variables like that get executed,
e.g. if I change them to "echo blah", "/bin/false", or a bunch of
non-syntactically-valid gibberish.

David

On Fri, Dec 2, 2016 at 7:28 PM James McCoy  wrote:

> That implies that $(DESTDIR) is being set to debian/tmp/debian/tmp.
> $(DESTDIR) is set by the line:
>
> install-stamp-indep: DESTDIR=$(CURDIR)/debian/tmp
>
> so is $(CURDIR) somehow debian/tmp when install-stamp-indep is run?
>
> > The issue here seems to be that the munge-man-directories helper in
> debian/
> > rules is not getting invoked, those directory moves are skipped, and
> there is
> > no man/ru/ directory at the expected path (only man/ru.UTF-8/ and
> man/ru.KOI8-R
> > /, which never got moved/deleted).
>
> I'm not sure that's actually the case.  It seems to be related to the
> above problem.  It's odd that you're encountering this but it's not
> being hit elsewhere.
>
> Is it somehow being evaluated twice or $(CURDIR) being carried over into
> the sub-make which then expands?
>
> Cheers,
> --
> James
> GPG Key: 4096R/91BF BF4D 6956 BD5D F7B7  2D23 DFE6 91AE 331B A3DB
>

Bug#846312: vim package fails to build with missing man files

[James McCoy]

On Wed, Nov 30, 2016 at 06:54:28AM +, David Barnett wrote:
> When I try to build the v8.0.0095-1 tag from https://anonscm.debian.org/cgit/
> pkg-vim/vim.git using pbuilder, I get an error from the dh_install command:
>   dh_install
>   cp: cannot stat ‘debian/tmp/debian/tmp/usr/share/man/ru/man1/vim.1’: No such
> file or directory

That implies that $(DESTDIR) is being set to debian/tmp/debian/tmp.
$(DESTDIR) is set by the line:

install-stamp-indep: DESTDIR=$(CURDIR)/debian/tmp

so is $(CURDIR) somehow debian/tmp when install-stamp-indep is run?

> The issue here seems to be that the munge-man-directories helper in debian/
> rules is not getting invoked, those directory moves are skipped, and there is
> no man/ru/ directory at the expected path (only man/ru.UTF-8/ and 
> man/ru.KOI8-R
> /, which never got moved/deleted).

I'm not sure that's actually the case.  It seems to be related to the
above problem.  It's odd that you're encountering this but it's not
being hit elsewhere.

Is it somehow being evaluated twice or $(CURDIR) being carried over into
the sub-make which then expands?

Cheers,
-- 
James
GPG Key: 4096R/91BF BF4D 6956 BD5D F7B7  2D23 DFE6 91AE 331B A3DB

Bug#846312: vim package fails to build with missing man files

[David Barnett]

Package: vim
Version: 8.0.0095-1

When I try to build the v8.0.0095-1 tag from
https://anonscm.debian.org/cgit/pkg-vim/vim.git using pbuilder, I get an
error from the dh_install command:
  dh_install
  cp: cannot stat ‘debian/tmp/debian/tmp/usr/share/man/ru/man1/vim.1’: No
such file or directory
  dh_install: cp -a debian/tmp/debian/tmp/usr/share/man/ru/man1/vim.1
debian/vim-common/usr/share/man/ru/man1// returned exit code 1
  make: *** [install-stamp-indep] Error 2

The issue here seems to be that the munge-man-directories helper in
debian/rules is not getting invoked, those directory moves are skipped, and
there is no man/ru/ directory at the expected path (only man/ru.UTF-8/ and
man/ru.KOI8-R/, which never got moved/deleted).

I'm not sure why the $(munge-man-directories) invocation is completely
skipped for me, but inlining the body of munge-man-directories into the
places it's supposed to get invoked fixes the issues on my system.

David