Bug#853251: gitlab: git push fail - GitLab: API is not accessible

[Andrius Štikonas]

Emmanuel,

Strange, I just stumbled upon this bug yesterday and it worked with postgres 
database (which must be more tested option with gitlab as that is what 
gitlab.com uses). Make sure you restart everything after you comment out. But 
yes, this is quite annoying bug...

Regards,
Andrius

signature.asc
Description: This is a digitally signed message part.

Bug#853251: gitlab: git push fail - GitLab: API is not accessible

[Emmanuel Boudreault]

I can confirm that this bug affects our production servers as well.
Unfortunately the suggested temporary fix (commenting out) doesn't seem
to work. This might be because we are setting our DB to postgres in the
gitlab-debian.conf.


Regards,
Emmanuel

On Mon, 30 Jan 2017 12:50:21 -0700 "Justin F. Hallett"  wrote:
> Package: gitlab
> Version: 8.13.11+dfsg-1
> Severity: important
> 
> The issue is with 0300-git-2-11-support.patch and missing files in
the
> deb.
> 
> 1) 0300-git-2-11-support.patch only half implements things, it does
> create the proper files and adds parts of
> https://gitlab.com/gitlab-org/gitlab-ce/commit/f82d549d26af89cba5
e1a1c9b721c076f7a0
> but it's missing some important parts, mainly it's missing
> https://gitlab.com/gitlab-org/gitlab-ce/commit/1c994dbc05c14771447928
8126742f3fee158fd8#6e60f94696b534ed16ff1d4f8ca1a742242805bf_6_6
> where it's loads teh helper before using it.
> 
> 2) the patch creates lib/api/helpers/internal_helpers.rb but does not
> include it in the deb. So even if 1 is corrected it will fail to load
> the missing file.
> 
> As a temp fix you can just comment out "env:
> parse_allowed_environment_variables)" from lib/api/internal.rb and
> things work again, but the right fix would be to add the missing
lines
> to the patch and include the helper file in the deb.
> 
> Hope this helps others as it took me a bit to track it on my
production
> servers.
> 
> -- System Information:
> Debian Release: 9.0
>   APT prefers testing
>   APT policy: (500, 'testing'), (500, 'stable')
> Architecture: amd64 (x86_64)
> 
> Kernel: Linux 4.9.0-1-amd64 (SMP w/24 CPU cores)
> Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8)
> Shell: /bin/sh linked to /bin/dash
> Init: systemd (via /run/systemd/system)
> 
> Versions of packages gitlab depends on:
> ii  adduser   3.115
> ii  apache2 [httpd]   2.4.25-2
> ii  asciidoctor   1.5.4-2
> ii  bc1.06.95-9+b2
> ii  bundler   1.13.6-2
> ii  debconf [debconf-2.0] 1.5.59
> ii  git   1:2.11.0-2
> ii  gitlab-shell  3.6.6-2
> ii  gitlab-workhorse  0.8.5+debian-3
> ii  init-system-helpers   1.47
> ii  libjs-chartjs 1.0.2-1
> ii  libjs-clipboard   1.4.2-1
> ii  libjs-fuzzaldrin-
plus 0.3.1+git.20161008.da2cb58+dfsg-4
> ii  libjs-graphael0.5+dfsg-1
> ii  libjs-jquery-cookie   11-3
> ii  libjs-jquery-history  11-3
> ii  libjs-jquery-nicescroll   3.6.6-1
> ii  lsb-base  9.20161125
> ii  nodejs4.7.2~dfsg-1
> ii  openssh-client1:7.4p1-5
> ii  postfix [mail-transport-agent]3.1.4-3
> ii  postgresql-client 9.6+178

Bug#853251: gitlab: git push fail - GitLab: API is not accessible

[Justin F. Hallett]

Package: gitlab
Version: 8.13.11+dfsg-1
Severity: important

The issue is with 0300-git-2-11-support.patch and missing files in the
deb.

1) 0300-git-2-11-support.patch only half implements things, it does
create the proper files and adds parts of
https://gitlab.com/gitlab-org/gitlab-ce/commit/f82d549d26af89cba5e1a1c9b721c076f7a0
but it's missing some important parts, mainly it's missing
https://gitlab.com/gitlab-org/gitlab-ce/commit/1c994dbc05c147714479288126742f3fee158fd8#6e60f94696b534ed16ff1d4f8ca1a742242805bf_6_6
where it's loads teh helper before using it.

2) the patch creates lib/api/helpers/internal_helpers.rb but does not
include it in the deb. So even if 1 is corrected it will fail to load
the missing file.

As a temp fix you can just comment out "env:
parse_allowed_environment_variables)" from lib/api/internal.rb and
things work again, but the right fix would be to add the missing lines
to the patch and include the helper file in the deb.

Hope this helps others as it took me a bit to track it on my production
servers.

-- System Information:
Debian Release: 9.0
  APT prefers testing
  APT policy: (500, 'testing'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.9.0-1-amd64 (SMP w/24 CPU cores)
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages gitlab depends on:
ii  adduser   3.115
ii  apache2 [httpd]   2.4.25-2
ii  asciidoctor   1.5.4-2
ii  bc1.06.95-9+b2
ii  bundler   1.13.6-2
ii  debconf [debconf-2.0] 1.5.59
ii  git   1:2.11.0-2
ii  gitlab-shell  3.6.6-2
ii  gitlab-workhorse  0.8.5+debian-3
ii  init-system-helpers   1.47
ii  libjs-chartjs 1.0.2-1
ii  libjs-clipboard   1.4.2-1
ii  libjs-fuzzaldrin-plus 0.3.1+git.20161008.da2cb58+dfsg-4
ii  libjs-graphael0.5+dfsg-1
ii  libjs-jquery-cookie   11-3
ii  libjs-jquery-history  11-3
ii  libjs-jquery-nicescroll   3.6.6-1
ii  lsb-base  9.20161125
ii  nodejs4.7.2~dfsg-1
ii  openssh-client1:7.4p1-5
ii  postfix [mail-transport-agent]3.1.4-3
ii  postgresql-client 9.6+178
ii  postgresql-client-9.6 [postgresql-client  9.6.1-2
ii  postgresql-contrib9.6+178
ii  rake  10.5.0-2
ii  redis-server  3:3.2.6-1
ii  ruby  1:2.3.3
ii  ruby-ace-rails-ap 4.1.1-1
ii  ruby-activerecord-session-store   1.0.0-2
ii  ruby-acts-as-taggable-on  4.0.0-2
ii  ruby-addressable  2.4.0-1
ii  ruby-after-commit-queue   1.3.0-1
ii  ruby-akismet  2.0.0-1
ii  ruby-allocations  1.0.3-1+b2
ii  ruby-asana0.4.0-1
ii  ruby-attr-encrypted   3.0.1-2
ii  ruby-babosa   1.0.2-2
ii  ruby-base32   0.3.2-3
ii  ruby-bootstrap-sass   3.3.5.1-3
ii  ruby-browser  2.2.0-2
ii  ruby-cal-heatmap-rails3.6.0+dfsg-1
ii  ruby-carrierwave  0.10.0+gh-4
ii  ruby-charlock-holmes  0.7.3+dfsg-2+b3
ii  ruby-chronic  0.10.2-3
ii  ruby-chronic-duration 0.10.6-1
ii  ruby-coffee-rails 4.1.0-2
ii  ruby-coffee-script-source 1.10.0-1
ii  ruby-connection-pool  2.2.0-1
ii  ruby-creole   0.5.0-2
ii  ruby-d3-rails 3.5.6+dfsg-1
ii  ruby-default-value-for3.0.1-1
ii  ruby-devise   4.2.0-1
ii  ruby-devise-two-factor3.0.0-2
ii  ruby-diffy3.0.6-1
ii  ruby-doorkeeper   4.2.0-3
ii  ruby-dropzonejs-rails 0.7.1-1
ii  ruby-email-reply-parser   0.5.8-1
ii  ruby-fog-aws  0.12.0-1
ii  ruby-fog-azure0.0.2-1
ii  ruby-fog-core 1.42.0-1
ii  ruby-fog-google   0.3.2-1
ii  ruby-fog-local0.3.0-1
ii  ruby-fog-openstack0.1.6-4
ii  ruby-fog-rackspace0.1.1-4
ii  ruby-fogbugz