Bug#853809: unblock: e2fsprogs/1.43.4-2

[Cyril Brulebois]

Hi again,

Cyril Brulebois  (2017-02-10):
> Whatever release team members prefer I'll give -3 a try within d-i to
> check there's no surprises with a casual installation, and I'll update
> this bug report once I've done so.

Tests within d-i with -3 look OK: creating an ext4 root partition on a
full disc is OK, creating both ext2 for /boot and ext4 for / with
encrypted LVM is also OK.

So no objections from me, thanks.


KiBi.


signature.asc
Description: Digital signature

Bug#853809: unblock: e2fsprogs/1.43.4-2

[Cyril Brulebois]

Hi,

Theodore Ts'o  (2017-02-08):
> On Fri, Feb 03, 2017 at 10:34:09PM +0100, Emilio Pozuelo Monfort wrote:
> > 
> > This seems fine to me, unblocked. Cc'ing debian-boot@/Cyril for the
> > udeb unblock.
> 
> Hi, I've since found a regression that I would like to fix via a
> cherry pick from upstream.  The e2fsprogs/1.43.4-2 package hasn't
> transitioned into testing yet (it will in 3 more days).
> 
> Enclosed please find the source debdiff.  Would you prefer that I wait
> for 1.43.4-2 to transition into testing, and then upload 1.43.4-3 and
> then file a new unblock request?

Whatever release team members prefer I'll give -3 a try within d-i to
check there's no surprises with a casual installation, and I'll update
this bug report once I've done so.


KiBi.


signature.asc
Description: Digital signature

Bug#853809: unblock: e2fsprogs/1.43.4-2

[Theodore Ts'o]

On Fri, Feb 03, 2017 at 10:34:09PM +0100, Emilio Pozuelo Monfort wrote:
> 
> This seems fine to me, unblocked. Cc'ing debian-boot@/Cyril for the udeb 
> unblock.
>

Hi, I've since found a regression that I would like to fix via a
cherry pick from upstream.  The e2fsprogs/1.43.4-2 package hasn't
transitioned into testing yet (it will in 3 more days).

Enclosed please find the source debdiff.  Would you prefer that I wait
for 1.43.4-2 to transition into testing, and then upload 1.43.4-3 and
then file a new unblock request?

Many thanks!!

- Ted

dpkg-source: warning: extracting unsigned source package 
(/build/debian/e2fsprogs_1.43.4-2.dsc)
dpkg-source: warning: extracting unsigned source package 
(/build/jessie/e2fsprogs_1.43.4-3.dsc)
diff -Nru e2fsprogs-1.43.4/debian/changelog e2fsprogs-1.43.4/debian/changelog
--- e2fsprogs-1.43.4/debian/changelog   2017-01-31 19:54:55.0 -0500
+++ e2fsprogs-1.43.4/debian/changelog   2017-02-05 20:46:55.0 -0500
@@ -1,3 +1,10 @@
+e2fsprogs (1.43.4-3) UNRELEASED; urgency=medium
+
+  * Fix tune2fs regression introduced in 1.43.4 --- enabling additional
+quota types has become a no-op.
+
+ -- Theodore Y. Ts'o   Sun, 05 Feb 2017 20:46:55 -0500
+
 e2fsprogs (1.43.4-2) unstable; urgency=medium
 
   * Re-enable metadata_csum for Debian (which was accidentally disabled
diff -Nru e2fsprogs-1.43.4/debian/patches/series 
e2fsprogs-1.43.4/debian/patches/series
--- e2fsprogs-1.43.4/debian/patches/series  2017-01-31 19:54:55.0 
-0500
+++ e2fsprogs-1.43.4/debian/patches/series  2017-02-05 20:46:55.0 
-0500
@@ -1,2 +1,3 @@
 e2fsprogs-1.43.4-release-fixup
 enable-metadata_csum-by-default
+tune2fs-fix-quota-enablement-regression
diff -Nru 
e2fsprogs-1.43.4/debian/patches/tune2fs-fix-quota-enablement-regression 
e2fsprogs-1.43.4/debian/patches/tune2fs-fix-quota-enablement-regression
--- e2fsprogs-1.43.4/debian/patches/tune2fs-fix-quota-enablement-regression 
1969-12-31 19:00:00.0 -0500
+++ e2fsprogs-1.43.4/debian/patches/tune2fs-fix-quota-enablement-regression 
2017-02-05 20:46:55.0 -0500
@@ -0,0 +1,71 @@
+From: Eric Whitney 
+Description: tune2fs: fix quota enablement regression
+ Commit 5c2a665afa (Avoid dereferencing beyond allocated memory in quota
+ handling) induced a quota enablement regression in tune2fs.  Attempts
+ to enable a particular quota type (tune2fs -O project , for
+ example) set the appropriate feature flag in the superblock but the
+ quota file for the type is not initialized.
+ . 
+ The regression prevents the current version of xfstests from running
+ generic/383, 384, 385, and 386 (all project quota tests) with e2fsprogs
+ 1.43.4.  These tests exit with the message "Installed kernel does not
+ support project quotas", but the actual problem is that the project
+ quota file is not present.
+Origin: upstream, commit: 5f82cc95b31f87c62f18848142597d094fe966ee
+---
+ misc/tune2fs.c | 20 ++--
+ 1 file changed, 10 insertions(+), 10 deletions(-)
+
+diff --git a/misc/tune2fs.c b/misc/tune2fs.c
+index 62395776..f1bad606 100644
+--- a/misc/tune2fs.c
 b/misc/tune2fs.c
+@@ -1483,7 +1483,7 @@ static void handle_quota_options(ext2_filsys fs)
+   quota_ctx_t qctx;
+   ext2_ino_t qf_ino;
+   enum quota_type qtype;
+-  int enable = 0;
++  unsigned int qtype_bits = 0;
+ 
+   for (qtype = 0 ; qtype < MAXQUOTAS; qtype++)
+   if (quota_enable[qtype] != 0)
+@@ -1492,19 +1492,19 @@ static void handle_quota_options(ext2_filsys fs)
+   /* Nothing to do. */
+   return;
+ 
+-  retval = quota_init_context(, fs, 0);
++  for (qtype = 0; qtype < MAXQUOTAS; qtype++) {
++  if (quota_enable[qtype] == QOPT_ENABLE)
++  qtype_bits |= 1 << qtype;
++  }
++
++  retval = quota_init_context(, fs, qtype_bits);
+   if (retval) {
+   com_err(program_name, retval,
+   _("while initializing quota context in support 
library"));
+   exit(1);
+   }
+-  for (qtype = 0 ; qtype < MAXQUOTAS; qtype++) {
+-  if (quota_enable[qtype] == QOPT_ENABLE) {
+-  enable = 1;
+-  break;
+-  }
+-  }
+-  if (enable)
++
++  if (qtype_bits)
+   quota_compute_usage(qctx);
+ 
+   for (qtype = 0 ; qtype < MAXQUOTAS; qtype++) {
+@@ -1540,7 +1540,7 @@ static void handle_quota_options(ext2_filsys fs)
+ 
+   quota_release_context();
+ 
+-  if (enable) {
++  if (qtype_bits) {
+   ext2fs_set_feature_quota(fs->super);
+   ext2fs_mark_super_dirty(fs);
+   } else {
+-- 
+2.11.0.rc0.7.gbe5a750
+

Bug#853809: unblock: e2fsprogs/1.43.4-2

[Cyril Brulebois]

Emilio Pozuelo Monfort  (2017-02-03):
> This seems fine to me, unblocked. Cc'ing debian-boot@/Cyril for the
> udeb unblock.

No objections in principle, but it'd be nice to have d-i tested against
the latest version. Will try to look into it over the next few days.


KiBi.


signature.asc
Description: Digital signature

Bug#853809: unblock: e2fsprogs/1.43.4-2

[Emilio Pozuelo Monfort]

On 01/02/17 04:48, Theodore Y. Ts'o wrote:
> Package: release.debian.org
> Severity: normal
> User: release.debian@packages.debian.org
> Usertags: unblock
> 
> Please unblock package e2fsprogs
> 
> 1.43.4 is the new upstream version of e2fsprogs which fixes a RC bug
> (#840733: e2fsprogs contains non-free file).  n.b., the non-free file is
> only used in a regression test and isn't actually included in any
> binary.  There are also a number of important bug fixes that I'd really
> like to get into stretch.  See the debian changelog or [1] for more
> details.
> 
> [1] http://e2fsprogs.sourceforge.net/e2fsprogs-release.html#1.43.4
> 
> Note: there is a udeb involved since this will also require a d-i
> release manager unblock.  I'm unclear whether there is a separate
> process for requesting that particlar unblock.  Please advise.
> 
> I just uploaded 1.43.4-2 to sid today, so it will be five days old when
> the Stretch Freeze hits.  So I'm filing this bug now as a heads up,
> since unless the release schedule slips, this isn't going to meet the
> mandatory 10 day delay which was announced in December.

This seems fine to me, unblocked. Cc'ing debian-boot@/Cyril for the udeb 
unblock.

Cheers,
Emilio

Bug#853809: unblock: e2fsprogs/1.43.4-2

[Theodore Y. Ts'o]

Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock

Please unblock package e2fsprogs

1.43.4 is the new upstream version of e2fsprogs which fixes a RC bug
(#840733: e2fsprogs contains non-free file).  n.b., the non-free file is
only used in a regression test and isn't actually included in any
binary.  There are also a number of important bug fixes that I'd really
like to get into stretch.  See the debian changelog or [1] for more
details.

[1] http://e2fsprogs.sourceforge.net/e2fsprogs-release.html#1.43.4

Note: there is a udeb involved since this will also require a d-i
release manager unblock.  I'm unclear whether there is a separate
process for requesting that particlar unblock.  Please advise.

I just uploaded 1.43.4-2 to sid today, so it will be five days old when
the Stretch Freeze hits.  So I'm filing this bug now as a heads up,
since unless the release schedule slips, this isn't going to meet the
mandatory 10 day delay which was announced in December.


Files in second .deb but not in first
-
-rw-r--r--  root/root   /usr/share/locale/fi/LC_MESSAGES/e2fsprogs.mo
-rw-r--r--  root/root   /usr/share/locale/ms/LC_MESSAGES/e2fsprogs.mo

Files in first .deb but not in second
-
lrwxrwxrwx  root/root   /sbin/fsck.ext4dev -> e2fsck
lrwxrwxrwx  root/root   /sbin/mkfs.ext4dev -> mke2fs
lrwxrwxrwx  root/root   /usr/share/man/man8/fsck.ext4dev.8.gz -> e2fsck.8.gz
lrwxrwxrwx  root/root   /usr/share/man/man8/mkfs.ext4dev.8.gz -> mke2fs.8.gz

Control files: lines which differ (wdiff format)

Installed-Size: [-3851-] {+4022+}
Pre-Depends: e2fslibs (= [-1.43.3-1),-] {+1.43.4-2),+} libblkid1 (>= 2.17.2), 
libc6 (>= 2.14), libcomerr2 (>= 1.42~WIP-2011-10-05-1), libss2 (>= 1.34-1), 
libuuid1 (>= 2.16), util-linux (>= 2.15~rc1-1)
Version: [-1.43.3-1-] {+1.43.4-2+}

unblock e2fsprogs/1.43.4-2

-- System Information:
Debian Release: 9.0
  APT prefers testing
  APT policy: (650, 'testing'), (600, 'unstable-debug'), (600, 'unstable'), 
(500, 'testing-debug'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 4.9.0-00090-g3a45c5c (SMP w/4 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)