Bug#855251: easytag corrupt ogg files

2018-05-14 Thread Bruno Kleinert
Am Sonntag, den 13.05.2018, 12:35 +0100 schrieb James Cowgill:
> Hi,
> 
> On 13/05/18 11:47, Bruno Kleinert wrote:
> > Hi James,
> > 
> > unfortunately it doesn't seem fixed to me. I tried the following
> > with
> > 2.4.3-4:
> >1. youtube-dl -x -f 'bestaudio' 'https://www.youtube.com/watch?v
> > =ui_odI
> >   vVIBE'
> >2. Use soundconverter to convert it to Ogg Vorbis
> >3. vorbisgain Flux\ Pavilion\ -\ Hold\ Me\ Close-ui_odIvVIBE.ogg 
> > (Add
> >   replay gain tags)
> >4. ogginfo Flux\ Pavilion\ -\ Hold\ Me\ Close-ui_odIvVIBE.ogg |
> > grep
> >   REPLAY (Confirm that the file contains replay gain tags)
> >5. Use easytag to add Title tag "abcd" and save the file
> >6. ogginfo Flux\ Pavilion\ -\ Hold\ Me\ Close-ui_odIvVIBE.ogg |
> > grep
> >   REPLAY (Won't output anything, replay gain tags got lost)
> > 
> > At least oggz-validate didn't complain about a broken Ogg file.
> > Neither
> > before, nor after editing it with easytag.
> 
> This is not the same bug. This bug is about easytag corrupting the
> audio
> data in vorbis files whereas for you it looks like easytag has
> removed a
> tag it (presumably) doesn't support. Could you file a separate bug?
> 
> Thanks,
> James

Hi James,

sorry for mixing things up. As you suggested, I filed a new bug. It's
this one:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=898654

Cheers - Bruno

signature.asc
Description: This is a digitally signed message part


Bug#855251: easytag corrupt ogg files

2018-05-13 Thread James Cowgill
Hi,

On 13/05/18 11:47, Bruno Kleinert wrote:
> Hi James,
> 
> unfortunately it doesn't seem fixed to me. I tried the following with
> 2.4.3-4:
>1. youtube-dl -x -f 'bestaudio' 'https://www.youtube.com/watch?v=ui_odI
>   vVIBE'
>2. Use soundconverter to convert it to Ogg Vorbis
>3. vorbisgain Flux\ Pavilion\ -\ Hold\ Me\ Close-ui_odIvVIBE.ogg (Add
>   replay gain tags)
>4. ogginfo Flux\ Pavilion\ -\ Hold\ Me\ Close-ui_odIvVIBE.ogg | grep
>   REPLAY (Confirm that the file contains replay gain tags)
>5. Use easytag to add Title tag "abcd" and save the file
>6. ogginfo Flux\ Pavilion\ -\ Hold\ Me\ Close-ui_odIvVIBE.ogg | grep
>   REPLAY (Won't output anything, replay gain tags got lost)
> 
> At least oggz-validate didn't complain about a broken Ogg file. Neither
> before, nor after editing it with easytag.

This is not the same bug. This bug is about easytag corrupting the audio
data in vorbis files whereas for you it looks like easytag has removed a
tag it (presumably) doesn't support. Could you file a separate bug?

Thanks,
James



signature.asc
Description: OpenPGP digital signature


Bug#855251: easytag corrupt ogg files

2018-05-13 Thread Bruno Kleinert
Am Sonntag, den 25.03.2018, 12:55 +0100 schrieb James Cowgill:
> Hi,
> 
> On 03/01/18 16:50, James Cowgill wrote:
> > On 16/02/17 01:02, Samuele Battarra wrote:
> > > Package: easytag
> > > Version: 2.4.3-1
> > > Severity: normal
> > > 
> > > Dear Maintainer,
> > > I have a ogg file encoded from a live cd, I split it to single
> > > tracks with oggsplt and then tag the tracks with easytag.
> > > When I play the files I hear a click at file change.
> > > The click is not present in files before the tagging and if I tag
> > > with kid3.
> > 
> > As you might have noticed, I have decided that the best way to fix
> > this
> > is to disable support for OGG and related media types in easytag
> > for the
> > time being. Solving this bug is apparently quite complex and while
> > the
> > upstream bug has been open for over a year, there has not been much
> > progress on it. I think it is better to have some version in buster
> > (which does not mangle your media files) than nothing at all.
> 
> I have just uploaded easytag 2.4.3-4 which reverts an upstream commit
> which I think will fix this (you will need to wait a few hours before
> it
> appears on the mirrors). It would be very useful if people could test
> it
> for me before I upload the fix to stable.
> 
> Thanks,
> James

Hi James,

unfortunately it doesn't seem fixed to me. I tried the following with
2.4.3-4:
   1. youtube-dl -x -f 'bestaudio' 'https://www.youtube.com/watch?v=ui_odI
  vVIBE'
   2. Use soundconverter to convert it to Ogg Vorbis
   3. vorbisgain Flux\ Pavilion\ -\ Hold\ Me\ Close-ui_odIvVIBE.ogg (Add
  replay gain tags)
   4. ogginfo Flux\ Pavilion\ -\ Hold\ Me\ Close-ui_odIvVIBE.ogg | grep
  REPLAY (Confirm that the file contains replay gain tags)
   5. Use easytag to add Title tag "abcd" and save the file
   6. ogginfo Flux\ Pavilion\ -\ Hold\ Me\ Close-ui_odIvVIBE.ogg | grep
  REPLAY (Won't output anything, replay gain tags got lost)

At least oggz-validate didn't complain about a broken Ogg file. Neither
before, nor after editing it with easytag.

Cheers - Bruno

signature.asc
Description: This is a digitally signed message part


Bug#855251: easytag corrupt ogg files

2018-03-25 Thread James Cowgill
Hi,

On 03/01/18 16:50, James Cowgill wrote:
> On 16/02/17 01:02, Samuele Battarra wrote:
>> Package: easytag
>> Version: 2.4.3-1
>> Severity: normal
>>
>> Dear Maintainer,
>> I have a ogg file encoded from a live cd, I split it to single tracks with 
>> oggsplt and then tag the tracks with easytag.
>> When I play the files I hear a click at file change.
>> The click is not present in files before the tagging and if I tag with kid3.
> 
> As you might have noticed, I have decided that the best way to fix this
> is to disable support for OGG and related media types in easytag for the
> time being. Solving this bug is apparently quite complex and while the
> upstream bug has been open for over a year, there has not been much
> progress on it. I think it is better to have some version in buster
> (which does not mangle your media files) than nothing at all.

I have just uploaded easytag 2.4.3-4 which reverts an upstream commit
which I think will fix this (you will need to wait a few hours before it
appears on the mirrors). It would be very useful if people could test it
for me before I upload the fix to stable.

Thanks,
James



signature.asc
Description: OpenPGP digital signature


Bug#855251: easytag corrupt ogg files

2018-03-07 Thread Tobias Brink
Package: easytag
Version: 2.4.3-1
Followup-For: Bug #855251

Could you please also push the update disabling OGG support to stable? I seem
to have corrupted who knows how many files over the last weeks. This is
especially insidious, since the corrupted files still work in some media
players, but do not work with others (I had huge trouble on my Android phone,
for example, and had no idea it was in fact easytag's fault)!



-- System Information:
Debian Release: 9.3
  APT prefers stable
  APT policy: (990, 'stable'), (500, 'stable-updates'), (500, 'stable-debug')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-6-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8), LANGUAGE= 
(charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages easytag depends on:
ii  dconf-gsettings-backend [gsettings-backend]  0.26.0-2+b1
ii  libc62.24-11+deb9u1
ii  libflac8 1.3.2-1
ii  libgcc1  1:6.3.0-18+deb9u1
ii  libgdk-pixbuf2.0-0   2.36.5-2+deb9u2
ii  libglib2.0-0 2.50.3-2
ii  libgtk-3-0   3.22.11-1
ii  libid3-3.8.3v5   3.8.3-16.2+b1
ii  libid3tag0   0.15.1b-12
ii  libogg0  1.3.2-1
ii  libopus0 1.2~alpha2-1
ii  libopusfile0 0.8-1+b1
ii  libspeex11.2~rc1.2-1+b2
ii  libstdc++6   6.3.0-18+deb9u1
ii  libtag1v51.11.1+dfsg.1-0.1
ii  libvorbis0a  1.3.5-4+deb9u1
ii  libvorbisfile3   1.3.5-4+deb9u1
ii  libwavpack1  5.0.0-2+deb9u1

Versions of packages easytag recommends:
ii  gnome-icon-theme  3.12.0-2
ii  gvfs  1.30.4-1
ii  yelp  3.22.0-1

Versions of packages easytag suggests:
pn  easytag-nautilus  

-- no debconf information



Bug#855251: easytag corrupt ogg files

2018-01-03 Thread James Cowgill
Control: clone -1 -2
Control: notfound -2 2.4.3-1
Control: found -2 2.4.3-2
Control: severity -2 normal
Control: tags -2 - pending
Control: retitle -2 easytag: re-enable ogg after corruption bug is fixed

Hi,

On 16/02/17 01:02, Samuele Battarra wrote:
> Package: easytag
> Version: 2.4.3-1
> Severity: normal
> 
> Dear Maintainer,
> I have a ogg file encoded from a live cd, I split it to single tracks with 
> oggsplt and then tag the tracks with easytag.
> When I play the files I hear a click at file change.
> The click is not present in files before the tagging and if I tag with kid3.

As you might have noticed, I have decided that the best way to fix this
is to disable support for OGG and related media types in easytag for the
time being. Solving this bug is apparently quite complex and while the
upstream bug has been open for over a year, there has not been much
progress on it. I think it is better to have some version in buster
(which does not mangle your media files) than nothing at all.

I have cloned this bug to remind me to re-enable ogg support once the
corruption bug is fixed.

Thanks,
James



signature.asc
Description: OpenPGP digital signature


Bug#855251: easytag corrupt ogg files

2017-02-19 Thread James Cowgill
Control: tags -1 moreinfo

Hi,

On 16/02/17 01:02, Samuele Battarra wrote:
> Package: easytag
> Version: 2.4.3-1
> Severity: normal
> 
> Dear Maintainer,
> I have a ogg file encoded from a live cd, I split it to single tracks with 
> oggsplt and then tag the tracks with easytag.
> When I play the files I hear a click at file change.
> The click is not present in files before the tagging and if I tag with kid3.

I found this upstream bug which might be similar to yours:
https://bugzilla.gnome.org/show_bug.cgi?id=776110

In that bug, any ogg vorbis file tagged with easytag becomes corrupted.
The affect is that ffmpeg displays an error when trying to read it and
the very initial part of the file is repeated when played (in mpv
anyway). Does this sound like your bug?

To clarify, are you dealing with ogg videos or ogg audio?

Thanks,
James



signature.asc
Description: OpenPGP digital signature


Bug#855251: easytag corrupt ogg files

2017-02-15 Thread Samuele Battarra
Package: easytag
Version: 2.4.3-1
Severity: normal

Dear Maintainer,
I have a ogg file encoded from a live cd, I split it to single tracks with 
oggsplt and then tag the tracks with easytag.
When I play the files I hear a click at file change.
The click is not present in files before the tagging and if I tag with kid3.

-- System Information:
Debian Release: 9.0
  APT prefers testing
  APT policy: (900, 'testing'), (500, 'stable-updates'), (500, 'unstable'), 
(500, 'stable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 4.9.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=it_IT.UTF-8, LC_CTYPE=it_IT.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages easytag depends on:
ii  dconf-gsettings-backend [gsettings-backend]  0.26.0-2
ii  libc62.24-9
ii  libflac8 1.3.2-1
ii  libgcc1  1:6.3.0-6
ii  libgdk-pixbuf2.0-0   2.36.4-1
ii  libglib2.0-0 2.50.2-2
ii  libgtk-3-0   3.22.7-2
ii  libid3-3.8.3v5   3.8.3-16.2
ii  libid3tag0   0.15.1b-12
ii  libogg0  1.3.2-1
ii  libopus0 1.2~alpha2-1
ii  libopusfile0 0.8-1+b1
ii  libspeex11.2~rc1.2-1
ii  libstdc++6   6.3.0-6
ii  libtag1v51.11.1+dfsg.1-0.1
ii  libvorbis0a  1.3.5-4
ii  libvorbisfile3   1.3.5-4
ii  libwavpack1  5.0.0-2

Versions of packages easytag recommends:
pn  gnome-icon-theme  
pn  gvfs  
pn  yelp  

Versions of packages easytag suggests:
pn  easytag-nautilus  

-- no debconf information